[RESOLVED] HELP NEEDED

gbjork50

Hi,

I have a website that requires users to sign up and receive a verification email. Well, currently, when a new user signs up, they are getting this error:

Parse error: parse error, unexpected '<' in /home/templeof/public_html/signup_go.php on line 75

Here is the code for the page that is supposed to send the verification mail:

<?
include_once "class.DBConn.php";
include_once "class.Forms.php";
$form = new Form();
$conn = new DBConn();

switch($form->ReqVarName)
{
    case "fname":       $mesaj = "First name is required."; break;
    case "lname":       $mesaj = "Last name is required."; break;
    case "address":     $mesaj = "Streed address is required."; break;
    case "city":        $mesaj = "City is required."; break;
    case "state":       $mesaj = "State is required."; break;
    case "phone":       $mesaj = "Phone No. is required."; break;
    case "zip":         $mesaj = "Zip code is required."; break;
    case "email":       $mesaj = "A valid email address is required."; break;
    case "username":    $mesaj = "Username is required."; break;
    case "password":    $mesaj = "Password is required."; break;
    case "cfmpassword": $mesaj = "Password confirm is required"; break;
    case "refcode":     $mesaj = "Referer code is required";break;
   default :           $mesaj = "";break;
}

if ( !empty($mesaj) ) 
{
    $mesaj = "<tr><td colspan=\"3\" align=\"center\" style=\"color:red\">$mesaj</td></tr>";
    include "signup.php";
    exit (0);
}

if ( strcmp($_POST['password'], $_POST['cfmpassword']) !=0 && empty($mesaj) )
{
    $mesaj = "Passwords do not match";
    $form->ReqVarName = "cfmpassword";
}

if ( strlen($_POST['password']) < 5 && empty($mesaj) )
{ 
    $mesaj = "Password is too short. Minimum 5 characters.";
    $form->ReqVarName = "password";
} 

$link = $conn->DBStart();
$isAlready = mysql_query("SELECT id FROM users WHERE username = '".$_POST['username']."' ");
if ( mysql_num_rows($isAlready) > 0 ) 
{
    $mesaj = "This username is alreasy taken.";
    $form->ReqVarName = "email";
}

if ( !empty($mesaj) ) 
{
    $mesaj = "<tr><td colspan=\"3\" align=\"center\" style=\"color:red\">$mesaj</td></tr>";
    include "signup.php";
    exit (0);
}
else
{

    $query = "INSERT INTO users VALUES ('', '".$_POST['fname']."', '".$_POST['lname']."', '".$_POST['address']."', '".$_POST['city']."'
                                        , '".$_POST['state']."', '".$_POST['phone']."', '".$_POST['zip']."', '".$_POST['email']."'
                                        , '".$_POST['imid']."', '".$_POST['username']."', '".md5($_POST['password'])."', '".date("Y-m-d")."'
                                        , '".$_POST['gtag']."', '".$_POST['psp']."','' , '".$_POST['refcode']."'
                                        , 0, 0, 0, 0, 0, 0, 0)";

    if ( mysql_query( $query ) )
    {

include("send_mail_html.php");

$sendto = $_POST['email'];
$subject = "Registration at TempleOfGames.com";
$message = "welcome";
<html xmlns="http://www.w3.org/1999/xhtml">
<head

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>

If you can help me be able to register new memebers and have them receive an email verification, I will paypal you $30 instantly or put $40 towards the JDRF charity (ron Santo's Foundaton) in your name.

Thanks,
Greg

BobLennon

Could it be that you need a ?> to end the script before the next html statement on line 75?

Weedpacket

Waving money isn't a good idea: some consider it an insult; and solicitation is not permitted on these forums.

BobLennon

Weedpacket wrote:
Waving money isn't a good idea: some consider it an insult; and solicitation is not permitted on these forums.

Well said Weedpacket.

But problems often exist that can be solved with incentives or not.

In this case, the incentives were unimportant.

gbjork50

weedPacket:
I was willing to pay someone for their time to help me with a problem I have spent 72 hours trying to fix, I wouldn't call that solicitation.

Instead of being the forum police, why not try and help out, I also said I would donate to a charity in your name.

I was sincerely trying to be as diplomatic as possible.

I just want the damn problem fixed and willing to do just about anything.

Any help would be greatly appreciated.

Thanks in advance,
Greg

bradgrafelman

cough

BobLennon wrote:
Could it be that you need a ?> to end the script before the next html statement on line 75?

gbjork50

FYI - 'Line 75' in the code is 'else' so it has no > on that line.

Im ready to go crazy over this. anybody that can help, please do. I will forever be in your debt.

bradgrafelman

gbjork50 wrote:
FYI - 'Line 75' in the code is 'else' so it has no > on that line.

'Fraid not... here is line 75:

<html xmlns="http://www.w3.org/1999/xhtml">

Also, see above post.

EDIT: Just some tips:
1. Don't use short tags - they're pretty much deprecated.
2. You're more than likely vulnerable to SQL injections - don't use untrusted data ($_POST[] data, for example) in SQL queries without sanitizing them with functions like [man]addslashes/man, [man]mysql_real_escape_string/man, etc.
3. In queries like that on line 44, it might help your DB engine if you add a "LIMIT 1". Basically, any query that you're just checking if data matching a criteria exists - in other words, you expect either 0 or 1 rows - should have a "LIMIT 1" on the end of them IMHO.

ragedigital

$sendto = $_POST['email'];
$subject = "Registration at TempleOfGames.com";
$message = "welcome";
?>

gbjork50

After making the change above, I now get:
Parse error: parse error, unexpected $ in /home/templeof/public_html/signup_go.php on line 79

Anyone.

IREALLY appreciate everyone's input so far........

bradgrafelman

This line:

if ( mysql_query( $query ) )
{

has an unclosed opening brace.

gbjork50

Let me also say the following:
1. I didnt write the code, just screwed it up
2. I know NOTHING about php or any web coding

So please take it easy on me.

Thanks again everyone........

PLEASE HELP

gbjork50

bradgrafelman wrote:
This line:
if ( mysql_query( $query ) )
{
has an unclosed opening brace.

nope, didnt work....just gave me another error on line 65

Thanks though 🙂

bradgrafelman

gbjork50 wrote:
nope, didnt work

Well, it worked in the sense that it made the syntax of your code less broken. Post a fresh copy of this script for us so that we can make sure we're all on the same page.

Don't forget to use the board's [ PHP ][ /PHP ] tags (without the spaces) when you post the code.

ragedigital

You were also missing a brace after the else statement where your query is formed:

<?
include_once "class.DBConn.php";
include_once "class.Forms.php";
$form = new Form();
$conn = new DBConn();

switch($form->ReqVarName)
{
case "fname": $mesaj = "First name is required."; break;
case "lname": $mesaj = "Last name is required."; break;
case "address": $mesaj = "Streed address is required."; break;
case "city": $mesaj = "City is required."; break;
case "state": $mesaj = "State is required."; break;
case "phone": $mesaj = "Phone No. is required."; break;
case "zip": $mesaj = "Zip code is required."; break;
case "email": $mesaj = "A valid email address is required."; break;
case "username": $mesaj = "Username is required."; break;
case "password": $mesaj = "Password is required."; break;
case "cfmpassword": $mesaj = "Password confirm is required"; break;
case "refcode": $mesaj = "Referer code is required";break;
default : $mesaj = "";break;
}

if ( !empty($mesaj) )
{
$mesaj = "<tr><td colspan=\"3\" align=\"center\" style=\"color:red\">$mesaj</td></tr>";
include "signup.php";
exit (0);
}

if ( strcmp($_POST['password'], $_POST['cfmpassword']) !=0 && empty($mesaj) )
{
$mesaj = "Passwords do not match";
$form->ReqVarName = "cfmpassword";
}

if ( strlen($_POST['password']) < 5 && empty($mesaj) )
{
$mesaj = "Password is too short. Minimum 5 characters.";
$form->ReqVarName = "password";
}

$link = $conn->DBStart();
$isAlready = mysql_query("SELECT id FROM users WHERE username = '".$_POST['username']."' ");
if ( mysql_num_rows($isAlready) > 0 )
{
$mesaj = "This username is alreasy taken.";
$form->ReqVarName = "email";
}

if ( !empty($mesaj) )
{
$mesaj = "<tr><td colspan=\"3\" align=\"center\" style=\"color:red\">$mesaj</td></tr>";
include "signup.php";
exit (0);
}
else
{

$query = "INSERT INTO users VALUES ('', '".$_POST['fname']."', '".$_POST['lname']."', '".$_POST['address']."', '".$_POST['city']."'
, '".$_POST['state']."', '".$_POST['phone']."', '".$_POST['zip']."', '".$_POST['email']."'
, '".$_POST['imid']."', '".$_POST['username']."', '".md5($_POST['password'])."', '".date("Y-m-d")."'
, '".$_POST['gtag']."', '".$_POST['psp']."','' , '".$_POST['refcode']."'
, 0, 0, 0, 0, 0, 0, 0)";

}

if ( mysql_query( $query ) )
{
include("send_mail_html.php");

$sendto = $_POST['email'];
$subject = "Registration at TempleOfGames.com";
$message = "welcome";
}
?>


<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>

gbjork50

ragedigital wrote:

You were also missing a brace after the else statement where your query is formed:

<?
include_once "class.DBConn.php";
include_once "class.Forms.php";
$form = new Form();
$conn = new DBConn();

switch($form->ReqVarName)
{
case "fname": $mesaj = "First name is required."; break;
case "lname": $mesaj = "Last name is required."; break;
case "address": $mesaj = "Streed address is required."; break;
case "city": $mesaj = "City is required."; break;
case "state": $mesaj = "State is required."; break;
case "phone": $mesaj = "Phone No. is required."; break;
case "zip": $mesaj = "Zip code is required."; break;
case "email": $mesaj = "A valid email address is required."; break;
case "username": $mesaj = "Username is required."; break;
case "password": $mesaj = "Password is required."; break;
case "cfmpassword": $mesaj = "Password confirm is required"; break;
case "refcode": $mesaj = "Referer code is required";break;
default : $mesaj = "";break;
}

if ( !empty($mesaj) )
{
$mesaj = "<tr><td colspan=\"3\" align=\"center\" style=\"color:red\">$mesaj</td></tr>";
include "signup.php";
exit (0);
}

if ( strcmp($_POST['password'], $_POST['cfmpassword']) !=0 && empty($mesaj) )
{
$mesaj = "Passwords do not match";
$form->ReqVarName = "cfmpassword";
}

if ( strlen($_POST['password']) < 5 && empty($mesaj) )
{
$mesaj = "Password is too short. Minimum 5 characters.";
$form->ReqVarName = "password";
}

$link = $conn->DBStart();
$isAlready = mysql_query("SELECT id FROM users WHERE username = '".$_POST['username']."' ");
if ( mysql_num_rows($isAlready) > 0 )
{
$mesaj = "This username is alreasy taken.";
$form->ReqVarName = "email";
}

if ( !empty($mesaj) )
{
$mesaj = "<tr><td colspan=\"3\" align=\"center\" style=\"color:red\">$mesaj</td></tr>";
include "signup.php";
exit (0);
}
else
{

$query = "INSERT INTO users VALUES ('', '".$_POST['fname']."', '".$_POST['lname']."', '".$_POST['address']."', '".$_POST['city']."'
, '".$_POST['state']."', '".$_POST['phone']."', '".$_POST['zip']."', '".$_POST['email']."'
, '".$_POST['imid']."', '".$_POST['username']."', '".md5($_POST['password'])."', '".date("Y-m-d")."'
, '".$_POST['gtag']."', '".$_POST['psp']."','' , '".$_POST['refcode']."'
, 0, 0, 0, 0, 0, 0, 0)";

}

if ( mysql_query( $query ) )
{
include("send_mail_html.php");

$sendto = $_POST['email'];
$subject = "Registration at TempleOfGames.com";
$message = "welcome";
}
?>


<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>

Hi!

I put in the code from the post above and now I dont get an error, I get a blank white page whereas it used to go to the page that said "A verification email was sent to the email you provided"

And I am not getting any verification email sent, but it is registering the name and info I put in........

Any thoughts?

My original code is at the top of this topic.

Thanks again!