[RESOLVED] redoing a site in CSS and running into some PHP issues

NudelZ

Hi there,

I'm currently redoing a site to use CSS and the back-end guy split. Was supposed to just create the CSS pages and and it off, but now it seems like i'll need to pull my weight with the PHP part of things-- trying to see if I can figure this by myself. pretty much first time i'm dealing with PHP, so while I read the basics, troubleshooting other people's code is still somewhat beyond me.

background, all these were implemented before I joined in, and I'm still trying to understand them all:
- site is using TinyMCE as an editor/CMS (a JS based solution) with a MySQL db.
- site has 2 templates controlled by PHP. one for all pages but the calendar, the second is for the calendar.

i've redid all presentation to be CSS-driven and having some problems with coding the logic of the PHP so that the site actually works. No parsing errors with what i've done, but obviously it's not functioning.

<ul>
<?php
	for($i=0; $i<$navigation_count; $i++)
	{
		echo "<li><a href=\"".$navigation_links[$i]['href']."\"";
		if(ereg($page_name."$", $navigation_links[$i]['href'])){echo "id=\"current\""; }
		echo ">".$navigation_links[$i]['name']."</a></li>\n";

}
?>
</ul>

this is the statement that is controlling the navigation, and it seems to work-- the URLs are changing.

this controls the display of the page's content; but this is not changing at all. The approved design is making one change over the existing code, adding an additional display div on the the homepage only (which includes the lady's photo on the left using a nifty image replacement method...) The first portion of code is from the top of the page, thought showing the varibales initialized and all will be helpful (ignore the part about 'quote,' that part is unchanged and works):

<?php
	if( strlen($page_name) == 0 )
	{
		$page_name = 'home';
	}
	if( ereg("^[[:alnum:]]+$", $page_name) &&
		($page = file_get_contents('../content/'.$page_name.'.txt')) )
	{
		if ( ($pos = strpos( $page, "\n" )) && 
			(strlen($page) > $pos+1) )
		{
			$page_title = substr($page, 0, $pos);
			$page_content = substr($page, $pos+1);
		}
	}

include("csv_data.inc");
$navigation_links = quick_read_csv("../content/data/navigation_links.txt", array('name', 'href'));
$navigation_count = count($navigation_links);
$quote_list = quick_read_csv("../content/data/quote_list.txt", array('body', 'author'));

$quote_count = count($quote_list);
?>

<div id="bodyContent">
	<h1><?php echo $page_title; ?></h1>
	<?php
	if( strlen($page_name) == 0 )
	{
		echo "<div class=\"Image\">image here</div>\n";
		echo "<div id=\"homeContent\">\n";
	} else {
		echo "<div id=\"pageContent\">\n";
	}
	?>

<?php echo $page_content; ?>
</div>
</div>

So that's the first problem. there's more, but i'd rather tackle these one at a time. Right now, the copy of the home page always appears, regardless of what page is being clicked on. But, it's always prints the pageContent div, and not the Image+homeContent combination.

If there's any more information that is required to troubleshoot this, please let me know.

any help will be appreciated. thanks!

bogu

This site worked before u make changings, or it didnt worked? (I meen on the server that u are working right now ...)

NudelZ

yes it did, but this IF statement:

<?php
    if( strlen($page_name) == 0 )
    {
        echo "<div class=\"Image\">image here</div>\n";
        echo "<div id=\"homeContent\">\n";
    } else {
        echo "<div id=\"pageContent\">\n";
    }
    ?> 

<?php echo $page_content; ?>

is new, the guy wrote it in, but I guess never tested it before disappearing.
before it was just:

<h2><?php echo $page_title; ?></h2>
    <?php echo $page_content; ?>

obviously no display divs, or a selective display based on whether the displayed page is the homepage.

thanks for replying...

bogu

Change this line:

<?php 
    if( strlen($page_name) == 0 ) //<-- this one
    { 
        echo "<div class=\"Image\">image here</div>\n"; 
        echo "<div id=\"homeContent\">\n"; 
    } else { 
        echo "<div id=\"pageContent\">\n"; 
    } 
?> 
<?php echo $page_content; ?>

with this:

if( strcasecmp($page_name, 'home') == 0 )

NudelZ

thanks bogu, but still no go.

the homepage is displaying correctly, but all other pages still get both Image and homeContent divs displayed instead of pageContent and the correct content isn't showing up (always the homepage's content.)

looking in another file here, i noticed the following code snippet at the top of the page, which is missing from this version, it's a redirect/'catch-all 404' if the page is not defined in TinyMCE.

	error_reporting(0);
	$page_name = $_REQUEST['p'];
	$page_title = "Your page was not found";
	$page_content = <<<EOF
	Sorry, the page you were looking for could not be found. You may attempt using the search box to find it, or going to the <a href="/home">home page</a> and finding it from there. Thank you for visiting www.abbysiegel.com!
	EOF;

i know that feature was functioning, but, if i add it back in, i get an unexpected $end in the last line of the file, which means there's a missing bracket or something somewhere in the page, right?

Should I assume the content isn't refreshing correctly because there is, somewhere an unescaped or incorrectly close php statement?

NudelZ

ok, problem solved. I readded that snippet above- and made sure the closing EOF didn't have that whitespace ahead of it, and now this template is working...

I'll see if i can tackle the next issue myself before posting here, so i'm keeping the thread unresolved for now.

thanks!

NudelZ

3 things down-- managed to work the navigation as i wanted, but now i'm down to what i think is the last PHP issue: in the calendar page there is a sub navigation which simply lists all the months. When clicking on a month, you get taken to its page (with the appropriate listings.)

Now, remember the navigation used above?

<ul>
<?php
    for($i=0; $i<$navigation_count; $i++)
    {
        echo "<li><a href=\"".$navigation_links[$i]['href']."\"";
        if(ereg($page_name."$", $navigation_links[$i]['href'])){echo "id=\"current\""; }
        echo ">".$navigation_links[$i]['name']."</a></li>\n";

}
?>
</ul>

this was successfully modified to:

				<ul>
				<?php
						for($i=0; $i<$navigation_count; $i++)
						{
							echo "<li";
							if($navigation_links[$i]['href']=="/contact")
							{
								echo " class=\"lastTab\"";
							}
							echo "><a href=\"".$navigation_links[$i]['href']."\"";
							if(ereg($page_name."$", $navigation_links[$i]['href']))
							{
								echo " id=\"current\""; 
							}
							echo ">".$navigation_links[$i]['name']."</a></li>\n";
						}
					?>
				</ul>

so i can add the appropriate CSS styling. The calendar has two of the above lists, the first is exactly the same (but highlights calendar as #current by default,) I need to be able to set #current to the secondary nav as well, and for now, nothing I'm doing works...

here's all the php on the page:

//top of document...
<?php
error_reporting(0);

include("csv_data.inc");
$navigation_links = quick_read_csv("../content/data/navigation_links.txt", array('name', 'href'));
$navigation_count = count($navigation_links);
$calendar = quick_read_csv("../content/data/calendar.txt", array('month', 'day', 'text'));
function calendar_cmp($a, $b) { return ($a['month']*60+$a['day']) - ($b['month']*60+$b['day']); }
usort($calendar, "calendar_cmp");
$t = localtime(); 
$month_names = 
	array('January', 
	'February', 
	'March', 
	'April', 
	'May', 
	'June', 
	'July', 
	'August', 
	'September', 
	'October', 
	'November', 
	'December');
$month = $t[4];
$day = $t[3];
$year = $t[5]+1900;
if( isset($month_names[$_REQUEST['month']-1]) )
{
	$month = $_REQUEST['month']-1;
}
if( $month < $t[4] ){$year++;}
$month_name = $month_names[$month];
function calendar_filter($a) 
{ 
	global $month;
	return $a['month'] == $month+1;
}
$calendar = array_filter($calendar, "calendar_filter");
?>


//this is the relevant portion: the navigation bars
			<div id="nav">
				<ul>
				<?php
						for( $i = 0; $i < $navigation_count; $i++ )
						{
							echo "<li";
							if($navigation_links[$i]['href']=="/contact")
							{
								echo " class=\"lastTab\"";
							}
							echo "><a href=\"".$navigation_links[$i]['href']."\"";
							if($navigation_links[$i]['href']=="/calendar")
							{
								echo " id=\"current\""; 
							}
							echo ">".$navigation_links[$i]['name']."</a></li>\n";
						}
					?>
				</ul>
			</div>
			<div id="secondaryNav">
				<ul>
				<?php
						for( $i = 1; $i < 13; $i++ )
						{
							echo "<li";
							if($i==12)
							{
								echo " class=\"lastTab\"";
							}
							echo "><a href=\"/calendar/".$i."\"";
							if(ereg($month_names."$", $i))  // <-- this is the line with which I have no clue what to do.
							{
								echo " id=\"current\""; 
							}
							echo ">".$month_names[$i-1]."</a></li>\n";
						}
				?>
				</ul>
			</div>

I highlighted above the problematic line- i think I've tried any combination of all variables over there, i just don't know how to use the ereg correctly I guess, but it's just not working. again, when clicking on any of the subnav items (the list of months) the user gets redirected to a calendar/X URL, where X is the list-place of the month they selected. (i.e. June being 6.) What doesn't happen is in the <li> for june, the <a> should become <a href="#" id="current">

any help appreciated. it's 3am already, can't think of anything.

bogu

Change that line with this:

if(ereg($month_name."$", $month_names[$i]))

NudelZ

cheers bogu! needed to make one minor adjstment to actually give the right month the id="current" but it's working!

if(ereg($month_name."$", $month_names[$i-1])) //changed to $i-1

now i need to figure out a way to remove the CSS from the body of the page and link it externally (some 500 lines isn't nice to have on every load) - i think this will be done via the .htaccess based on what I'm seeing, but for the meantime, I believe this thread is resolved.

Thank you very much!

bogu

Glad that I could help... 😃