Count $_GET array problem

[Tezread]

Hello all. I am trying to debug this code and having look at the manual I cannot se what is wrong. Here is my code

include("connect.php");
	  if(isset($_GET['submit']{
	//  if($_GET['submit']){ 
// Start the basic query 
$sql_admin = "SELECT * FROM qualityadmin , activity, activity_participant, expert, 
                  expert_participant, qualitysystem, quality_system_participant 
          WHERE activity_participant.activity_participant_relid = activity.activity_id AND activity_participant.qualityadmin_relid = qualityadmin.qualityadmin_id 
          AND expert_participant.expert_participant_relid = expert.expert_participant_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id 
          AND quality_system_participant.quality_system_relid = qualitysystem.qualitysystem_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id"

// Check the activity checkbox array for passed values, build a query line with them if there are any 

if(count($_GET['activity_checkbox']) > 0){ 
   $act_sql_append = "AND activity.activity_id IN ('" . implode("','", $_GET['activity_checkbox']) . "')"; 

  $sql_admin .= $act_sql_append; 
} 

// Check the expert checkbox array for passed values, build a query line with them if there are any 
if(count($_GET['expert_checkbox']) > 0){ 
    $ex_sql_append = "AND expert.expert_participant_id IN ('" . implode("','", $_GET['expert_checkbox']) . "')"; 

$sql_admin .= $ex_sql_append; 
} 

// Check the quality system checkbox array for passed values, build a query line with them if there are any 
if(count($_GET['qualsys_checkbox']) > 0){ 
    $qs_sql_append = "AND qualitysystem.qualitysystem_id IN ('" . implode("','", $_GET['qualsys_checkbox']) . "')"; 

$sql_admin .= $qs_sql_append; 
}          

my error message is:

parse error, unexpected T_IF in /disk1/home3/mindseye/public_html/notts_quality/info_resource/infolinks_choicesv2_formhandler.php on line 118

which refers to each of the if(count($_GET['arrayname']) > 0 {.....} parts

Hopefully the comments in the code explain my aims. Could anyone point out where im going wrong here?
Thanks in advance

[ahundiak]

Assuming this was a direct copy/paste then you are missing a semi-colon.
qualityadmin.qualityadmin_id"

Also going to need a space before catting on AND

By the way, if no check boxes are selected then the element will not be posted at all. Need to check if $_GET['name'] is even set before processing. I'd suggest making a little function to make debugging easier and to save some repeatitive code.

[Tezread]

ahundiak wrote:

Also going to need a space before catting on AND

thankyou ahundiak. Im not sure what you mean by this though?
Also I now have a unexpected ';' after placing a semicoln at the end of my query. this is strange as i was led to believe that ';' was always required.

[ahundiak]

$sql_admin = "SELECT FROM qualityadmin , activity, activity_participant, expert,
expert_participant, qualitysystem, quality_system_participant
WHERE activity_participant.activity_participant_relid = activity.activity_id AND activity_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND expert_participant.expert_participant_relid = expert.expert_participant_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND quality_system_participant.quality_system_relid = qualitysystem.qualitysystem_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id"
Should be
$sql_admin = "SELECT FROM qualityadmin , activity, activity_participant, expert,
expert_participant, qualitysystem, quality_system_participant
WHERE activity_participant.activity_participant_relid = activity.activity_id AND activity_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND expert_participant.expert_participant_relid = expert.expert_participant_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND quality_system_participant.quality_system_relid = qualitysystem.qualitysystem_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id" ;

You need a semi-colon for php, not for the query.

As far as mysql sql goes, the semi-colon at the end of a sql statement is optional. But don't mixup php semi-colon requirements and sql semi-colon requirements.

You also have
$act_sql_append = "AND activity.activity_id...
$sql_admin .= $act_sql_append;

This will result in $sql_admin looking like:
qualityadmin.qualityadmin_idAND activity.activity_id
Unless you add in a space before AND.

Once you get things working you might consider partially rewriting the query using JOINs. Functionality equivalent to using WHERE but easier to read and maintain.

[ClarkF1]

You also have expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id twice if my eyes don't deceive me

[Tezread]

Mmmmm- I see what you mean. Im still getting unexpected ';' though and i've done what you said...

$sql_admin = "SELECT * FROM qualityadmin , activity, activity_participant, expert,
expert_participant, qualitysystem, quality_system_participant
WHERE activity_participant.activity_participant_relid = activity.activity_id AND activity_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND expert_participant.expert_participant_relid = expert.expert_participant_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND quality_system_participant.quality_system_relid = qualitysystem.qualitysystem_id"; 

// Check the activity checkbox array for passed values, build a query line with them if there are any 

if(count($_GET['activity_checkbox']) > 0){ 
   $act_sql_append =  " AND activity.activity_id IN ('" . implode("','", $_GET['activity_checkbox']) . "')"; 

  $sql_admin .= $act_sql_append; 
} 

// Check the expert checkbox array for passed values, build a query line with them if there are any 
if(count($_GET['expert_checkbox']) > 0){ 
    $ex_sql_append =  " AND expert.expert_participant_id IN ('" . implode("','", $_GET['expert_checkbox']) . "')"; 

$sql_admin .= $ex_sql_append; 
} 

// Check the quality system checkbox array for passed values, build a query line with them if there are any 
if(count($_GET['qualsys_checkbox']) > 0){ 
    $qs_sql_append =  " AND qualitysystem.qualitysystem_id IN ('" . implode("','", $_GET['qualsys_checkbox']) . "')"; 

$sql_admin .= $qs_sql_append; 
}    

[Tezread]

Just an update- I noticed I changed something at the beginning of the code before- now ive swapped this:

if(isset($_GET['submit']{

to this

if($_GET['submit']){ 

the error message is now:

Error in search query: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'BY qualityadmin.quality_name' at line 5

trouble is there is nothing on line 5 only HTML output!!

[ClarkF1]

Can you post the section of the code which contains the BY part of the query

[Weedpacket]

if(isset($_GET['submit']{ 

should be

if(isset($_GET['submit'])){ 

[Tezread]

ClarkF1:

here is all my code:

<?php
	  include("connect.php");
	if(isset($_GET['submit'])){

// Start the basic query 
$sql_admin = "SELECT * FROM qualityadmin , activity, activity_participant, expert,
expert_participant, qualitysystem, quality_system_participant
WHERE activity_participant.activity_participant_relid = activity.activity_id AND activity_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND expert_participant.expert_participant_relid = expert.expert_participant_id AND expert_participant.qualityadmin_relid = qualityadmin.qualityadmin_id
AND quality_system_participant.quality_system_relid = qualitysystem.qualitysystem_id"; 

// Check the activity checkbox array for passed values, build a query line with them if there are any 

if(count($_GET['activity_checkbox']) > 0){ 
   $act_sql_append =  " AND activity.activity_id IN ('" . implode("','", $_GET['activity_checkbox']) . "')"; 

  $sql_admin .= $act_sql_append; 
} 

// Check the expert checkbox array for passed values, build a query line with them if there are any 
if(count($_GET['expert_checkbox']) > 0){ 
    $ex_sql_append =  " AND expert.expert_participant_id IN ('" . implode("','", $_GET['expert_checkbox']) . "')"; 

$sql_admin .= $ex_sql_append; 
} 

// Check the quality system checkbox array for passed values, build a query line with them if there are any 
if(count($_GET['qualsys_checkbox']) > 0){ 
    $qs_sql_append =  " AND qualitysystem.qualitysystem_id IN ('" . implode("','", $_GET['qualsys_checkbox']) . "')"; 

$sql_admin .= $qs_sql_append; 
}          

// Add ordering and grouping to the query, and append them to the query 
$sql_group = "GROUP BY qualityadmin.qualityadmin_id"; 
$sql_order = "ORDER BY qualityadmin.quality_name"; 

$sql_admin .= $sql_group . $sql_order; 

// Run the query, and fetch the results 
$sql_result = mysql_query($sql_admin) or die("Error in search query: ".mysql_error()); 
$sql_array = mysql_fetch_assoc($sql_result); 

// Print your results here 

echo $sql_array;
} 

?>

at the moment I have an undefined index error message for qualsys_checkbox and expert_checkbox as well as the BY... error message

[Tezread]

I have just noticed by adding a space after the " so:

// Add ordering and grouping to the query, and append them to the query
$sql_group = "GROUP BY qualityadmin.qualityadmin_id";
$sql_order = "ORDER BY qualityadmin.quality_name";

$sql_admin .= $sql_group . $sql_order;

becomes

// Add ordering and grouping to the query, and append them to the query
$sql_group = " GROUP BY qualityadmin.qualityadmin_id";
$sql_order = " ORDER BY qualityadmin.quality_name";

$sql_admin .= $sql_group . $sql_order;

this removes the error BUT I still have an undefined index error for qualsys_checkbox and expert_checkbox

[ahundiak]

I explained the undefined index issue in post #2.
if(count($GET['expert_checkbox']) > 0)
Should be something like:
if(isset($GET['expert_checkbox']) && (count($_GET['expert_checkbox']) > 0))

And you really don't even need the count() part. If any check boxes are selected then you will always get an array with at least one value.

[Tezread]

I was just thinking I don't need a count function and ive just checked my thread and you confirm that. What happens though if checkboxes are ticked say for activities but no results come up? That is what is happening now in spite of me populating the activity_participant table to ensure results should occur given my select query.

[Tezread]

I just wanted to clarify what I was trying to achieve here so im hopefullly 'singing on the same hymn sheet'.

I have a four tables - the main one being qualityadmin and three others being activity, qualitysystem, expert. My normalisation rule is that one qualityadmin can have one or more activities/qualitysystems/experts relating to it (one to many)
I then have a form with a checkboxes listing all the activities/experts/qualitysystems that are called by querying the activity/expert/qualsys tables
I then have another table called activity_participant which stores all activities for a given qualityadmin i.e

id = 1
qualityadmin_relid = 1
activity_participant_relid = 4

id = 2
qualityadmin_relid = 1
activity_participant_relid = 7

id = 3
qualityadmin_relid = 1
activity_participant_relid = 14

this would be interpreted as the qualityadmin with an id of '1' has three activities: '4','7' & '14'

This approach is also used for storing qualsys/experts.

Now I know this seems really convaluted but im still learning and when it comes to JOINS I freeze.

I hope this clarifies my aims though?

[ahundiak]

My guess is that your query still needs some work. You are trying to work through a bunch of unrelated problems and it's not easy. Take things in tiny steps.

By the way, echo $sql_array will at most generate the work ARRAY. Need to use print_r($sql_array); to see the contents.

[Tezread]

just wanted to update. im getting some results now however only the very first activity in the is showing and no others in spute of me picking lots in the form so lots shouod be listed- here is my code

	  include("connect.php");
	if(isset($_GET['submit'])){ 

// Start the basic query 

$sql_admin = "SELECT qualityadmin.quality_name, activity.activity_id, activity_org.activity_id 
FROM qualityadmin, activity, activity_org 
WHERE activity.activity_id = activity_org.activity_id"; 


// Check the activity checkbox array for passed values, build a query line with them if there are any 

if(isset($_GET['activity_checkbox']) && (count($_GET['activity_checkbox']) > 0)) {
   $act_sql_append =  " AND activity.activity_id IN ('" . implode("','", $_GET['activity_checkbox']) . "')"; 

  $sql_admin .= $act_sql_append; 
} 

// Check the expert checkbox array for passed values, build a query line with them if there are any 
if(isset($_GET['expert_checkbox']) && (count($_GET['expert_checkbox']) > 0)){
    $ex_sql_append =  " AND expert.expert_participant_id IN ('" . implode("','", $_GET['expert_checkbox']) . "')"; 

$sql_admin .= $ex_sql_append; 
} 

// Check the quality system checkbox array for passed values, build a query line with them if there are any 
if(isset($_GET['qualsys_checkbox']) && (count($_GET['qualsys_checkbox']) > 0)){
    $qs_sql_append =  " AND qualitysystem.qualitysystem_id IN ('" . implode("','", $_GET['qualsys_checkbox']) . "')"; 

$sql_admin .= $qs_sql_append; 
}           

// Add ordering and grouping to the query, and append them to the query 
$sql_group = " GROUP BY qualityadmin.qualityadmin_id"; 
$sql_order = " ORDER BY qualityadmin.quality_name"; 

$sql_admin .= $sql_group . $sql_order; 

// Run the query, and fetch the results 
$sql_result = mysql_query($sql_admin) or die("Error in search query: ".mysql_error()); 
$sql_array = mysql_fetch_assoc($sql_result); 

// Print your results here 

print_r($sql_array); 
} 

[ahundiak]

$sql_array = mysql_fetch_assoc($sql_result);
Is only going tofetch the first row. You need something like:

while($sql_array = mysql_fetch_assoc($sql_result)) {
    print_r($sql_asrray);
}

To process each row.

[Tezread]

hi ahundiak- good to hear from you again. i followed up what you said but now ALL the systems are being listed not the ones associated with my choices in tyhe form. this is so weird

	  include("connect.php");
	if(isset($_GET['submit'])){ 

// Start the basic query 

$sql_admin = "SELECT qualityadmin.quality_name, activity.activity_id, activity_org.activity_id 
FROM qualityadmin, activity, activity_org 
WHERE activity.activity_id = activity_org.activity_id"; 


// Check the activity checkbox array for passed values, build a query line with them if there are any 

if(isset($_GET['activity_checkbox']) && (count($_GET['activity_checkbox']) > 0)) {
   $act_sql_append =  " AND activity.activity_id IN ('" . implode("','", $_GET['activity_checkbox']) . "')"; 

  $sql_admin .= $act_sql_append; 
} 

// Check the expert checkbox array for passed values, build a query line with them if there are any 
if(isset($_GET['expert_checkbox']) && (count($_GET['expert_checkbox']) > 0)){
    $ex_sql_append =  " AND expert.expert_participant_id IN ('" . implode("','", $_GET['expert_checkbox']) . "')"; 

$sql_admin .= $ex_sql_append; 
} 

// Check the quality system checkbox array for passed values, build a query line with them if there are any 
if(isset($_GET['qualsys_checkbox']) && (count($_GET['qualsys_checkbox']) > 0)){
    $qs_sql_append =  " AND qualitysystem.qualitysystem_id IN ('" . implode("','", $_GET['qualsys_checkbox']) . "')"; 

$sql_admin .= $qs_sql_append; 
}           

// Add ordering and grouping to the query, and append them to the query 
$sql_group = " GROUP BY qualityadmin.qualityadmin_id"; 
$sql_order = " ORDER BY qualityadmin.quality_name"; 

$sql_admin .= $sql_group . $sql_order; 

// Run the query, and fetch the results 
$sql_result = mysql_query($sql_admin) or die("Error in search query: ".mysql_error()); 
while($sql_array = mysql_fetch_assoc($sql_result)) { 
    print_r($sql_array); 
}
}

check this out - choose 'sports & outdoor activities' in the activities secrtion and click submit. only 1/2 systems should be listed but all appear

http://www.mindseyemidlands.co.uk/notts_quality/info_resource/infolinks_choicesv2.php

[ahundiak]

Echo out $sql_admin and paste it in here verbatim.

[Tezread]

i have just spotted a possible flaw in my database design- im going to look into it and i will let you know the outcome. for now I will try and solve this by myself without depending on you 🙂