[RESOLVED] Broken IF Statement

[eternally1027]

I am writing a PHP script that interfaces with a MySQL Database to manage the status of computers for a local job I have. I have a page called edit.php which has a form of information. I have a radio button which allows the user to toggle whether or not the computer has been completed.

If the user selects that the computer is NOT done, the data is supposed to be updated ONLY ($editdata). There is supposed to be no creation of a new line in a different table or deletion of the old line. The option which states that the computer is done ($fin and $fini) creates the entry in guests_old and deletes the entry in the main table (for archiving purposes).

The problem I am having is that no matter which way I try (IF Statement, Switch, This way) BOTH queries run on my database...which is bad as this would delete the data for many customers.

In exasperation I ask, Can someone help me out a little bit?

Here is the relevant part of my HTML Form:

Computer is Finished:<br>
Yes<input type="radio" value="yes" name="finished">
No<input type="radio" value="no" name="finished">
<INPUT TYPE=SUBMIT NAME="action" VALUE="Submit">

Here is the PHP Script:

<?
	$conedit = mysql_pconnect("localhost","ethanwe_ethan","password")
                   or die("Unable to connect to SQL server");
    mysql_select_db("ethanwe_timpc", $conedit) or die("Unable to select database");
	$editdata = mysql_query("UPDATE guests SET customername='$_POST[name]', customerphone='$_POST[phone]', datecheckin='$_POST[date]', computerlocation='$_POST[location]' WHERE ticketnumber = '$_POST[ticket]'") or die("Hey");
	$fini = mysql_query("DELETE FROM guests WHERE ticketnumber = '$_POST[ticket]'");
	$fin = mysql_query("INSERT INTO guests_old(ticketnumber, customername, customerphone, datecheckin, computerlocation) VALUES('$_POST[ticket]','$_POST[name]', '$_POST[phone]', '$_POST[checkin]', '$_POST[location]')");

$finished=$_POST[finished];
if($finished != no){
	mysql_query($fin);
	mysql_query($fini);
}
	elseif($finished = no){
	mysql_query($editdata);
}
	?>

[gaucho]

Hello,

look at this part of your code

elseif($finished = no){
mysql_query($editdata);

}

$finished = no sets finished to no, means it doesn't compare.
Should be
$finished == no

I forgot one thing.
The way you check it, it checks first wether finished is not no, could also be nothing. Means, if for any reason your script is passing an empty finished first action will happen.

Better check it like this:

if($finished == "yes"){
do this
}elseif($finished == "no"){
do that
}else{
throw an error because $finished should be either yes or no, nothing else
}
Hope this helps

regards

gaucho

[eternally1027]

Thanks, gaucho. However, that doesn't resolve it.

All 3 queries are still being executed no matter what is chosen... I can put prints or echos under the IFs and have only the correct one run, but it runs both queries... This stumps me.

[gaucho]

You were faster than I thought, therefore my last comment again:

The way you check it, it checks first wether finished is not no, could also be nothing. Means, if for any reason your script is passing an empty finished first action will happen.

Better check it like this:

if($finished == "yes"){
do this
}elseif($finished == "no"){
do that
}else{
throw an error because $finished should be either yes or no, nothing else
}

Addition:

I see that your queries are always executed. $fin, $fini, etc are only the variables that take the result. you must rewrite this piece of code:

<?
   $conedit = mysql_pconnect("localhost","ethanwe_ethan","password")  or die("Unable to connect to SQL server");
    mysql_select_db("ethanwe_timpc", $conedit) or die("Unable to select database");
	$editdata = "UPDATE guests SET customername='$_POST[name]', customerphone='$_POST[phone]', datecheckin='$_POST[date]', computerlocation='$_POST[location]' WHERE ticketnumber = '$_POST[ticket]'" 
	$fini = "DELETE FROM guests WHERE ticketnumber = '$_POST[ticket]'";
	$fin = "INSERT INTO guests_old(ticketnumber, customername, customerphone, datecheckin, computerlocation) VALUES('$_POST[ticket]','$_POST[name]', '$_POST[phone]', '$_POST[checkin]', '$_POST[location]')";

$finished=$_POST[finished];
if($finished == "yes"){
	mysql_query($fin);
	mysql_query($fini);
}
	elseif($finished == "no"){
	mysql_query($editdata);
}else{
  //code to throw error

}
	?>

You have to remove the mysql_query int the definitions because $fin, $fini and $editdata should only be variables containing the statement and not the executed statements themselves.

regards

gaucho

[eternally1027]

Yes! Gaucho, That was the issue and it makes SO MUCH sense now. It was running the queries as it went through the script and since they were actual queries and not just variables. Ohh, man. I'm glad that's done. Thanks so much.

Cheers!

[gaucho]

You're welcome

regards

gaucho