[RESOLVED] page.php?id=1 or whatever id not working

[1042]

Hello All,

im creating this sort of news script and im having an issue, the code to display the date, title and the read more link is below the name of this page events.php

$getpress = mysql_query("SELECT * FROM press ORDER BY pressid DESC");//query the database for all of the news

while($r=mysql_fetch_array($getpress)){//while there are rows in the table
extract($r);//remove the $r so its just $variable

echo("
<font class=\"bluetext\">$date</font> - <font class=\"blueboldpress\"><strong>$title</strong></font><br>
<a href=\"press.php?id=$pressid\">[Read More]</font></a><br><br>");

}

and the code to display the complete news article is below the name of this page is press.php

$detailpress = mysql_query("SELECT * FROM press WHERE id= '$pressid'");//query the database for detail news article
while($r=mysql_fetch_array($detailpress)){//while there are rows in the table
extract($r);//remove the $r so its just $variable

echo("
<font class=\"bluetext\">$date</font> - <font class=\"blueboldpress\"><strong>$title</strong></font>
<font class=\"bluetext\">$content</font><br>");
}

the problem is that i get an error "Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program Files\xampp\htdocs\interactive\press.php on line 173"

line 173 would be were the "while" statement starts on the press.php file, any ideas what im doing wrong, any help is appreciated, thank you in advance.

[rincewind456]

Where is $pressid in the first snippet coming from?

If your trying to access the full article from the first code snippet with this line

<a href=\"press.php?id=$pressid\">[Read More]</font></a><br><br>");

.

Then the variable you should be accessing in the second snippet is

$_GET['id']

not

$pressid

[void_function]

line 173 would be were the "while" statement starts on the press.php file, any ideas what im doing wrong, any help is appreciated, thank you in advance.

It means that mysql_query did not execute and did not return valid result resource for mysql_fetch_array().

A possible reason for query failure is syntax error, or unexisting table or field names supplied in the QUERY. Or unestablished mysql connection prior to any queries.

You can test each query by checking mysql_errno() right after mysql_query(), which returns a nonzero number if there was an error. You can fetch error description by mysql_error(mysql_errno()). Since PHP does not include mysql errors in its normal error reporting, you'll need to write your own routines for sql error management.

[Gonwee]

Like void said its a problem with your query. echo or print the sql query and check for errors.

Just a suggestion, might not help any. But change the query to look like this.

SELECT * FROM press WHERE id= '$pressid'

I have troubles sometime without the `

Edit: I don't think its a good idea to assume a returned string. Use an if to see if a row is returned. It might not return a result because nothing was found matching the where critque, this i believe cause an error with mysql_fetch_array

[1042]

Hi thanks for the help, i change the query to get an error and i was getting this

Unknown column 'id' in 'where clause'

so i change the code to this

Code:

$detailpress = mysql_query("SELECT * FROM press WHERE pressid= '$pressid'") or die(mysql_error())

instead of this

Code:

$detailpress = mysql_query("SELECT * FROM press WHERE id= '$pressid'") or die(mysql_error());

if i do this i can see the first record on the database but if i do press.php?id=2 i still see tha same record, it wont change to that particular record

if i do this:

Code:

$detailpress = mysql_query("SELECT * FROM press WHERE id= $_GET['pressid']") or die(mysql_error());

i get this error:

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in C:\Program Files\xampp\htdocs\headinteractive\press.php on line 171

any ideas? thanks in advance.

[Gonwee]

You need to move the single qoutes out of the brackets on the $GET variable,

'$_GET[pressid]'

[ClarkF1]

 $detailpress = mysql_query("SELECT * FROM press WHERE id='".$_GET['pressid']."'") or die(mysql_error()); 

should work although I find it preferable to store the query as a variable and then query the variable. Then you can just echo the variable to see what exactly is being queried.

$query = "SELECT * FROM press WHERE id='".$_GET['pressid']."'"; 
$detailpress = mysql_query($query) or die(mysql_error()); 

[void_function]

You need to move the single qoutes out of the brackets on the $_GET variable,

Not move out, but add. One still needs the quotes in brackets to reference the key.

BTW, DO NOT put $_GET variable directly into SQL, especially if it's a string variable. Someone can inject SQL with no effort.

Always cast integers, $var=(int) $GET['integer_variable'] and clean strings, $var= mysql_real_escape_string($GET['string_variable']). This is just basic precaution that can save your entire database.

[1042]

Thanks to everybody for the help, this is a great community specially for newbies like me 🙂 , i was able to solve the issue following the advice given in this post, here is how my query looks now:

$detailpress = mysql_query("SELECT * FROM press WHERE pressid= {$_GET['pressid']}") or die(mysql_error());

once again, you help was greatly appreciated, thanks all.