Unable to pass value to another page.

SFDonovan

I have a couple pages I am working with.

One page named CombatAssets passes team_id to the page Movement.

But Movement does not pass the value onto the next page named Move.

CombatAssets does this.

<a href=\"modules.php?name=Campaign&amp;file=Movement&amp;team_id=$team_id\">" . _CLICK . "</a>

...with this at the bottom of the page.

. "<input type=\"hidden\" name=\"team_id\" value=\"$team_id\">"

The Movement page gets the value and I can display infomation based on the team_id which is what I want.

$id = intval($_GET['team_id']);
$sql = "SELECT * FROM " . $prefix . "_tc_ladderteams tclt WHERE team_id ='$id'";

I then have a dropdown onchange to pass the value onto the next couple of pages, and this is where I can't get the value passed correctly.

<select name="move" onchange="if(this.options[this.selectedIndex].value != 0){ document.location=this.options[this.selectedIndex].value; }">
<option value="0">--Choose option--</option>
<option value="modules.php?name=Campaign&amp;file=Move&amp;team_id=$id">Move</option>
<option value="modules.php?name=Campaign&amp;file=Attack&amp;team_id=$id">Attack</option>
<option value="modules.php?name=Campaign&amp;file=MoveAttack&amp;team_id=$id">Move and Attack</option>
</select>

At the bottom of Movement.php I have

echo"<input type=\"hidden\" name=\"id\" value=\"$id\">";

Then finally on my Move.php page I can't get the value and then display the unitname of the id I am trying to pass.

$id = intval($_GET['id']);
$sql = "SELECT * FROM " . $prefix . "_tc_ladderteams tclt WHERE team_id ='$id'";
$result = $db->sql_query($sql);
$info = $db->sql_fetchrow($result);
	if (!$result) {
		echo("<p>Error performing query: " . mysql_error() . "</p>");
		exit();
	} else {
		$unitname = $info['name'];
	}

Any help is appreciated.

Piranha

First I don't know how it works with using & instead of &. You might want to try using & if it is not working.

Second I assume that you use the form and javascript in some clever way to pass on the html to the form. And I don't know if you use the form method GET or POST, it might be that you should use $_POST['id'] instead.

Weedpacket

Piranha wrote:
First I don't know how it works with using & instead of &. You might want to try using & if it is not working.

No, that's standard HTML; according to the spec, the only time an & can float around without needing to be turned into an entity is inside a CDATA section.

I'd probably agree about whether it's $GET or $POST (not seeing the <form> tag and all), but it's hard to see why the $id is being passed in a hidden variable anyway, seeing as it's already in the URL.

Then again, if you're doing this simply to pass the value from one page to another then this is a very hazardous way of doing it: you've got no control over it once it leaves your computer, and there's no guarantee that it will be unchanged when (and if) you get it back. Consider storing such information in session variables instead.

SFDonovan

My Movement page has:

<form action="<?php echo $_SERVER['PHP_SELF'] ?>" method="POST">

This is the code in the beginning of the page to get the team_id and display the unitname and I know it is working because the name is displayed.

$id = intval($_GET['team_id']);
$sql = "SELECT * FROM " . $prefix . "_tc_ladderteams tclt WHERE team_id ='$id'";
$result = $db->sql_query($sql);
$info = $db->sql_fetchrow($result);
	if (!$result) {
		echo("<p>Error performing query: " . mysql_error() . "</p>");
		exit();
	} else {
		$unitname = $info['name'];
	}

Then below this I display the name.

<center><H2><strong>Campaign Movement Orders for  </strong></H2></center><br>
<center><H2><strong><?php echo $unitname ?></strong></H2></center><br>

Its just passing this to the next page is where I have trouble.

If I know the valiable is stored in $id and I use that here I don't know why it is not passed.

<form action="<?php echo $_SERVER['PHP_SELF'] ?>" method="POST">
<center><b>Commanders Menu<br>
<select name="move" onchange="if(this.options[this.selectedIndex].value != 0){ document.location=this.options[this.selectedIndex].value; }">
<option value="0">--Choose option--</option>
<option value="modules.php?name=Campaign&amp;file=Move&amp;team_id=$id">Move</option>
<option value="modules.php?name=Campaign&amp;file=Attack&amp;team_id=$id">Attack</option>
<option value="modules.php?name=Campaign&amp;file=MoveAttack&amp;team_id=$id">Move and Attack</option>
</select>
</form>

It doesn't show in the url.

Piranha

You try to fetch the id this way:
$id = intval($GET['id']);
But you use method="POST" in your form. Then you need to fetch it as a post as well, not as a get. Method GET is to show it in the URL, POST is to avoid that.
$id = intval($POST['id']);

That is of course if you want to pass it this way. Weedpacket defenetley know this much better that I do, and you should take his advice and use session variables.