[RESOLVED] php.ini file

[jl9148]

hey. i have a memberscript that i am having trouble with.

my users want to upload their own avatar, but it is not letting them. the file in which the avatars are sent to are chmodded correctly.

i think it may have to do something with the php.ini file, but i cannot find it anywhere in my root folder. i have godaddy hosting and i contacted them but they didnt help me at all.

please help me guys! thanks

[ade234uk]

I dont think they will give you access to the php.ini file unless I am mistaken.

[ClarkF1]

Can we see your upload form?

Sometimes it's a simple mistake like leaving out the enctype attribute from the form tag

[bradgrafelman]

jl9148 wrote:

but it is not letting them

Really? What does it do? Do you have display_errors set to On and error_reporting set to E_ALL? If so, do you get any error messages?

As ClarkF1 mentioned above, showing us a code snippet relevant to the file upload part of your script would help immensely.

[jl9148]

this is the php code of the avatar upload

if ( isset ( $_POST[edit_avatar] ) ) {
$filesize_limit = 153600; //150 KB
$avatar_custom = mysql_real_escape_string ( $_POST[avatar_custom] );
$avatar_upload = mysql_real_escape_string ( $_FILES[avatar_upload][tmp_name] );

if ( $_POST[avatar_choice] == "n" || ( empty ( $avatar_custom ) && empty ( $avatar_upload ) ) ) {
$update = mysql_query ( "UPDATE users SET avatar='' WHERE user_id='$user_info[user_id]'" );
EditSuccess ( "Avatar" );
$edit_success = 1;
} elseif ( $_POST[avatar_choice] == "y" ) {
if ( !empty ( $avatar_custom ) && !empty ( $avatar_upload ) ) {
$avatar_type = "upload";
} elseif ( empty ( $avatar_custom ) && !empty ( $avatar_upload ) ) {
$avatar_type = "upload";
} elseif ( !empty ( $avatar_custom ) && empty ( $avatar_upload ) ) {
$avatar_type = "custom";
}

if ( $avatar_type == "custom" ) {
$avatarc_filesize = FilesizeRemote ( "$avatar_custom", "2" );
if ( empty ( $avatar_custom ) ) {
$errors[] = "You must enter a URL to an avatar";
}
if ( $fp = @fopen ( $avatar_custom, 'r' ) ) {
list( $avatarc_width, $avatarc_height, $avatarc_type ) = getimagesize( $avatar_custom );
if ( $avatarc_type != 1 ) {
$errors[] = "Avatar must be a GIF file";
}
} else {
$errors[] = "The specified avatar does not exist";
}
if ( $avatarc_filesize > $filesize_limit ) {
$errors[] = "Avatar must be less than 200 KB.";
}
if ( count ( $errors ) > 0 ) {
DisplayErrors();
$edit_success = 0;
} else {
$update = mysql_query( "UPDATE users SET avatar='$avatar_custom' WHERE user_id='$user_info[user_id]'" );
EditSuccess ( "Avatar" );
$edit_success = 1;
}
} elseif ( $avatar_type == "upload" ) {
if ( $_FILES['avatar_upload']['type'] != "image/gif" ) { 
$errors[] = "Avatar must be a GIF or a JPG file.";
} 
} elseif ( $avatar_type == "upload" ) {
if ( $_FILES['avatar_upload']['type'] != "image/jpg" ) { 
$errors[] = "Avatar must be a GIF or a JPG file.";
} 

if ( $_FILES['avatar_upload']['size'] > $filesize_limit ) {
$errors[] = "Avatar must be less than 50 KB.";
}
if ( count ( $errors ) > 0 ) {
DisplayErrors();
$edit_success = 0;
} else {
copy ( $_FILES['avatar_upload']['tmp_name'], "$script_folder/images/avatars/$user_info[user_id].gif" ) or die ( "Couldn't Copy File" );
$avatar_url = "$site_url/$script_folder/images/avatars/$user_info[user_id].gif";
$update = mysql_query( "UPDATE users SET avatar='$avatar_url' WHERE user_id='$user_info[user_id]'" );
EditSuccess ( "Avatar" );
$edit_success = 1;
}
}

and this is the HTML code i use to display the thing for users to upload their avatar

<fieldset>
<legend class="main">Current Avatar</legend>
<table cellpadding="0" cellspacing="0" class="main"><tr>
<td style="text-align: justify">
Please se the form below to choose your avatar. You can either upload your own or post your desired avatar's URL.
</td>
</tr>
<tr><td height="10"></td></tr>
<tr><td>
<table cellpadding="0" cellspacing="0" class="main"><tr>
<td>
<?php
if ( empty ( $user_info[avatar] ) ) {
$avatar_no = "checked";
echo "<img src='$site_url/$script_folder/images/avatars/none.gif' width='60' height='60'>";
} else {
list ( $avatar_width, $avatar_height ) = getimagesize ( "$user_info[avatar]" );
$avatar_yes = "checked";
if ( $avatar_width > 60 || $avatar_height > 60 ) {
echo "<img src='$user_info[avatar]' width='60' height='60'>";
} else {
echo "<img src='$user_info[avatar]'>";
}
}
?>
</td>
<td width="5"></td>
<td>
<input type="radio" name="avatar_choice" value="n" <?php echo $avatar_no ?>>Do not use an avatar<br>
<input type="radio" name="avatar_choice" value="y" <?php echo $avatar_yes ?>>Use an avatar
</td>
</tr></table>
</td></tr>
</table>
</fieldset>

[jl9148]

bradgrafelman wrote:

Really? What does it do? Do you have display_errors set to On and error_reporting set to E_ALL? If so, do you get any error messages?

As ClarkF1 mentioned above, showing us a code snippet relevant to the file upload part of your script would help immensely.

it dosent display any errors, all it does it refresh the page and nothing was changed. i can however post the avatar's URL, it just dosent let me upload my own avatar

[cahva]

That is a really messy upload code andd you shoudl rethink its structure.

This alone will fail every time

...
} elseif ( $avatar_type == "upload" ) {
	if ( $_FILES['avatar_upload']['type'] != "image/gif" ) {
		$errors[] = "Avatar must be a GIF or a JPG file.";
	}
} elseif ( $avatar_type == "upload" ) {
	if ( $_FILES['avatar_upload']['type'] != "image/jpg" ) {
		$errors[] = "Avatar must be a GIF or a JPG file.";
	}
...

Ok.. What happens when you try to upload? That will always give you an error because first you check if its a gif file and if its not, it gives you an error. Then you check if its a jpg file and if its not, error. So either way you are screwed.

Try somehing like:

if ( $_FILES['avatar_upload']['type'] != "image/gif" || $_FILES['avatar_upload']['type'] != "image/jpg") {
	$errors[] = "Avatar must be a GIF or a JPG file.";
}

There are other that kind of bugs in there so check your if clauses carefully. Also use move_uploaded_file() instead of copy()

[jl9148]

ok i solved the problem. i just removed the bottom code completely

...
} elseif ( $avatar_type == "upload" ) {
    if ( $_FILES['avatar_upload']['type'] != "image/gif" ) {
        $errors[] = "Avatar must be a GIF or a JPG file.";
    }
} elseif ( $avatar_type == "upload" ) {
    if ( $_FILES['avatar_upload']['type'] != "image/jpg" ) {
        $errors[] = "Avatar must be a GIF or a JPG file.";
    }
...