explode '|' fails

devels

I have a text file containing something like this:

1|text1|
2|text2|
3|text3|
4|text4|
5|text5|

A php script is reading that text file like so:

$lines = file('file.txt');

for ($i = 0; $i < count($lines); $i++)
{
	$words = explode('|', $lines[$i]);
}

The problem is, it is not exploding it.
I think it is caused by: '|'. Because when I reformat the text file using microsoft excel to a csv file and then explode using: ';' then it is working fine.

But I do not want to manually format the file first using excel, how can I get it working so it explodes the '|'?

Thanks in advance

laserlight

$lines = file('file.txt');

$words = array();
for ($i = 0; $i < count($lines); $i++)
{
    $words[] = explode('|', rtrim($lines[$i]));
}

NogDog

As laserlight's code suggests, in your original code you are overwriting the value of the $words array on each iteration of the loop, so at best you'd only have the results of the last line that was read once the loop completed. Chances are that the text file has a newline at the end of the last content line, so on the last iteration throught the loop it is reading an empty line and setting $words to a single-element array with that element having an empty string as the value.

Laserlight's code will give you a 2-dimensional array of the file data, with the first index being the line number - 1, and the second index being the exploded elements of each line. If that is not what you're looking for, then we'll need more specifics on what the desired output should be.

laserlight

By the way: rtrim() was used in view that there would be a newline sequence at the end of each element in the array returned by file(). However, because of your data format, after the explode() there would be an empty element at the end of each inner array. You can use the second parameter of rtrim() to specify characters to strip, if necessary.