anybody can help me to check this code?

[weiwei]

This is the search engine code that i try to run. But i dont understand why it run a notice that undefine index search. Can anybody help me to solve this problem?
Search:
<form method="post" action=" ">
<input type="text" name="search">
<input type="Submit" name="Submit" value="Submit">
</form>
<?php
mysql_connect("localhost","root"," ");
mysql_select_db("inventory");
$search = $_POST["search"];
$result = mysql_query("SELECT * FROM news WHERE message LIKE '%" . $search . "%'");
if($search == ""){
echo "Please enter a search";
exit;
}

if(mysql_num_rows($result) > 0) {
while($r=mysql_fetch_array($result)) {

   $NamaPeralatan = $r["NamaPeralatan"]; 

   print "$NamaPeralatan"; 
} 

} else {
print "No results returned";
}

?>

[cahva]

Ofcourse it says about the notice:

$search = $_POST["search"];

$_POST["search"] is not defined when you first go to page.

Thats not the only problem althought your code will probably work.

You now open database connection and make a query even if the form is not submitted yet. Heres a fixed version what it should look like:

<form method="post" action=" ">
<input type="text" name="search">
<input type="Submit" name="Submit" value="Submit">
</form>
<?php
if (isset($_POST['search'])) {
	// Database connection
	mysql_connect("localhost","root"," ");
	mysql_select_db("inventory");

// Make the search safe(r)
$search = mysql_real_escape_string($_POST["search"]);

$result = mysql_query("SELECT * FROM news WHERE message LIKE '%" . $search . "%'");
if (mysql_num_rows($result)>0) {
	while($r=mysql_fetch_array($result)) {
		echo $r['NamaPeralatan'];
	}
} else {
	echo 'No results returned';
}
} else {
	echo "Please enter a search";
}
?>

So always check the input that it really is there. Also in SQL try to avoid using * in the selects. Just fetch the fields that you need. In your case "SELECT NamaPeralatan FROM..." would be enough.

[weiwei]

Finally i understand what mistake i do. Thank you very much.

[weiwei]

ok, i mean here is i had one form, then i want to insert the data into the form. But i dont know how to combine the 2 query below using select function, can u help me?

$query = "INSERT INTO listofitem (NamaPeralatan,Jenama,Motor,Operasi) VALUES ('$NamaPeralatan','$Jenama','$Motor','$Operasi')";
$query2 ="INSERT INTO iteminformation(NoEnjin,NoPendaftaran,NoRujukan,TahunDibekalkan,JenisPerolehan,Kuantiti,HargaPerUnit,KadHartaModel,Status,LokasiPenempatan)VALUES('$NoEnjin','$NoPendaftaran','$NoRujukan','$TahunDibekalkan','$JenisPerolehan','$Kuantiti','$HargaPerUnit','$KadHartaModel','$Status','$LokasiPenempatan')";

[cahva]

Do you mean that you have 2 tables that are related to each other? Then read mysql manual about joins.

BTW, if you paste code, use [ PHP ] or [ CODE ] tags for them. You see from my previous posting that its helluva much nicer to read.