[RESOLVED] I get an error when my default action is performed during strict_errors

[schwim]

Hi there everyone,

I'm trying to clean up my code, and I've done really well so far in being able to get rid of all the errors, but there's one that I don't know how to get rid of:

In my admin section, I created actions(with the help of this forum), so if I wanted to edit, the url looked like "index.php?action=edit" and so forth. If there was no action attached to the url, it does the default action.

the problem is, when no action attached to the URL, I get an error that "action is not defined".

Is there a way to prohibit this from happening, or is this concidered an acceptable error?

This is the way I'm using the actions:

		switch ($_GET['action']) {

	    case "waiting" :


Lots of stuff



	        break;



	    case "approved" :

 Lots of stuff

	        break;

	    default :

}

and this is the error I get when I don't define an action via the URL:

Notice: Undefined index: action in /path/to/automonial/admin/index.php on line 91

Any help would be greatly appreciated.

thanks,
json

[proxydude]

switch ($_GET['action']) {

        case "waiting" :


Lots of stuff



            break;



        case "approved" :

 Lots of stuff

            break;

        default :

are you purposfully missing 'break;' here and im unaware of a new coding rule?
}

if that dont work try putting

if(!$_GET['action']){
$action = "main";
}

switch($action){
// notice no default rule but ive made my own
case "":

break

case "":

break;

case "main":

break;

}

[schwim]

Hi there proxydude,

Thanks very much for your response. Unfortunately, your suggestion didn't work very well for me at all.

Since register globals is off, I can't seem to find a way to do this without either main overwriting a valid action, or vice versa. If I define action as main, then convert $_GET['action'] to action, action is no longer defined as "main". When I reverse the order of conversion, I end up with action being defined as main, regardless of what the original value was.

thanks,
json

[schwim]

Well, I thought this would work, but it's not.

I tried an if/else:

		if(!$_GET['action']){
				$action = "default";
			}else{
				$action=$_GET['action'];
			}

	switch ($action) {

and I receive the same error:

Notice: Undefined index: action in /home/roughing/public_html/automonial/admin/index.php on line 91

Line 91:

if(!$_GET['action']){

I also tried:

if($_GET['action']=null){

but that seems to give me the default action, no matter what is passed via the URL.

Any ideas?

thanks,
json

[bike5]

if(isset($_GET['action']))
   $action = $_GET['action'];
else
   $action = 'default';

or--same thing but diff way

$action = isset($_GET['action']) ? $_GET['action'] : 'default';

[schwim]

THANK YOU!

I used your first example(only because I don't understand the format of the second iteration), and it seems to work perfect.

Quick question, if you don't mind:

Why don't I need to use curly brackets with that code? I thought I always had to use them for if/else statements. if they only consist of one line, are they not needed?

thanks,
json

[bike5]

Yes if it is only one "statement" you don't need them. You can 't do two seperate commands on the same line.

// this won't work
if($x == $i)
   echo 'a'; $x = 2;
else
   echo 'b';
// this will
if($x == $i)
{
   echo 'a'; $x = 2;
}
else
   echo 'b';

[schwim]

I understand(I think) 🙂

I can use brackets if I'd like, whether I'm using more than one command or not, but I can only go sans brackets when only one command is being processed in each instance, right?

I add them, only because at my skill level, it's not a good thing to have things look different 🙂

thanks,
json

[bike5]

Sounds like you got it.. Ya keeping things consistant does help out too.