Another rename help

[kclark]

I am trying to rename uploaded files, but I can't get the code in Red to work. Everything else works until I put that code in.

//Creates ID folder in the upload directory
          $foldername = "". $_REQUEST['ID'] ."";

      if(!is_dir("photos/$foldername"))
      {mkdir ("photos/$foldername", 0777); 
      chmod ("photos/$foldername", 0777);}
      else {}  

      $resourcefolder = "photos/"; 
      $filestocopy = array();

      $filestocopy[0] = "slideshow.php"; 
      //$filestocopy[1] = "template.html"; 

      $frompath = "photos/"; 
      $topath = "photos/".$foldername."/"; 

      foreach ($filestocopy as $value) 
      { 
      copy ($frompath.$value,$topath.$value); 
      } 

      //Copies file to specified location
      if (copy($userfile, "photos/$foldername/$userfile_name")) {
        $userfile_location = "photos/$foldername";

        //Deletes file in TMP directory
        unlink($userfile);

       [COLOR=Red]$my_filename = create_filenames();
       rename("photos/$foldername/$userfile_name", "photos/$foldername/$my_filename");[/COLOR]

        //Add File info to database
        add_file($yourname, $email_address, $caption, $userfile_location, $my_filename, $_REQUEST['ID']);
      } else {
        require("header.php");
        echo "Your file could not be copied.\n";
        require("footer.php");
      }

[joe2]

you can copy image with new name.

copy($userfile, "photos/$foldername/$userfile_name")

No need to rename seperatly.

[kclark]

What do I change in my code to do that?

[joe2]

"photos/$foldername/$userfile_name" should be "photos/$foldername/$new_file_name" with correct extenstion. you will have to find the extension and append it with the name.

[kclark]

Am I close with this?

[joe2]

i am not able to see value assign statement for $new_file_name. means
$new_file_name = New name of your file.

you can check the extention by echo.

[kclark]

How do I make $new_file_name be a random file name?

[joe2]

use timestamp as a filename append with correct extenstion. you will get new file name always or write a random function..

[kclark]

would that be

$new_file_name = "timestamp";

[joe2]

$new_file_name = time();

time() see manual

[kclark]

Is what I have in Red correct?

[bradgrafelman]

This:

if (copy($userfile, "photos/$foldername/$new_file_name"."$extension")) {

is missing a period between the file name and extension. No need to escape out of the double quotes:

if (copy($userfile, "photos/$foldername/$new_file_name.$extension")) {

Also, note that if this script is run by two different people at the same time (within the same second), there will be a duplicate filename. Here's a way to make filenames a bit more random:

$new_file_name = md5(microtime());

[kclark]

This is my updated code below. I am getting a new_file_name with microtime, but I am not getting an extension. I get the name plus a period (.), no extension. For some reason, the database is not being updated either. I wonder if I need to change the file name to something with the extension and then insert it into the part below in Red. In other words, get the extension of the upload file, change the name with microtime() and then put the two together and then insert it into the copy statement.

//Creates ID folder in the upload directory
          $foldername = "". $_REQUEST['ID'] ."";

      if(!is_dir("photos/$foldername"))
      {mkdir ("photos/$foldername", 0777); 
      chmod ("photos/$foldername", 0777);}
      else {}  

      $resourcefolder = "photos/"; 
      $filestocopy = array();

      $filestocopy[0] = "slideshow.php"; 
      //$filestocopy[1] = "template.html"; 

      $frompath = "photos/"; 
      $topath = "photos/".$foldername."/"; 

      foreach ($filestocopy as $value) 
      { 
      copy ($frompath.$value,$topath.$value); 
      } 

     //Get file extension         
     $extension = strrchr($userfile, ".");

     //Make New File Name
     $new_file_name = md5(microtime());

     //Copies file to specified location
      if (copy($userfile, "photos/$foldername/[COLOR=Red]$new_file_name.$extension[/COLOR]")) {
        $userfile_location = "photos/$foldername";

        //Deletes file in TMP directory
        unlink($userfile);

      //Add File info to database
        add_file($yourname, $email_address, $caption, $userfile_location, $new_file_name, $_REQUEST['ID']);
      } else {
        require("header.php");
        echo "Your file could not be copied.\n";
        require("footer.php");
      }

[bradgrafelman]

Try changing this:

         //Get file extension         

         $extension = strrchr($userfile, ".");

     //Make New File Name
     $new_file_name = md5(microtime());

to this:

         //Make New File Name
     $new_file_name = md5(microtime()) . strrchr($userfile, '.');
     'TEST -- filename: ' . $new_file_name . '<br/>';

What does it output?

NOTE: You'd also change the "$new_file_name.$extension" to just "$new_file_name" in the copy() function.

[kclark]

sorry, I am currently getting a db error.

I got my error fixed.

[kclark]

bradgrafelman,

I tried your code changes shown below and it did change the file name in the database and in the directory, but there is no extension to the files.

//Make New File Name 
         $new_file_name = md5(microtime()) . strrchr($userfile, '.'); 
         'TEST -- filename: ' . $new_file_name . '<br/>';

      //Copies file to specified location
      if (copy($userfile, "photos/$foldername/$new_file_name")) {
        $userfile_location = "photos/$foldername";

       //Deletes file in TMP directory
        unlink($userfile);

[bradgrafelman]

So it doesn't even echo the filename correctly? Try echo'ing out $userfile -- what do you get?

[kclark]

where would I insert the echo statement. I get the new filenames like your code says, it just doesn't have the extension on it.

[bradgrafelman]

kclark wrote:

it just doesn't have the extension on it.

The filename should appear exactly as it is echo'd. If you see "TEST -- filename: myfile.jpg" then it should have a .jpg extension. Are you saying the TEST echo has a filename with an extension, but the newly copied file doesn't have an extension? If so, I'm puzzled - the same text that is echo'd is passed along to the copy() function ...

Are you sure you're not trying to view these files in Windows and have not unchecked the box that says "Hide extensions for known file types" under Tools -> Folder Options ?

[kclark]

Okay, this is what gets displayed on the screen for $new_file_name

TEST -- filename: a3f4bab20a22b9866597f34a3983da6e

this is what is displayed for $userfile

TEST -- filename: /tmp/phpGos72w