[RESOLVED] register globals question

[asa_carter]

I have recently started updating my code with register globals set to off.

On one page I have:

setcookie(current_url, "$REQUEST_URI", time()+3600);

On the next I have:

$current_url = $_COOKIE['current_url'];

however, $current_url is not available to the second page. Can anyone please tell me why?

[asa_carter]

Fixed with:

setcookie(current_url, $_SERVER['REQUEST_URI'], time()+3600, '/');

[Installer]

You should also turn on error reporting. Then you'd be alerted to things like

Notice: Use of undefined constant current_url - assumed 'current_url'...

and

Notice: Undefined variable: REQUEST_URI...

[asa_carter]

Cool.

How do I turn on error reporting? In htaccess? If it is, how do I modify it?

Also...

I am having problems getting my image upload script working with globals turned off.

   

$num = 0;
$start_row = 36;
while($num < 6)
{
  $num++;
  if ($pic_remove[$num]=="Remove Picture")
  {
    echo "<p>Picture $num: <input type=\"file\" name=\"pic[$num]\" /></p>";
    @unlink("$archive_dir/$pic_name[$num]");
  }
  elseif ($pic_size[$num] > $max_filesize)
    echo "<p style=\"color:#FF0000;\">Picture $num: <input type=\"file\"   

    name=\"pic[$num]\" /> File is too big. Limit is 800 kb.</p>";
  elseif (($pic_type[$num]!="image/pjpeg") && ($pic_type[$num]!="image/gif") && ($pic_type[$num]!="image/bmp") && 
($pic_type[$num]!="image/jpeg") && ($pic_type[$num]!="image/png") && $pic[$num]!="")
   echo "<p style=\"color:#FF0000;\">Picture $num: <input type=\"file\" name=\"pic[$num]\" /> Incorrect file type.</p>";
  elseif (($pic_set[$num]=="true") || ($pic[$num]))
  {
   $source = "$archive_dir/".$pic_name[$num];
    echo "<div style=\"width:300px;background-color:#FFFFAE;border:#999999 solid 1px;margin-bottom:12px;\">";
    echo "<table cellpadding=\"5\" cellspacing=\"0\"><tr><td rowspan=\"2\"><img src=\"$source\" width=\"58\" height=\"58\"></td>";
    echo "<input type=\"hidden\" name=\"pic_set[$num]\" value=\"true\" />";
    echo "<input type=\"hidden\" name=\"pic_name[$num]\" value=\"$pic_name[$num]\" />";
   echo "<td>Picture $num</td></tr><tr>";
   echo "<td valign=\"bottom\"><input type=\"submit\" name=\"pic_remove[$num]\" value=\"Remove Picture\"></td></tr></table></div>";
  }
  else
    echo "<p>Picture $num: <input type=\"file\" name=\"pic[$num]\" /></p>";
}
?>

How do I access the variables?

$pic[] = $POST'pic[]']; or
$pic[] = $FILES['pic[]']; or
$pic[1] = $POST['pic[1]']; or
$pic = $POST['pic'];

I have tried a few different ways but cannot seem to get the script working.

[Weedpacket]

1) look up [man]error_reporting[/man]

2) $POST['pic'][0] .. $POST['pic'][6], or just $pic = $_POST['pic'] to make $pic an array.

[asa_carter]

I have put an echo in to test to see if it is outputting something but it's not. This is just a part of the code that copies the file. It works fine with register globals turned on. The only other thing I have changed is that I'm testing on Vista RC-1.

Edit:

I turned error reporting on and got this output from the echo line:

Notice: Undefined index: pic_set in /home/ixdipfd/public_html/auction/sellcb.php on line 101

Notice: Undefined index: pic in /home/ixdipfd/public_html/auction/sellcb.php on line 101

  

  $num = 0;
  while($num < 6)
  {
    $num++;

echo $_POST['pic_set'][$num], $_POST['pic'][$num];  // This does not output anything

if (($pic_set[$num]) || ($pic[$num]))
{
  if ($pic_size[$num] > $max_filesize)
    $err2=1;
  if (($pic_type[$num]!="image/pjpeg") && ($pic_type[$num]!="image/gif") && ($pic_type[$num]!="image/bmp") && 
  ($pic_type[$num]!="image/jpeg") && ($pic_type[$num]!="image/png"))
    $err2=1;
  if ($pic_size[$num]<=0)
    $err2=0;
  if (isset($WINDIR))
    $pic[$num] = str_replace("\\\\","\\", $pic[$num]);
  $filename = basename($pic_name[$num]);	
  copy($pic[$num], "$archive_dir/$filename");
}
  }

[Weedpacket]

What does print_r($_POST) give you?

Oh, and I manage to see now that pic is the image itself. That's in $_FILES. print_r() that, too.

[asa_carter]

Output from both print_r :

Array ( [sent] => 1 [opprice] => 45 [resprice] =>
Notice: Undefined variable: resprice in /home/ixdipfd/public_html/auction/sellcb.php on line 168
[bnprice] =>
Notice: Undefined variable: bnprice in /home/ixdipfd/public_html/auction/sellcb.php on line 172
[duration] => 7 Days [quantity] => 1 [location] => Campbeltown, Argyll and Bute, PA28 6ST [direction] => Continue > ) Array ( [pic] => Array ( [name] => Array ( [1] => [2] => [3] => [4] => [5] => [6] => ) [type] => Array ( [1] => [2] => [3] => [4] => [5] => [6] => ) [tmp_name] => Array ( [1] => [2] => [3] => [4] => [5] => [6] => ) [error] => Array ( [1] => 4 [2] => 4 [3] => 4 [4] => 4 [5] => 4 [6] => 4 ) [size] => Array ( [1] => 0 [2] => 0 [3] => 0 [4] => 0 [5] => 0 [6] => 0 ) ) )

Should I access it:

$_FILES['pic']['name'][1] or something like that?

[asa_carter]

I made a test page for the whole image upload. It's still not working correctly. I dont think the images are being copied to the server.

Is this correct:

    

if (($pic_set[$num]) || ($pic_name[$num]))
    {
      if (isset($WINDIR))
        $pic[$num] = str_replace("\\\\","\\", $pic[$num]);
      $filename = basename($pic_name[$num]);	
	  copy($pic[$num], "$archive_dir/$filename");
    }

<?
error_reporting(E_ALL);

// assign posted variables to local variables
$sent = $_POST['sent'];
$pic = $_FILES['pic'];
$pic_name = $_FILES['pic']['name'];
$pic_type = $_FILES['pic']['type'];
$pic_size = $_FILES['pic']['size'];
$pic_remove = $_POST['pic_remove'];
$pic_set = $_POST['pic_set'];
$valid_user="asa_carter";
$archive_dir = "user_images/$valid_user";

if (!file_exists($archive_dir)) mkdir($archive_dir, 0777);
$max_filesize = 800000;

if ($sent==1)
{
  $num = 0;
  while($num < 6)
  {
    $num++;
    if (($pic_set[$num]) || ($pic_name[$num]))
    {
      if ($pic_size[$num] > $max_filesize)
        $err2=1;
      if (($pic_type[$num]!="image/pjpeg") && ($pic_type[$num]!="image/gif") && ($pic_type[$num]!="image/bmp") && 
	  ($pic_type[$num]!="image/jpeg") && ($pic_type[$num]!="image/png"))
	    $err2=1;
      if ($pic_size[$num]<=0)
	    $err2=0;
      if (isset($WINDIR))
        $pic[$num] = str_replace("\\\\","\\", $pic[$num]);
      $filename = basename($pic_name[$num]);	
	  copy($pic[$num], "$archive_dir/$filename");
    }
  }
}
?>

<form action="image_test.php" method="post" enctype="multipart/form-data">
<input type="hidden" name="sent" value="1" />

<?
$num = 0;
while($num < 6)
{
  $num++;
  if ($pic_remove[$num]=="Remove Picture")
  {
    echo "<p>Picture $num: <input type=\"file\" name=\"pic[$num]\" /></p>";
    @unlink("$archive_dir/".$_POST['pic_name'][$num]);
  }
  elseif ($pic_size[$num] > $max_filesize)
    echo "<p style=\"color:#FF0000;\">Picture $num: <input type=\"file\" name=\"pic[$num]\" /> File is too big. Limit is 800 kb.</p>";
  elseif (($pic_type[$num]!="image/pjpeg") && ($pic_type[$num]!="image/gif") && ($pic_type[$num]!="image/bmp") && 
  ($pic_type[$num]!="image/jpeg") && ($pic_type[$num]!="image/png") && $pic_name[$num]!="")
    echo "<p style=\"color:#FF0000;\">Picture $num: <input type=\"file\" name=\"pic[$num]\" /> Incorrect file type.</p>";
  elseif (($pic_set[$num]=="true") || ($pic_name[$num]))
  {
    $source = "$archive_dir/$pic_name[$num]";
    echo $source;
    echo "<div style=\"width:300px;background-color:#FFFFAE;border:#999999 solid 1px;margin-bottom:12px;\">";
    echo "<table cellpadding=\"5\" cellspacing=\"0\"><tr><td rowspan=\"2\"><img src=\"$source\" width=\"58\" height=\"58\"></td>";
    echo "<input type=\"hidden\" name=\"pic_set[$num]\" value=\"true\" />";
    echo "<input type=\"hidden\" name=\"pic_name[$num]\" value=\"$pic_name[$num]\" />";
  	echo "<td>Picture $num</td></tr><tr>";
    echo "<td valign=\"bottom\"><input type=\"submit\" name=\"pic_remove[$num]\" value=\"Remove Picture\"></td></tr></table></div>";
  }
  else
    echo "<p>Picture $num: <input type=\"file\" name=\"pic[$num]\" /></p>";
}
?>

<div id="msg" style="display:none;height:50pox;border:double #FF0000 6px;margin:10px;padding:20px;text-align:center;">
<div style="font-size:20px;font-style:italic;font-weight:bold;">Loading Pictures</div>
<b>Your pictures are being sent to our system. Depending on your connection speed and the size of your image files, this might take 
several minutes. Please wait.</b></div>

<input type="submit" name="direction" value="Upload Pictures" onClick="if (hasPic(this.form)) 
document.getElementById('msg').style.display='';" />
<hr />
<input type="submit" name="direction" value="&lt; Back" onClick="if(hasPic(this.form)) 
document.getElementById('msg').style.display='';" />
<input type="submit" name="direction" value="Continue &gt;" onClick="if(hasPic(this.form))
document.getElementById('msg').style.display='';" />
</form>

<script language="javascript">
function hasPic(form) {
  var pic="";
  for (var i=1; i<=6; i++) {
    if (form["pic["+i+"]"]) {
	  pic+=form["pic["+i+"]"].value;
    }
  }
  return pic!="";
}
</script>