[RESOLVED] combine two strings into a query

hackersapien

I am picking values from which are seperated by a comma in the following format:

value1,value2,value3

I then pass the values into a query such that if the value was only one the query would be:

$sql="select vacancy from jobs where vacancy='$value1'";

If it was more then one value then it would be:

$sql="select vacancy from jobs where vacancy='$value1' or '$value2' or '$value3'";

The number fo values may vary depending on what the user has selected, I have written the following code but am having a problem with the last OR statement.

$arrPosition=explode(",",$position);

		if(sizeof($arrPosition)>1){

			foreach($arrPosition as $val){

				//echo $val." or ";
				$val.=" OR ";
$sql="select vacancy from jobs where vacancy=$val";

				//getApplicantsByDate($vacancy=$val,$startdate,$enddate);
			}

		}else{
			$sql="select vacancy from jobs where vacancy=$position";

		}

Unfortunately when the value is more then one it prints out the following sql:

"select vacancy from jobs where vacancy='cook' OR 'guard' OR ";

resulting in error, any help from you guys would really be good..

Cheers

zabmilenko

Try:

$query = "select vacancy from jobs where vacancy='$value1' OR vacancy='$value2' OR vacancy='$value3'";

hackersapien

zabmilenko wrote:

Try:

$query = "select vacancy from jobs where vacancy='$value1' OR vacancy='$value2' OR vacancy='$value3'";

There is nothing wrong with the query, my problem is how do I combine those values inot the one query with the OR statement!!..such that when it gets to the last value passed it eliminates the OR from the sql statement!!

zabmilenko

I'm not following...

Are you trying to make a dynamic query where you could have 1 match or 10 matches?

Like this?:

 $query = "select vacancy from jobs where vacancy in (". implode(',', $values_array)) .")";

EDIT: Or this?:

 $query = "select vacancy from jobs where vacancy = '". implode("' or '", $values_array)) ."'";

hackersapien

zabmilenko wrote:
I'm not following...

Are you trying to make a dynamic query where you could have 1 match or 10 matches?

Like this?:
 $query = "select vacancy from jobs where vacancy in (". implode(',', $values_array)) .")"; 
EDIT: Or this?:
 $query = "select vacancy from jobs where vacancy = '". implode("' or '", $values_array)) ."'"; 

Seems I was trying to do the second one which has worked very well, but there is a typo on your code it should be:

implode("' or '", $values_array)

not

implode("' or '", $values_array))

Installer

Use $query = rtrim($query, ' OR');

There is nothing wrong with the query...

What zablimenko may have been trying to point out was that the query is, in fact, wrong. It should be WHERE vacancy = 'value1' OR vacancy = 'value2', not WHERE vacancy = 'value1' OR 'value2'.