Neater way to write SQL Query

[mdattani]

Is there a neater way of writing this SQL Query below? Any help is much appreciated.
Thanks

$query = "select * from car, cardetails, comments where car.make like '$make' and car.model like '$model' and cardetails.transmission like '$transmission' and cardetails.fuel like '$fuel' and car.mileage >= '$mileagelow' and car.mileage <= '$mileagehigh' and car.price >= '$pricelow' and car.price <= '$pricehigh' and car.regno = cardetails.regno and car.regno = comments.regno";

[zabmilenko]

You could reduce it a bit by putting the common parts of it into a view:

VIEW: select * from car, cardetails, comments where car.regno = cardetails.regno and car.regno = comments.regno

Then if your view name is "carquery":

Select * from carquery where make like '$make' and model like '$model' and transmission like '$transmission' and fuel like '$fuel' and mileage >= '$mileagelow' and mileage <= '$mileagehigh' and price >= '$pricelow' and price <= '$pricehigh'

Which would be a little bit better.

[matt72]

It would also be a ggod idea to change "make like '$make''" to "make = '$make'". LIKE is used for pattern matching and you don't have any patterns, you're just checking if it's equal.