Register Globals and Files

asa_carter

I'm still having problems with getting this image upload to work with register globals turned off. It doesn't copy the image to the server. I'm not sure if I'm accessing the variables correctly? What am I doing wrong?

<?
$pic[1] = $_FILES['pic'][1];
$pic[2] = $_FILES['pic'][2];
$pic[3] = $_FILES['pic'][3];
$pic[4] = $_FILES['pic'][4];
$pic[5] = $_FILES['pic'][5];
$pic[6] = $_FILES['pic'][6];
$pic_name = $_FILES['pic']['name'];
$pic_type = $_FILES['pic']['type'];
$pic_size = $_FILES['pic']['size'];

$num = 0;
while($num < 6)
{
  $num++;
  echo "pic: $pic[$num]<br>";
  echo "pic set: $pic_set[$num]<br>";
  echo "pic name: $pic_name[$num]<br>";
  echo "pic type: $pic_type[$num]<br>";

  if (isset($WINDIR))
    $pic[$num] = str_replace("\\\\","\\", $pic[$num]);
  copy($pic[$num], "$archive_dir/$pic[$num]");
}
?>

<form action="image_test.php" method="post" enctype="multipart/form-data">

<?
$num = 0;
while($num < 6)
{
  $num++;
  echo "Picture $num: <input type=\"file\" name=\"pic[$num]\" /><br />";
}
?>

<input type="submit" value="Upload" /> 
</form>

altexis

What is the error message you get?

asa_carter

altexis wrote:
What is the error message you get?

I don't get any error message. The file just does not copy. I've been searching other posts and see that some some people use:

$pic_tmp_name = $_FILES['pic']['tmp_name'];

copy($pic_tmp_name[$num], "$archive_dir/$pic_tmp_name[$num]");

However this produces a cannot open stream error.

I've been trying to fix this for a few days now so I've started looking on source forge for image upload scripts. Uber Uploader seems pretty good but it would take quite a bit of integrating to my site.

Can anyone recommend a multiple image upload script?

m_tt

For starters, I notice your loop is incorrect. You have $num = 0 then $num < 6 but your array is 1 -> 6

So 0 is a false array item, and 6 is never seen.

It should be

$num = 1;
while ($num <= 6)

(Just noticed that you increment $num first to avoid the 0, but 6 would still never been seen using less than.)

Other than that, I have to assume that $WINDIR and $archive_dir are correctly defined and not causing problems with slashes. Is copy() returning any errors?

m_tt

Have you already read this page?

http://us3.php.net/manual/en/features.file-upload.php

asa_carter

Ah.., I'll try using the script with "move_uploaded_file" instead. Thanks.

asa_carter

I'm almost there. The script works fine.

If I want to post the form again, I need to repost the image but without uploading it again. How do I repost it?

echo "<input type=\"hidden\" name=\"pic[$num]\" value=\"????\" />";