strange problem renaming files on server

[Paul_Ferrie]

Hi guys,
I hope someone can help me with this. I have been stumped all morning as to why it's not working.

I have 2 gallery's clients and applicants
the images in these gallery's are number sequentially
1_thumb.jpg
1_main.jpg
2_thumb.jpg
2_main.jpg
And so on....

When i want to delete any images from the clients gallery i use the script below

$filePath	= '../media/models/'.$_POST['cl_id']."/";
$imgThumb	= $_POST['imgThumb'];
$imgXLs 	= $_POST['imgMain'];
if(!unlink($filePath.$imgThumb)) {
	$error	= "Error deleting thumb nail from server.";
	print $error;
	exit;
} 
if(!unlink($filePath.$imgXLs)) {
	$error	= "Error deleting large image from server.";
	print $error;
	exit;
} 
if ($handleA = opendir($filePath)) {
	$i=0;
	while (false !== ($fileA = readdir($handleA))) {
		if ($fileA != "." && $fileA != "..") {			
    		if(substr_count($fileA, '_main.jpg')==1){
				//
			}else if(substr_count($fileA, 'spotlite.jpg')==1){
				//
			}else if(substr_count($fileA, 'Thumbs.db')==1){
				//
			}else{
				$i++;
				rename($filePath.$fileA, $filePath.$i."_thumb.jpg");
			}
		}
	}
	closedir($handleA);
}
if ($handleB = opendir($filePath)) {
	$j=0;
   	while (false !== ($fileB = readdir($handleB))) {
       	if ($fileB != "." && $fileB != "..") {  				
    		if(substr_count($fileB, '_thumb.jpg')==1){
				//	
			}else if(substr_count($fileB, 'spotlite.jpg')==1){
				//
			}else if(substr_count($fileB, 'Thumbs.db')==1){
				//
			}else{
				$j++;
				rename($filePath.$fileB, $filePath.$j."_main.jpg");
			}
		}
    }
	closedir($handleB);
}
print "&retval=1&";

Now this delete's the relevent image then rename's all the files keeping the sequential flow of numbers.

I use the same script to delete images from the applicants folder

$filePath	= '../media/modelapps/'.$_POST['app_id']."/";
$imgThumb	= $_POST['imgThumb'];
$imgXLs 	= $_POST['imgMain'];
if(!unlink($filePath.$imgThumb)) {
	$error	= "Error deleting thumb nail from server.";
	print $error;
	exit;
} 
if(!unlink($filePath.$imgXLs)) {
	$error	= "Error deleting large image from server.";
	print $error;
	exit;
} 
if ($handleA = opendir($filePath)) {
	$i=0;
	while (false !== ($fileA = readdir($handleA))) {
		if ($fileA != "." && $fileA != "..") {			
    		if(substr_count($fileA, '_main.jpg')==1){
				//
			}else if(substr_count($fileA, 'spotlite.jpg')==1){
				//
			}else if(substr_count($fileA, 'Thumbs.db')==1){
				//
			}else{
				$i++;
				rename($filePath.$fileA, $filePath.$i."_thumb.jpg");
			}
		}
	}
	closedir($handleA);
}
if ($handleB = opendir($filePath)) {
	$j=0;
   	while (false !== ($fileB = readdir($handleB))) {
       	if ($fileB != "." && $fileB != "..") {  				
    		if(substr_count($fileB, '_thumb.jpg')==1){
				//	
			}else if(substr_count($fileB, 'spotlite.jpg')==1){
				//
			}else if(substr_count($fileB, 'Thumbs.db')==1){
				//
			}else{
				$j++;
				rename($filePath.$fileB, $filePath.$j."_main.jpg");
			}
		}
    }
	closedir($handleB);
}
print "&retval=1&";

I get errors renaming files. file already exsists.

i have checked the folder permissions and both are as they should and for added measure i used unmask in the off chance there was a problem with the folder permissions.

Any????

[sneakyimp]

did you try posting this on the gallery forums? you'd probably have more luck getting an answer there as this question pertains to their fairly unique code.

[altexis]

What errors do you get? In which lines?

[Paul_Ferrie]

sneakyimp wrote:

did you try posting this on the gallery forums? you'd probably have more luck getting an answer there as this question pertains to their fairly unique code.

Where, who?

The error i get is "error renaming thumb file and main image"
File already exsist's.

[altexis]

Then that is the problem.. files already exist.
Either put a @ symbol before rename() to supress the error message .. or an if condition..

if (!file_exists($filePath.$i."_thumb.jpg")) rename($filePath.$fileA, $filePath.$i."_thumb.jpg");

[Paul_Ferrie]

THats was the original setup but i removed it for debugging.

THe thing is the script works fine for another folder(gallery category) on another part of the site. just vars and path are diffrent and it works.
So why does it not work here?

[altexis]

You have the access to the scripts and the file system so only you can answer this. Perhaps you executed the script more than once and some files are already there.

[Paul_Ferrie]

Well i dont know what i did diffrently from yesterday, it now works :S
What is that all about???.

if ($handleA = opendir($filePath)) {
	$i=0;
	while (false !== ($fileA = readdir($handleA))) {
		if ($fileA != "." && $fileA != "..") {			
    		if(substr_count($fileA, '_main.jpg')==1){
				//
			}else if(substr_count($fileA, 'spotlite.jpg')==1){
				//
			}else if(substr_count($fileA, 'Thumbs.db')==1){
				//
			}else{
				$i++;
				if (!file_exists($filePath.$i."_thumb.jpg")) {
				rename($filePath.$fileA, $filePath.$i."_thumb.jpg");
				}
			}
		}
	}
	closedir($handleA);
}
if ($handleB = opendir($filePath)) {
	$j=0;
   	while (false !== ($fileB = readdir($handleB))) {
       	if ($fileB != "." && $fileB != "..") {  				
    		if(substr_count($fileB, '_thumb.jpg')==1){
				//	
			}else if(substr_count($fileB, 'spotlite.jpg')==1){
				//
			}else if(substr_count($fileB, 'Thumbs.db')==1){
				//
			}else{
				$j++;
				if (!file_exists($filePath.$j."_main.jpg")) {
				rename($filePath.$fileB, $filePath.$j."_main.jpg");
				}
			}
		}
    }
	closedir($handleB);
}

[altexis]

Try to execute this script in a clean directory.. (with no thumb.jpg or main.jpg files). I think it will not give you any problem.

[sneakyimp]

i'm not certain, but your code looks like it comes from this project:

http://gallery.menalto.com/forum