Quick help required please!

[kbc1]

Hi

I have a function which selects a random image each time it is called:

	$q= "SELECT id FROM mytable ORDER BY id DESC";
	$r= mysql_query($q);
	$c= mysql_num_rows($r);

$total = $c;
$file_type = ".jpg";
$image_folder = "images/myimages";
$start = "1";
$random = mt_rand($start, $total);
$image_name = $image_folder . "/" . $random . $file_type;

return $image_name;

On the page that display the image i have something like <img src = "$image_name" >.

My problem is that this only gets images that have the same name as the ID they are associated to in the database because it uses the $random variable as the image name.

Can someone help me to change it so that it randomly selects an image by the name of the image please so that the img src tags will pick it up?

Thanks in advance

[Ausx]

That really isn't the best way of doing, an easier way would be:

$sql = "SELECT * FROM mytable";
$qry = mysql_query($sql);
$nums = mysql_num_rows($qry);

$rand = rand(0,$nums);

$sql = "SELECT `filename` FROM mytable WHERE id = $rand";
$qry = mysql_query($sql);
$file_name = mysql_fectch_assoc($qry);

$ret =  'images/myimages' . $file_name['filename'] . '.jpg';
return $ret;

That will give you the randomised file name to put in your image tag. That's providing you have the file names stored in the table.

If you are using PHP5 then you don't need to db entry at all.

$dir = "images/myimages";
$scanned = scandir($dir,1);
$total = count($scanned);
$total = $total - 2; // so you don't get the '.' and '..'

$rand = rand(0,$total);
$ret = $dir . $scanned[$rand] . '.jpg';
return $ret;

[bogu]

$q= "SELECT id FROM mytable ORDER BY RAND() LIMIT 1"; 
$r= mysql_query($q) or die(mysql_error());
$id = mysql_fetch_assoc($r);
mysql_free_result($r);

$file_type = ".jpg"; 
$image_folder = "images/myimages"; 
$image_name = "{$image_folder}/{$id['id']}.{$file_type}";

return $image_name;

u can use a do ... while in case your file doesnt exists

do {
    /*select a random image ($image_name) */
} while (!file_exists($image_name));

return $image_name;