Why is This Class Bad?

TheMayhem

class sql{
    //Connect to MySQL
        function connect($host, $user, $pass, $db) {
            //Connect to MySQL Server
            $link = mysql_connect($host, $user, $pass);
            if (!$link) {
               die('Fatal Error: Could not connect to MySQL Database!Debug Info:' . mysql_error());
            }

        //Select MySQL Database
        $db_selected = mysql_select_db($db, $link);
        if (!$db_selected) {
           die ('Fatal Error: Could not select MySQL Database!Debug Info:' . mysql_error());
        }

        return $link;
    }
// Count SQl Count
var $count;
        //Query MySQL Database
        function query($query) {
            $result = mysql_query($query);
            return $result;
            $this->count++;
        }

    //Fetch array Query MySQL Database
    function fetch($query) {
        $result = mysql_query($query);
        $rows = mysql_fetch_array($result, MYSQL_BOTH);
        return $rows;
        $this->count++;
    }

    //Disconnect from MySQL
    function kill($link) {
        mysql_close($link);
    }

    // Count SQL Queries
    function count_queries()
    {
    return $this->count;
    }

}

$sql->connect($user, $pass, $host, $db);

Produces this beuatiful error.

Fatal error: Call to a member function connect() on a non-object in /home/arena/public_html/beta/config/connect.php on line 50

Weedpacket

And where do you create the object you're storing in $sql?

laserlight

Did you actually create an sql object named $sql?

TheMayhem

My bad on updating the thread. About 45 minutes after posting this I switched

$sql->connect(....);

$mysql = new sql();
$mysql->connect($lh, $dbu, $dbp, $dbn);

This is outputting this error...

Fatal error: Cannot redeclare class sql in /home/arena/public_html/beta/config/css.php on line 4

laserlight

Are you sure you do not have duplicate inclusion of the file that contains the class declaration?

TheMayhem

I can't explain how but later on in the day the file just suddenly started to work. Wasn't my internet cache or anything as I checked it repeatedly.

My last question to this is what do I need to add exactly to keep track of the number of queries executed per page to the class & functions above?

Weedpacket

A field in the class that is incremented in each method that does whatever it is you want to count.

TheMayhem

I'm not really sure what exactly to add to the class as everything is very new to me and the whole main purpose of this was to eventually get the class to count the queries executed from the coding above and then just output the number of queries at the end of a page.