how does this code create this output?!?!?

lyricsride

function create_dropdown($identifier,$pairs,$firstentry,$multiple="",$key="")
	{
		//$identifier: The name assigned to the drop-down list, determining how the posted variable will be referenced.
		//$pairs: An associative array that contains the key-value pairs used to create the selection menu entries.
		//$firstentry: Serves as a visual cue for the drop-down list, and is placed in the very first position.
		//$multiple: Should this drop-down list allow for multiple selection? If yes, pass in multiple; if no, pass in nothing (the parameter is optional).
		//$key: This optional parameter holds the value of the element to be autoselected. If it is not assigned, then no values will be autoselected.

	$dropdown = "<select name=\"$identifier\" $multiple>";
	$dropdown .= "<option name=\"\">$firstentry</option>";
	foreach($pairs as $value => $name)
	{
		$dropdown .= ($value == $key)? "<option name=\"$value\" selected=\"selected\">$name</option>":
		"<option name=\"$value\">$name</option>";
	}
	echo "</select>";
	return $dropdown;
}

creates this html

</select><select name="tiers" ><option name="">Choose One:</option><option name="1" selected="selected">Director</option><option name="2">Core</option><option name="3">Assistant</option>

Why the hellis </select> being echoed at the front? I've played around with this many times to no avail. Totally stumped!

Thanks,
Jason

Rodney_H_

It is THIS line of code:

	[B]echo "</select>";[/B]
	return $dropdown;

You echo out the close of the select tag, and you RETURN all else.

So, when the function is called, you echo the end tag BEFORE outputting all else..

The fix is to concatenate the value to the dropdown var:

$dropdown .= "</select>";
return $dropdown;

<?php
function create_dropdown($identifier,$pairs,$firstentry,$multiple="",$key="")
{
	$dropdown = '<select name="'.$identifier.'" '.$multiple.'>
	<option name="">'.$firstentry.'</option>'."\n";

foreach($pairs as $value => $name)
{
	if($value == $key)
	{
		$dropdown .= '<option name="'.$value.'" selected="selected">'.$name.'</option>'."\n";
	}
	else
	{
		$dropdown .= '<option name="'.$value.'">'.$name.'</option>'."\n";
	}
}
$dropdown .= '</select>'."\n";

return $dropdown;
}
?>

NogDog

I believe you want to replace the "name" attribute in your option tags with the "value" attribute:

"<option value=\"$value\">$name</option>"

lyricsride

thank you, both of you.

The sad part is that i studied that script as is from a php text book

"Apress.Beginning.PHP.and.MySQL.5.From.Novice.to.Professional.2nd.Edition.Jan.2006.pdf"

I'm glad i didn't pay for it... POS

There were other problems i found, meaning they were OBVIOUS ones. ahhh stay awa from this book :p

anyways, thanks again guys, it seems fine now. And i understand why it didn't work.

Cheers,
Jason

Rodney_H_

NogDog wrote:
I believe you want to replace the "name" attribute in your option tags with the "value" attribute:
"<option value=\"$value\">$name</option>"

OOPS! I didn't catch that! Thanks, nogdog. You are the ... man-dog!!