my code, can anybody help sort this out?

basslion

hi i have some code i am working with and it is supposed to call upon different images for a menu depending on what language the user has chosen for the store front. if they choose english , it will fetch the english menu buttons and add them, same with for different languages.

The English language works fine as View Source on the webpage http://idkort.nu will indicate. When i change language to finnish though, the language does change but the menu buttons go blank. In view source, it shows images not visible in src location and second image shows as Array, whatever that means.

Here is the code in my PHP file that is supposed to make this happen.

<?
switch ($languages_id){
case 1: $main = "src=images/ENGLISH_01.jpg";
$products = "src=images/ENGLISH_02.jpg";
$account = "src=images/ENGLISH_03.jpg";
$shopcart = "src=images/ENGLISH_04.jpg";
$checkout = "src=images/ENGLISH_05.jpg";
$contacts = "src=images/ENGLISH_06.jpg";
break;
case 2: $main = "src=images/SVENSKA_01.jpg";
$products = "src=images/SVENSKA_02.jpg";
$account = "src=images/SVENSKA_03.jpg";
$shopcart = "src=images/SVENSKA_04.jpg";
$checkout = "src=images/SVENSKA_05.jpg";
$contacts = "src=images/SVENSKA_06.jpg";
break;
case 3: $main = "src=images/NORWAY_01.jpg";
$products = "src=images/NORWAY_02.jpg";
$account = "src=images/NORWAY_03.jpg";
$shopcart = "src=images/NORWAY_04.jpg";
$checkout = "src=images/NORWAY_05.jpg";
$contacts = "src=images/NORWAY_06.jpg";
break;
case 4: $main = "src=images/FINNISH_01.jpg";
$products = "src=images/FINNISH_02.jpg";
$account = "src=images/FINNISH_03.jpg";
$shopcart = "src=images/FINNISH_04.jpg";
$checkout = "src=images/FINNISH_05.jpg";
$contacts = "src=images/FINNISH_06.jpg";
break;
}
?>
<td><a href=<?=tep_href_link('index.php')?>><img <?= $main;?> alt="" width="100" height="32" border="0" /></a></td>
<td><a href=<?=tep_href_link('products_new.php')?>><img <?= $products;?> alt="" width="89" height="32" border="0" /></a></td>
<td><a href=<?=tep_href_link('account.php')?>><img <?= $account;?> alt="" width="90" height="32" border="0" /></a></td>
<td><a href=<?=tep_href_link('shopping_cart.php')?>><img <?= $shopcart;?> alt="" width="90" height="32" border="0" /></a></td>
<td><a href=<?=tep_href_link('checkout_shipping.php')?>><img <?= $checkout;?> alt="" width="91" height="32" border="0" /></a></td>
<td><a href=<?=tep_href_link('contact_us.php')?>><img <?= $contacts;?> alt="" width="105" height="32" border="0" /></a></td>

Does anyone see anything i am missing here. I have been tryin gto figure this out for weeks.

Any help is GREATLY appreciated!

Thanks

Matt

Azala

Try putting the correct quotes around the src

"src=\"images/ENGLISH_01.jpg\"";

basslion

I tried this and the same result. The English jpg's are called upon, but not the other ones so this tells me the problem has nothing to do with the src quotes but rather possible a case issue.

Also - the person who taught me this tutorial whom i cannot reach anymore made a flash movie on exactly how to do it here

http://info.template-help.com/files/OsCommerce/How_to_make_buttons_in_different_languages.swf

I followed this 100% and it still is wrong. 😕

Thank you for your help though.

Matt

Azala

You check a variable called $languages_id, but it's not set anywhere...nor do you pass the id in the linking.

<?
$languages_id = (isset($_GET["lang"]) && is_numeric($_GET["lang"])) ? $_GET["lang"] : 1;
switch ($languages_id){
case 1: $main = "src=images/ENGLISH_01.jpg";
$products = "src=images/ENGLISH_02.jpg";
$account = "src=images/ENGLISH_03.jpg";
$shopcart = "src=images/ENGLISH_04.jpg";
$checkout = "src=images/ENGLISH_05.jpg";
$contacts = "src=images/ENGLISH_06.jpg"; 
break;
case 2: $main = "src=images/SVENSKA_01.jpg";
$products = "src=images/SVENSKA_02.jpg";
$account = "src=images/SVENSKA_03.jpg";
$shopcart = "src=images/SVENSKA_04.jpg";
$checkout = "src=images/SVENSKA_05.jpg";
$contacts = "src=images/SVENSKA_06.jpg"; 
break;
case 3: $main = "src=images/NORWAY_01.jpg";
$products = "src=images/NORWAY_02.jpg";
$account = "src=images/NORWAY_03.jpg";
$shopcart = "src=images/NORWAY_04.jpg";
$checkout = "src=images/NORWAY_05.jpg";
$contacts = "src=images/NORWAY_06.jpg"; 
break;
case 4: $main = "src=images/FINNISH_01.jpg";
$products = "src=images/FINNISH_02.jpg";
$account = "src=images/FINNISH_03.jpg";
$shopcart = "src=images/FINNISH_04.jpg";
$checkout = "src=images/FINNISH_05.jpg";
$contacts = "src=images/FINNISH_06.jpg";
break;
}
?>

Now pass 1,2,3 or 4 as language id when you click the flags, change the identifier to lang instead of language.

Right now you pass ?language=fi for finnish but you check verses numbers in your switch statement.

basslion

I tried this code and it calls ENGLISH_#.jps's only regardless of what language is selected.

Any ideas?

Thanks for your help so far. 🙂

Matt

x01440

One thing I always do in any site I work on is if something like this isn't working, I print out the values of all variables in question and keep reloading the page with each option.

Looking at your site, you set a variable called "language" when you select a different language. For example, when you set finnish, the variable value is "fi". if you're using PHP 4 and below, you can just reference the value by referring to $language rather than $languages_id.

If you're using PHP 5, then you may need to use this code to get your language variable:

$languages_id = HTTP_GET_VARS ['language'];

This will also work for PHP 4. Add it in before your switch statement and see if it works.

basslion

this is what i changed

$languages_id = HTTP_GET_VARS ['language'];
switch ($languages_id){
case 1: $main = "src=images/ENGLISH_01.jpg";
$products = "src=images/ENGLISH_02.jpg";
$account = "src=images/ENGLISH_03.jpg";
$shopcart = "src=images/ENGLISH_04.jpg";
$checkout = "src=images/ENGLISH_05.jpg";
$contacts = "src=images/ENGLISH_06.jpg";
break;
case 2: $main = "src=images/SVENSKA_01.jpg";
$products = "src=images/SVENSKA_02.jpg";
$account = "src=images/SVENSKA_03.jpg";
$shopcart = "src=images/SVENSKA_04.jpg";
$checkout = "src=images/SVENSKA_05.jpg";
$contacts = "src=images/SVENSKA_06.jpg";
break;
case 3: $main = "src=images/NORWAY_01.jpg";
$products = "src=images/NORWAY_02.jpg";
$account = "src=images/NORWAY_03.jpg";
$shopcart = "src=images/NORWAY_04.jpg";
$checkout = "src=images/NORWAY_05.jpg";
$contacts = "src=images/NORWAY_06.jpg";
break;
case 4: $main = "src=images/FINNISH_01.jpg";
$products = "src=images/FINNISH_02.jpg";
$account = "src=images/FINNISH_03.jpg";
$shopcart = "src=images/FINNISH_04.jpg";
$checkout = "src=images/FINNISH_05.jpg";
$contacts = "src=images/FINNISH_06.jpg";
break;
}
?>
<td valign="middle"><a href=<?=tep_href_link('index.php')?>><img <?= $main;?> alt="" width="100" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('products_new.php')?>><img <?= $products;?> alt="" width="89" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('account.php')?>><img <?= $account;?> alt="" width="90" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('shopping_cart.php')?>><img <?= $shopcart;?> alt="" width="90" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('checkout_shipping.php')?>><img <?= $checkout;?> alt="" width="91" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('contact_us.php')?>><img <?= $contacts;?> alt="" width="105" height="32" border="0" /></a></td>
</tr>
</table></td>

This brings up this error....

Parse error: syntax error, unexpected '[' in /usr/home/web25773/domains/idkort.nu/public_html/includes/header.php on line 82

Line 82 is the line you told me to change.

Thanks for assisting..

Matt

Weedpacket

The poster made a typos. That line was supposed to be

$languages_id = $HTTP_GET_VARS['language'];

Incidentally, $HTTP_GET_VARS is deprecated in favour of $_GET. And best practices recommends <?php and <?php echo instead of <? and <?=.)

x01440

The last poster is correct, I forgot the dollar sign before $HTTP_GET_VARS.

Weedpacket is also correct that the PHP 5 standard should use $_GET in place of $HTTP_GET_VARS, but either one will work.

basslion

Thank you very much you guys. Unfortunately it still is not calling the images for some reason. Now with the new code added, it doesnt call any images.

Here is the code as i adjusted it.

<?php
$languages_id = $HTTP_GET_VARS['language'];
switch ($languages_id){
case 1: $main = "src=images/ENGLISH_01.jpg";
$products = "src=images/ENGLISH_02.jpg";
$account = "src=images/ENGLISH_03.jpg";
$shopcart = "src=images/ENGLISH_04.jpg";
$checkout = "src=images/ENGLISH_05.jpg";
$contacts = "src=images/ENGLISH_06.jpg";
break;
case 2: $main = "src=images/SVENSKA_01.jpg";
$products = "src=images/SVENSKA_02.jpg";
$account = "src=images/SVENSKA_03.jpg";
$shopcart = "src=images/SVENSKA_04.jpg";
$checkout = "src=images/SVENSKA_05.jpg";
$contacts = "src=images/SVENSKA_06.jpg";
break;
case 3: $main = "src=images/NORWAY_01.jpg";
$products = "src=images/NORWAY_02.jpg";
$account = "src=images/NORWAY_03.jpg";
$shopcart = "src=images/NORWAY_04.jpg";
$checkout = "src=images/NORWAY_05.jpg";
$contacts = "src=images/NORWAY_06.jpg";
break;
case 4: $main = "src=images/FINNISH_01.jpg";
$products = "src=images/FINNISH_02.jpg";
$account = "src=images/FINNISH_03.jpg";
$shopcart = "src=images/FINNISH_04.jpg";
$checkout = "src=images/FINNISH_05.jpg";
$contacts = "src=images/FINNISH_06.jpg";
break;
}
?>
<td valign="middle"><a href=<?=tep_href_link('index.php')?>><img <?= $main;?> alt="" width="100" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('products_new.php')?>><img <?= $products;?> alt="" width="89" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('account.php')?>><img <?= $account;?> alt="" width="90" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('shopping_cart.php')?>><img <?= $shopcart;?> alt="" width="90" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('checkout_shipping.php')?>><img <?= $checkout;?> alt="" width="91" height="32" border="0" /></a></td>
<td valign="middle"><a href=<?=tep_href_link('contact_us.php')?>><img <?= $contacts;?> alt="" width="105" height="32" border="0" /></a></td>

Any other ideas why this isnt working for me?

Regards,

Matt

x01440

Yes, I know why. Your case statement is looking for 1, 2, 3. Your web site gives $languages_id values of "en", "fi", and "sv". Change the case statement to look for these values and it should work.

basslion

Ok i will try that. The person who taught me this code used it for the same storefront software though and i did it exactly as he has it done, although i am using more cases.

Here is his tutorial video, short and you have to right click and magnify(zoom) to get a better view of what hes doing.

Language Change Tutorial Flash

Ill let you know how i make out.

Matt

ClarkF1

It might be a case of missing curly braces with the switch statement.....it'll only run the first line like missing them in an if statement.

Try

<?php
$languages_id = $HTTP_GET_VARS['language'];
switch ($languages_id){
case 1: 
{
$main = "src=images/ENGLISH_01.jpg";
$products = "src=images/ENGLISH_02.jpg";
$account = "src=images/ENGLISH_03.jpg";
$shopcart = "src=images/ENGLISH_04.jpg";
$checkout = "src=images/ENGLISH_05.jpg";
$contacts = "src=images/ENGLISH_06.jpg";
break;
}
case 2: 
{
$main = "src=images/SVENSKA_01.jpg";
$products = "src=images/SVENSKA_02.jpg";
$account = "src=images/SVENSKA_03.jpg";
$shopcart = "src=images/SVENSKA_04.jpg";
$checkout = "src=images/SVENSKA_05.jpg";
$contacts = "src=images/SVENSKA_06.jpg";
break;
}
case 3: 
{
$main = "src=images/NORWAY_01.jpg";
$products = "src=images/NORWAY_02.jpg";
$account = "src=images/NORWAY_03.jpg";
$shopcart = "src=images/NORWAY_04.jpg";
$checkout = "src=images/NORWAY_05.jpg";
$contacts = "src=images/NORWAY_06.jpg";
break;
}
case 4: 
{
$main = "src=images/FINNISH_01.jpg";
$products = "src=images/FINNISH_02.jpg";
$account = "src=images/FINNISH_03.jpg";
$shopcart = "src=images/FINNISH_04.jpg";
$checkout = "src=images/FINNISH_05.jpg";
$contacts = "src=images/FINNISH_06.jpg";
break;
}
}

Weedpacket

ClarkF1 wrote:
It might be a case of missing curly braces with the switch statement.....it'll only run the first line like missing them in an if statement.

It's not.

basslion

x01440 wrote:
Yes, I know why. Your case statement is looking for 1, 2, 3. Your web site gives $languages_id values of "en", "fi", and "sv". Change the case statement to look for these values and it should work.

Ok so for case 1, should put case en or case "en" ?

Matt

ClarkF1

It's a string so, case "en":

basslion

Ok i used the en, sv and fi and it has worked. However if you just type in the URL and load the main page it doesnt load any menu buttons. When i press on the language flag , it then calls the menu buttons for each language. If i click on one of the menu buttons, the new page comes up and the menu buttons then disappear.

Still confused, but making progress!!

Thanks guys for the great help!

Any other ideas?

Here is the website url Website URL Click here

Matt

basslion

Ok it seems the code for HTTP_GET VARS means its looking in the url for the language and then displaying images based on this. So if the page is loaded without the language id in it then the images will not appear.

Hrmm.

Matt

basslion

in each language file (english, svenska, finnish, norwegian) there are defines as follows

define('HEADER_TITLE_CREATE_ACCOUNT', 'Create an Account');
define('HEADER_TITLE_MY_ACCOUNT', 'My Account');
define('HEADER_TITLE_CART_CONTENTS', 'Cart Contents');
define('HEADER_TITLE_CHECKOUT', 'Checkout');
define('HEADER_TITLE_TOP', 'Top');
define('HEADER_TITLE_CATALOG', 'Catalog');
define('HEADER_TITLE_LOGOFF', 'Log Off');
define('HEADER_TITLE_LOGIN', 'Log In');

if i changed the defines to say define('HEADER_INDEX','ENGLISH_01.JPG');

would this call the image and put it in place?

and for the html i can have...

<a href=<?=tep_href_link('index.php')?>><img <?= HEADER_INDEX;?> alt="" width="100" height="32" border="0" /></a>

not sure if im making sense.

Matt

Weedpacket

Not quite; you'd need to put the url inside the img tag's src= attribute.