[RESOLVED] undefined function, but I thought it was defined

schwim

Hi there guys,

Sorry for the ignorant question, but I'm trying to get someone elses' code working.

I run a PostNuke site, and the old theme system does not support shutting down blocks on certain modules, and I really need the ability to get rid of the right side blocks on the forum and gallery, so I went to the PostNuke community forum(term used loosely), and posed the question. After a couple of clarifications, the guy helping came up with this code, but it gives me an error, and I was wondering if anyone could help out with why it's failing, as it seems I've gotten all the help I'm going to from the PN community:

function themefooter()
{
    list ($module, $name) = pnVarCleanFromInput('module', 'name');
    if (!($name("PNphpBB2")) and !($name("gallery"))) {
       echo "</td>
              <td>  </td>
              <td valign=\"top\" style=\"width:150px;background-color:$GLOBALS[bgcolor1]\">";
       blocks('right');
    }
    echo "</td>

</tr></table>
      </td></tr></table>
      <div style=\"text-align:center\">";
footmsg();
echo "</div>";
}

error:

Fatal error: Call to undefined function: () in /path/to/public_html/themes/ExtraLite/theme.php on line 126

line 126:

if (!($name("PNphpBB2")) and !($name("gallery"))) {

See any glaring problems with the code?

thanks,
json

esukf

$name is a variable but in the if statement you using it like a function $name().

Check what values is return by the pnVarCleanFromInput() function. Try something like

if (!($name=="PNphpBB2") and !($name=="gallery")) { //correction

schwim

Hi there,

Thanks very much! That got rid of the error, but I still have a problem. No matter what value is passed through the url, if I echo $name, I get "PNphpBB2".

For instance: URL is http://www.domain.com/index.php?name=Downloads

I use the following code:

function themefooter()
{
    $name = $_GET['name'];
    //list ($module, $name) = pnVarCleanFromInput('module', 'name');
    if (!($name="PNphpBB2") and !($name="gallery")) {
    	      echo "</td>
              <td>  </td>
              <td valign=\"top\" style=\"width:150px;background-color:$GLOBALS[bgcolor1]\">";
       blocks('right');
    }
    echo "</td>

</tr></table>
      </td></tr></table>
      <div style=\"text-align:center\">";
footmsg();
echo $name;
echo "</div>";
}

(Note that I added the $name definition in hopes to fix the problem, which didn't work)

If I echo name in the footer, I get: "PNphpBB2".

Is there any way to force the function to use what's passed in the URL? obviously name is getting redefined somewhere else in the page.

thanks,
json

Installer

One equal sign assigns value. Two or three are used for comparison.

if (!($name == "PNphpBB2") && !($name == "gallery"))

Comparison Operators

esukf

oops my mistake.

schwim

totally awesome guys. It seems to be working.

Thanks so much to the both of you for your help!

thanks,
json