[RESOLVED] If Else statement, help required

[dcjones]

Hi all,

I have a script which tests for the content of a variable and depending on the result executes 1 or 2.

<?php
if (empty($vat_number)); {
?>
<td colspan="2" class="bookingformrowbg"><input type="text" readonly name="vat_number" class="coursetext"  size="15" >
<?php
} else {
?>
<td colspan="2" class="bookingformrowbg"><input type="text" readonly name="vat_number" class="coursetext" value="<?php echo $_POST['vat_number']; ?>" size="15" >
<?php
}
?>

This gives the folloing error.

Parse error: parse error, unexpected T_ELSE in ,blah blah blah

Can anyone see what is wrong with my code.

[cahva]

Take out the ; from if.

[dcjones]

Hi Cahva and thanks for your reply.

I have had to recode the page I am working for a few reasons which I will not go in to now. But I have stumbled on another error;

<?php
if ($country == 'United Kingdom'){
echo money_format('%.2n',$vat_total = $course_sub_total * 17.5 /100);
}
elseif (empty($vat_number)  && ($country = "Austria" || "Belgium" || "Cyprus"
|| "Czech Republic" || "Denmark" || "Estonia" || "Finland" || "France"
|| "Germany" || "Greece" || "Hungary" || "Ireland" || "Italy"
|| "Latvia" || "Lithuania" || "Luxembourg" || "Malta" || "Netherlands"
|| "Poland" || "Portugal" || "Slovakia" || "Slovenia" || "Spain" || "Sweden")){
echo echo money_format('%.2n',$vat_total = $course_sub_total * 17.5 /100);
}
elseif ($vat_number > 4) &&  ($country = "Austria" || "Belgium" || "Cyprus"
|| "Czech Republic" || "Denmark" || "Estonia" || "Finland" || "France"
|| "Germany" || "Greece" || "Hungary" || "Ireland" || "Italy"
|| "Latvia" || "Lithuania" || "Luxembourg" || "Malta" || "Netherlands"
|| "Poland" || "Portugal" || "Slovakia" || "Slovenia" || "Spain" || "Sweden")){
echo money_format('%.2n',$vat_total = 0);
}
else
{
echo money_format('%.2n',$vat_total = 0);
}
?>

It is showing this error:

Parse error: parse error, unexpected T_ECHO, expecting ',' or ';' on line 501.

Line 501 is the second instance of

echo echo money_format('%.2n',$vat_total = $course_sub_total * 17.5 /100);

Can you see where I have gone wrong.

Many thanks again.

[NogDog]

You have two consecutive echo's, so you need to get rid of one of them:

[color=red][b]echo echo[/b][/color] money_format(.......);

[ClarkF1]

Rather than type out that list of countries each time, wouldn't it be easier to put them in an array and then use in_array()

That way if the list changes, you only have to change it once, not each occurrence in the code

[NogDog]

PS: Your eleseif statements are not going to work as expected.

elseif (empty($vat_number)  && ($country = "Austria" || "Belgium" || "Cyprus" || <etc.....>)

$country = "Austria" is assigning the value "Austria" to the variable $country, not comparing them. (You need to use "==" or "===" for comparison.) Also, the country names by themselves between the "||" operators are not compared to anything, so will all evaluate to true (since they do not equal 0, an empty string or the constant FALSE). You need to either do something like...

elseif (empty($vat_number)  && ($country == "Austria" || $country == "Belgium" ||
   $country == "Cyprus")) {

...or...

elseif (empty($vat_number)  && (in_array($country, array("Austria", "Belgium", "Cyprus")))) {

[dcjones]

Hi NogDog and all.

Many thanks for all your help and input, the script now works great.

<?php
if ($country == 'United Kingdom'){
echo money_format('%.2n',$vat_total = $course_sub_total * 17.5 /100);
}
elseif (empty($vat_number)  && (in_array($country, array("Austria", "Belgium", "Cyprus",
"Czech Republic", "Denmark", "Estonia", "Finland", "France", "Germany", "Greece",
"Hungary", "Ireland", "Italy", "Latvia", "Lithuania", "Luxembourg", "Malta",
"Netherlands", "Poland", "Portugal", "Slovakia", "Slovenia", "Spain", "Sweden")))){
echo money_format('%.2n',$vat_total = $course_sub_total * 17.5 /100);
}
elseif (empty($vat_number)  && (in_array($country, array("Austria", "Belgium", "Cyprus",
"Czech Republic", "Denmark", "Estonia", "Finland", "France", "Germany", "Greece",
"Hungary", "Ireland", "Italy", "Latvia", "Lithuania", "Luxembourg", "Malta",
"Netherlands", "Poland", "Portugal", "Slovakia", "Slovenia", "Spain", "Sweden")))){
echo money_format('%.2n',$vat_total = 0);
}
else
{
echo money_format('%.2n',$vat_total = 0);
}
?>

Many thanks again.