I need help with code!!

c1000mg

Hi, everyone

I'm trying to learn PHP and i was trying to make a code and my logic is very poor... as good as my english that's why I hope I can eplain what i need.

well I have 2 variables ($XXmin and $XXmax) and I want to define a value to the range of this 2 variable values... i have

1 to 3 = very soft
4 to 8 = soft
9 to 12 = medium hard
13- 18 = hard
19 and up = very hard

and in case that the range goes from 1 to 15 I like to say "very soft to hard" and also the variables can be the same number ill like to print or echo the value for that range(ex. hard).
can someone help me with the code logic for this please 🙂
Than you all

scrupul0us

<?php
$firmness = ""; //choose firmness
$rating = "";   //new variable

//logic
if ($firmness <= 3){$rating = "Very Soft";}
elseif ($firmness <= 8 && $firmness >= 4){$rating = "Soft";}
elseif ($firmness <= 12 && $firmness >= 9){$rating = "Medium Hard";}
elseif ($firmness <= 18 && $firmness >= 13){$rating = "Hard";}
elseif ($firmness >= 19){$rating = "Very Hard";}

//output
echo $rating;
?>

c1000mg

Thank you scrupul0us !!! you help me a lot...

I use your code and modified to what I need, now I'm wondering if is a way to simplified this code, this code does what i need:

<?php
$XXmin = 9;  //Minimun Value
$XXmax = 19; //Maximun Value
$ratingmin = "";  

$ratingmax = "";  

// This is to check if the range is right Just to show in the page
echo "1 to 3 = very soft <br>";
echo "4 to 8 = soft <br>";
echo "9 to 12 = medium hard <br>";
echo "13 to 18 = hard <br>";
echo "19 and up = very hard <br><br>";
echo "the range is $XXmin to $XXmax<BR><BR>";

//logic added the second variable
if ($XXmin <= 3){$ratingmin = "Very Soft";}
elseif ($XXmin <= 8 && $XXmin >= 4){$ratingmin = "Soft";}
elseif ($XXmin <= 12 && $XXmin >= 9){$ratingmin = "Medium Hard";}
elseif ($XXmin <= 18 && $XXmin >= 13){$ratingmin = "Hard";}
elseif ($XXmin >= 19){$ratingmin = "Very Hard";}

if ($XXmax <= 3){$ratingmax = "Very Soft";}
elseif ($XXmax <= 8 && $XXmax >= 4){$ratingmax = "Soft";}
elseif ($XXmax <= 12 && $XXmax >= 9){$ratingmax = "Medium Hard";}
elseif ($XXmax <= 18 && $XXmax >= 13){$ratingmax = "Hard";}
elseif ($XXmax >= 19){$ratingmax = "Very Hard";}
//output
if ($ratingmin == $ratingmax)
{
echo "<b>$ratingmin</b>";
}
else {
echo "<b>$ratingmin - $ratingmax</b>";
}
?>

Now I'm trying to simplified the code!!!

Weedpacket

You can simplify it quite a lot once you realise that if $XXmin is not <= 3 then it must be >=4 (assuming that $XXmin is an integer).

if ($XXmin <= 3){$ratingmin = "Very Soft";}
elseif ($XXmin <= 8){$ratingmin = "Soft";}
elseif ($XXmin <= 12){$ratingmin = "Medium Hard";}
elseif ($XXmin <= 18){$ratingmin = "Hard";}
else {$ratingmin = "Very Hard";}

Then you can look at using an array to store the thresholds.

$rating_thresholds = array(3=>'Very Soft',8=>'Soft',12=>'Medium Hard',18=>'Hard'/*,19=>'Very Hard'*/); // We don't actually need the last one
$rating = 'Very Hard'; // We'll assume this unless we discover otherwise
foreach($rating_thresholds as $threshold=>$rating)
{
    if($XXmin<=$threshold)
    {
        $ratingmin = $rating;
        break;
    }
}

And of course the same code could be used twice - either by making $XXmin and $XXmax into an array, and $ratingmin and $ratingmax into another array; or just by putting that code in a function and calling it.

function XX_to_rating($xx)
{
    $rating_thresholds = array(3=>'Very Soft',8=>'Soft',12=>'Medium Hard',18=>'Hard'/*,19=>'Very Hard'*/); // We don't actually need the last one
    foreach($rating_thresholds as $threshold=>$rating)
    {
        if($xx<=$threshold)
        {
            return $rating;
        }
    }
    return 'Very Hard';
}


$ratingmin = XX_to_rating($XXmin);
$ratingmax = XX_to_rating($XXmax);

And, incidentally, that is a pretty dumb subject line you have there. Of the words you use, "I" is redundant, "help" is redundant, "code" is redundant, and "need" is only to be expected. The second "!" is redundant, and the first "!" is pretty much implied by the use of the word "need". That leaves "with" as your entire subject, which is totally content-free. A subject line is supposed to be a line summarising the subject of the post. Just so you'll know for next time.