Help w/ some code plz.

ubatch

Ok, so the following code isn't working correctly. Before I added the switch in there, it worked fine, but now I was trying to get a menu going by following a simple tutorial. Sometime went wrong...=)

http://www.ballwinbaptist.com/college/Test - this is the website I am working on so you can see it and how it displays.

http://www.digital-web.com/articles/easypeasy_php/ - this is the website tutorial I was following.

<html> 
<head> 
<title>Simple PHP page</title> 
</head> 
<body>
<?php 
ob_start("ob_gzhandler"); 
?>
<?php include ("header.php"); ?>
<?php include ("navigation.php"); ?>
<?php switch($id) 
{ 
case ’intro’: 
 include ’intro.php’; 
 break; 
case ’bluetruck’: 
 include ’bluetruck.php’; 
 break; 
case ’redhouse’: 
 include ’redhouse.php’; 
 break; 
case ’brownbear’: 
 include ’brownbear.php’; 
 break; 
default: 
 require ’intro.php’; 
} 
?>
<?php include ("footer.php"); ?>
</body> 
</html>

Any help would be awsome - Thanks!

Piranha

Do you get any error messages? If you do then please post them here, otherwise it is hard to know what the problem is.

As far as I can see there may be several problems:
1. My guess would be that $id is not set anywhere and that may cause the problem. try "echo $id" before the switch to see if it is set.
2. It may be a problem that you don't have a break in the default case. Just add it, even if it is not nessecary it is not bad to have it there.
3. Or it may be a problem with one of the included files. To test this try to run it without using the switch.

ubatch

Piranha wrote:
Do you get any error messages? If you do then please post them here, otherwise it is hard to know what the problem is.

As far as I can see there may be several problems:
1. My guess would be that $id is not set anywhere and that may cause the problem. try "echo $id" before the switch to see if it is set.
2. It may be a problem that you don't have a break in the default case. Just add it, even if it is not nessecary it is not bad to have it there.
3. Or it may be a problem with one of the included files. To test this try to run it without using the switch.

Ok, I couldn't figre out how to do the echo...But, I took out the switch and the code works fine now....Can you walk me through linking (with a switch me thinks) to intro.php, redhouse.php, brownbear.php and bluetruck.php - with intro.php being default.

Thanks!

This is my new index.php file (without switch)

<html>
<head>
<title>FUSION | Ballwin Baptist Church</title>
</head>
<body>
<?php
ob_start("ob_gzhandler");
?>
<?php include ("header.php"); ?>
<?php include ("navigation.php"); ?>
<?php include ("footer.php"); ?>
</body>
</html>

I figure something was wrong with my switch, but I don't k now what...Also, this is my navigation.php file just for kicks.

<ul> 
<li><a href="index.php?id=intro" title="Page intro">Intro</a></li> 
<li><a href="index.php?id=bluetruck" title="Blue Truck">Blue Truck</a></li> 
<li><a href="index.php?id=redhouse" title="Red House">Red House</a></li> 
<li><a href="index.php?id=brownbear" title="Brown Bear">Brown Bear</a></li> 
</ul>

And also one of my files (intro.php)

<?php include ("navigation.php"); ?>
<p>This is a simple demonstration of PHP includes and switch conditionals</p>

Piranha

First the echo, it is just to type

echo $id;

inside a php-part of the page.

Second I ment to include the pages one at a time. But I think that I found one problem. Look at the rows below and you will find it yourself:

include ("navigation.php");    // Works
include ’bluetruck.php’;   // Does not work

ubatch

Ok, I added

<?php echo $id; ?>

bewtween the navigation/footer.php stuff in index.php.

This seemed to work, as it changed the $id every time I clicked on a new link w/ the navigation links.

Check out the link again, http://www.ballwinbaptist.com/college/Test

I'll post some more results in a minute when I test out the new switch, i'm going to change the include statements like you told me - or suggested rather.

ubatch

Ok, this may seem stupid...But, here's what I changed my code to.

<html>
<head>
<title>FUSION | Ballwin Baptist Church</title>
</head>
<body>
<?php
ob_start("ob_gzhandler");
?>
<?php include ("header.php"); ?>
<?php include ("navigation.php"); ?>
<?php echo $id; ?>
<?php switch($id)
{
case 'intro':
 include 'intro.php';
 break; 
case 'bluetruck':
 include 'bluetruck.php';
 break;
case 'redhouse':
 include 'redhouse.php';
 break;
case 'brownbear':
 include 'brownbear.php';
 break;
default:
 require 'intro.php';
}
?>
<?php include ('footer.php'); ?>
</body>
</html>

Check out the this old switch I had...

<?php switch($id)
{
case ’intro’:
 include ’intro.php’;
 break; 
case ’bluetruck’:
 include ’bluetruck.php’;
 break;
case ’redhouse’:
 include ’redhouse.php’;
 break;
case ’brownbear’:
 include ’brownbear.php’;
 break;
default:
 require ’intro.php’;
}
?>

Well, if you can notice a VERY SLIGHT difference, you win. The old one has in it, while the new ones have ' in it. That's a single quote instead of an apostrophe (or whatever the deal is next to the 1 on your keyboard). I don't know why the author of my tutorial would use and not '...but, they did, and that was screwing the code up I guess.

Let me know if you can help me in any other ways...I don't think so since I got it working, but thanks for your help. It is appreciated.

robche

glad its working. you might want to consider using:

$GET['id'] instead of just $id for future GET vars though

ubatch

How would I go about switching the code to that $_GET? Please explain =)

Piranha

you can read about the predefined variable in the link: http://us2.php.net/variables.predefined

ubatch

Thank you! I appreciate the support on this issue guys, I AM a newbie after all 🙂