[RESOLVED] Form Submission Problem

eckostar

Hey everyone, I will be honest that I am still fairly new to PHP and what not, but I have been having some major issues trying to get my script to properly when trying to do a form submission...here is the code that I have done so far, but just not sure where i am going wrong....

<?php

$EmailFrom = Trim(stripslashes($_POST['EmailFrom'])); 
$EmailTo = "someone@somesite.com";
$Subject = "Web-site Contact";
$FirstName = Trim(stripslashes($_POST['FirstName'])); 
$LastName = Trim(stripslashes($_POST['LastName'])); 
$Company = Trim(stripslashes($_POST['Company'])); 
$Phone = Trim(stripslashes($_POST['Phone'])); 
$Fax = Trim(stripslashes($_POST['Fax']));  

$Comments = Trim(stripslashes($_POST['Comments'])); 

// validation
$validationOK=true;
if (Trim($FirstName)=="") $validationOK=false;
if (Trim($LastName)=="") $validationOK=false;
if (Trim($Company)=="") $validationOK=false;
if (Trim($EmailFrom)=="") $validationOK=false;
if (Trim($Phone)=="") $validationOK=false;
if (Trim($Fax)=="") $validationOK=false;
if (Trim($Comments)=="") $validationOK=false;
if (!$validationOK) {
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
  exit;
}

//email body text
$Body = "";
$Body .= "FirstName: ";
$Body .= $FirstName;
$Body .= "\n";
$Body .= "LastName: ";
$Body .= $LastName;
$Body .= "\n";
$Body .= "Company: ";
$Body .= $Company;
$Body .= "\n";
$Body .= "Phone: ";
$Body .= $Phone;
$Body .= "\n";
$Body .= "Fax: ";
$Body .= $Fax;
$Body .= "\n";
$Body .= "Comments: ";
$Body .= $Comments;
$Body .= "\n";

// send email 
$success = mail($EmailTo, $Subject, $Body);

// redirect 
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact.html\">";
}
else{
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
}
?>

Each time the form is submitted it always sends the user to the error page that I have defined no matter what is going on with the actual form... here is the html I have just to make sure...

<form id="ctact" name="ctact" method="Post" action="frm_submit.php">
<div align="center">
<table width="100%" cellspacing="0" cellpadding="0">
  <tr>
    <td class="adv_ctact"><p>First Name*:</p></td>
    <td><div align="left">
      <input name="FirstName" type="text" id="FirstName" height="17px" size="20" maxlength="20" />    

    </div></td>
  </tr>
	<tr>
	<td class="adv_ctact"><p>Last Name*:</p></td>
	<td><div align="left">
	  <input name="LastName" type="text" id="LastName" height="17px" size="20" maxlength="20" />
	  </div></td>
	</tr>
	<tr>
	<td class="adv_ctact"><p>Company*:</p></td>
	<td><div align="left">
	  <input name="Company" type="text" id="Company" height="17px" size="20" maxlength="40" />
	  </div></td>
	</tr>
	<tr>
	<td class="adv_ctact"><p>E-mail*:<br />
	</p></td>
	<td><div align="left">
	  <input name="EmailFrom" type="text" id="EmailFrom" height="17px" size="20" maxlength="60" />
	  </div></td>
	</tr>
	<tr>
	<td class="adv_ctact"><p>Phone*:</p></td>
	<td><div align="left">
	  <input name="Phone" type="text" id="Phone" height="17px" size="20" maxlength="20" />
	  </div></td>
	</tr>
	<tr>
	<td class="adv_ctact"><p>Fax*:</p>      </td>
	<td><div align="left">
	  <input name="Fax" type="text" id="Fax" height="17px" size="20" maxlength="20" />
	  </div></td>
	</tr>
	<tr>
	<td>&nbsp;</td>
	<td><div align="left"></div></td>
	</tr>
	<tr>
	<td class="adv_ctact"><p>Comments*:</p></td>
	<td><div align="left">
	  <textarea name="Comments" cols="40" rows="10" id="Comments" height="17px"></textarea>
	  </div></td>
	</tr>
	<tr>
	  <td colspan="2" class="adv_ftr">All fields marked with an asterisk are required.</td>
	  </tr>
	<tr>
	  <td colspan="2"><div align="center">
	    <input type="submit" name="Submit" value="submit"/> <input type="reset" name="Reset" value="reset" /> 
	    </div></td>
	  </tr>
</table>
</div></form>

Any help would be greatly appreciated.

NogDog

My guess is you need to add a From address to the additional headers. See Example 2 on the mail manual page for setting up the additional headers parameter with the From, Reply-To, and X-Mailer headers.

Also, to make sure you're seeing all error messages, you might want to start the script with:

ini_set("display_errors", 1);
error_reporting(E_ALL);

eckostar

Thanks NogDog, but even when I use my additional headers like

"From: <$EmailFrom>"

it does nothing...I added the error display as you said, but I am not really getting anything from it yet cause I am not too sure as to how to get it to display correctly yet...as I said I am still new for the most part when it comes to php... but at least I have my php5 unleashed book to keep me company 🙂.

NogDog

Don't put the angle brackets around the From email: just have it be a basic email address ("name@somewhere.com" sort of thing).

NogDog

PS: For now while initially developing the code, you might want to add some error reporting to help find bugs. Later when things are working you might want to change it to output more user-friendly errors or such. For instance:

<?php
// start debug -- make these the very first lines of the script:
ini_set("dispaly_errors", 1);
error_reporting(E_ALL);
// end debug

// ... later on ...
if (!$validationOK) {
  // start debug
  die("Form validation failed");
  // end debug
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
  exit;
}

// ... and later ...
// redirect
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact.html\">";
}
else{
  // start debug
  die("Mail function failed");
  // end debug
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
}

This way, if there's a failure at either of those points in the code, you'll know exactly where it failed, and then can focus your debugging on that portion of the code.

eckostar

Thanks, but for some reason all I am getting now is the Mail Func. Failed error that you added. Here is the revised code that I have come up with even after adding the additional headers as stated on the PHP mail Manual...Am I just overlooking something extremely simple here? I mean I checked my HTML page, and every variable that I am trying to 'post' to the php file is correct.

<?php

ini_set("dispaly_errors", 1);
error_reporting(E_ALL); 

$EmailFrom = Trim(stripslashes($_POST['EmailFrom'])); 
$EmailTo = 'someone@somesite.com';
$Subject = 'Web-site Contact';
$FirstName = Trim(stripslashes($_POST['FirstName'])); 
$LastName = Trim(stripslashes($_POST['LastName'])); 
$Company = Trim(stripslashes($_POST['Company'])); 
$Phone = Trim(stripslashes($_POST['Phone'])); 
$Fax = Trim(stripslashes($_POST['Fax']));  

$Comments = Trim(stripslashes($_POST['Comments'])); 
$Header = 'From: $EmailFrom' . "\r\n" . 'Reply-To: $EmailFrom' . "\r\n" . 'X-Mailer: PHP/' . phpversion();

// validation
$validationOK=true;
if (Trim($FirstName)=="") $validationOK=false;
if (Trim($LastName)=="") $validationOK=false;
if (Trim($Company)=="") $validationOK=false;
if (Trim($EmailFrom)=="") $validationOK=false;
if (Trim($Phone)=="") $validationOK=false;
if (Trim($Fax)=="") $validationOK=false;
if (Trim($Comments)=="") $validationOK=false;
if (!$validationOK) {
  // start debug
  die("Form validation failed");
  // end debug
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
  exit;
}

//email body text
$Body = "";
$Body .= "FirstName: ";
$Body .= $FirstName;
$Body .= "\n";
$Body .= "LastName: ";
$Body .= $LastName;
$Body .= "\n";
$Body .= "Company: ";
$Body .= $Company;
$Body .= "\n";
$Body .= "Phone: ";
$Body .= $Phone;
$Body .= "\n";
$Body .= "Fax: ";
$Body .= $Fax;
$Body .= "\n";
$Body .= "Comments: ";
$Body .= $Comments;
$Body .= "\n";

// send email 
$success = mail ($EmailTo, $Subject, $Body, $Header);

// redirect 
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact.html\">";
}
else{
  // start debug
  die("Mail function failed");
  // end debug
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
}
?>

Thanks again for your help.

NogDog

Well, the good news is that we now know for sure the problem has something to do with the call to mail() (and not the form validation code).

What platform (Windows or UNIX/Linux) are you running this on? Have you gotten mail() to work on it yet in any other script?

To make sure things are what you think they are, you might want to output the variables used in the mail() call as part of your debug info.

eckostar

I am running a *nix box for my server. I am not quite sure of the version of PHP at this moment, but I will find that out and let you know. Now when you say to include my output variables as part of the debug information, do mean doing something like this:

// redirect 
if ($success){
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact.html\">";
}
else{
  echo $EmailTo . '<br>';
  echo $EmailFrom . '<br>';
  echo $Subject . '<br>';
  echo $Body . '<br>';
  // start debug
  die("Mail function failed");
  // end debug
  print "<meta http-equiv=\"refresh\" content=\"0;URL=ctact_err.html\">";
}

If so, here are the results that I get when doing so (after filling in the form obviously):

someone@somesite.com
earthling@soemsite.net
Web-site Contact
FirstName: Harry LastName: Henderson Company: Home Phone: 962-111-1234 Fax: 866-504-4545 Comments: This is all just a test.
Mail function failed

I am not quite sure if I have used the mail() function anywhere else in the past, as I have been using all sorts of pre-made scripts up until recently. I know that I have been using items such as phpBB2, SMF 1.0.7, but if i recall those all use sendmail or something along those lines correct?