Login Script: parsing flat file using list() and explode()

railer

Hi,

I'm just learning about how to use php and am trying to solve a problem with this part of my login script for checking a text file of members to see if the user name and password they entered into a login page exists and matches one of the records in a flat text file database.

Here's the part of the script that I'm stuck on:

$handler = fopen($filename,'r');
		$members = file($filename);
		// get username and password
		$users_array = explode ("\n",$members);

	foreach ($users_array as $users) {
		if ($users != "" || $users != NULL) {

			// break username and password string into seperate variables.
			list($firstname,$lastname,$city,$state,$country,$username,$password) = explode("\t",$users);

			if ($_POST["phpAuth_usr"] == trim($username) && md5($_POST["phpAuth_pwd"]) == trim($password)) {	

				$logged_in = 1;
				break;

			} else {

				$logged_in = 0;

			}

		} else {

			break;

		}

	} // end foreach

I tried to adapt this script from an existing script that originally only collected two pieces of info when members registered... username and password. I added the Firstname, Lastname, City, State, and Country items myself to the script that adds the user and it correctly adds the info the the flat file (see below). But now it doesn't work when the user tries to login. I suspect that it isn't able to parse through the flat file with the above code as currently written, even though it was able to do so when the only data in the flat file was the username and encrypted password. Here's a sample of a user record from the flat file database:

Jane	Smith	Anytown	CA	USA	jane	8822d2a2efe231fa6fce5b711df3dc7c

I have a feeling the problem lies between where I've used the list() and explode() functions AND where the script compares the username and password. Maybe it's something to do with the way list() handles the parameters. I don't know!

Any help in solving this is much appreciated.

Best,
Railer :queasy:

cahva

The reason why its not working is this:

$members = file($filename);
// get username and password
$users_array = explode ("\n",$members);

The $members is already an array so the explode is useless so you can left it off. With file() function you will get the lines separated allready.

$users_array = file($filename);

foreach ($users_array as $users) {
...

railer

cahva wrote:
The reason why its not working is this:
$members = file($filename);
// get username and password
$users_array = explode ("\n",$members);
The $members is already an array so the explode is useless so you can left it off. With file() function you will get the lines separated allready.
$users_array = file($filename);

foreach ($users_array as $users) {
...

Hi, thanks for your reply...
I'm not sure how to implement what you said. I tried commenting out


// get username and password
$users_array = explode ("\n",$members);

and that returned an error.

And then I commented out the other thing and that gave an error, too.

All I need to do is authenticate the user so he/she can login, but the code won't execute. The only thing I changed was to add the other five variables to the list() function. The original worked fine with the two functions you said were the problem. I'm stuck.

Thanks,
Railer

Installer

After commenting out this line:

$users_array = explode ("\n",$members);

did you change this line:

$members = file($filename);

$users_array = file($filename);

Other than that, your code will work fine if your text file is as you describe.

Also, you don't need this line (at least not for this portion of your script):

$handler = fopen($filename,'r');

This line

if ($users != "" || $users != NULL) {

should logically be

if ($users != "" && $users != NULL) {

And it would help people to help you if, instead of "It doesn't work" you said in what way it doesn't work, and instead of "That gave an error" you said "I get this error: (paste in error message)".

HTH

railer

Hmmm, I just noticed that the testing server for my client is running PHP 4.2.2 and that version doensn't support the file_get_contents() function. The script runs fine on my server afterall. I also added the following to the above code:

foreach ($users_array as $users) {
			if ($users != "" || $users != NULL) {

			next($users);
			next($users);
			next($users);
			next($users);

Don't ask me what that does, or how I figured it out... ???!!!!
Railer

railer

Hi, just saw your reply. The error was, "call to undefined function file_get_contents()". Sorry 'bout that. I'm normally more thorough...

railer

PS: I spoke to the server admin for my client's server and they said they may upgrade PHP for me. I hope so! But what would be a workaround for the file_get_contents() function in the original code?

railer

Looks like I posted an aberrant version of the script above, here's what should've been there:

$handler = fopen($filename,'r');
		$members = file_get_contents($filename);
		// get username and password
		$users_array = explode ("\n",$members)'

So, maybe the accidental use of file() in the original example and the fix from Installer is the workaround for PHP 4.2.2? Cool! I'll try it out tomorrow. And thanks!

Railer