Will a function work in a Loop ?

[martincorby]

A very much novice PHP-er needs help.

I have a function that sits within a Loop, it doesn't seem to like it !

The function tests for a back link from a remote URL to a pre-determined target URL. The function works fine when asked to operate as a stand alone, but put it within a loop of results from the db and I cannot get it to work.

Here is the script. If you need to see the function details let me know.....

<?php
$sql = mysql_query("SELECT * FROM table ORDER BY url ");

while($row = mysql_fetch_array($sql)){

$linkbackaddress=$row['link_back_address'];
$str = substr($linkbackaddress, 1, 1);

//weed out those sites currently without a backlink address
if($str="h"){

if (check_back_link($linkbackaddress, "http://www.mydomain.co.uk")) {
echo $row['url'] . "&nbsp;LINK OK<BR>";
}else{
echo $row['url'] . "&nbsp;LINK BAD<BR>";
}

}else{
echo "No URL to check<BR>";
}
}
?>

Function code :

<?php

function check_back_link($remote_url, $your_link) {
$match_pattern = preg_quote(rtrim($your_link, "/"), "/");
$found = false;
if ($handle = @fopen($remote_url, "r")) {
while (!feof($handle)) {
$part = fread($handle, 1024);
if (preg_match("/<a(.)href=[\"']".$match_pattern.
"(\/?)\"'>(.)<\/a>/", $part)) {
$found = true;
break;
}
}
fclose($handle);
}
return $found;
}

?>

[thorpe]

but put it within a loop of results from the db and I cannot get it to work.

Chances are its working, just using allot of resources. What makes you think its not working?

[martincorby]

IE 7 gives this response !

"Internet Explorer cannot display the webpage"

[Rodney_H_]

First, I gotta plop your code in between the bbcode tags here to see what we are dealing with, and then I gotta format the code so I can RE#ALLY see it...

<?php
$sql = mysql_query("SELECT * FROM table ORDER BY url ");

while($row = mysql_fetch_array($sql))
{
	$linkbackaddress = $row['link_back_address'];

$str = substr($linkbackaddress, 1, 1);

//weed out those sites currently without a backlink address
if($str = "h")
{
	if (check_back_link($linkbackaddress, "http://www.mydomain.co.uk")) 
	{
		echo $row['url'] . "&nbsp;LINK OK<BR>";
	}
	else
	{
		echo $row['url'] . "&nbsp;LINK BAD<BR>";
	}

}
else
{
	echo "No URL to check<BR>";
}
}
?>

Hmmm...

Perhaps this line: if($str = "h")

Should be: if($str == "h")

??

Also, I don't see where you have connected to your DB. Are you 10% sure that that is cool??

'tweaked your function just a smidge... Hope you don't mind, seems a little cleaner this way...

<?php
function check_back_link($remote_url, $your_link) 
{
	$regex = preg_quote(rtrim($your_link, "/"), "/");

if($handle = @fopen($remote_url, "r")) 
{
	while (!feof($handle)) 
	{
		$part = fread($handle, 1024);

		if(preg_match("/<a(.*)href=[\"']".$regex ."(\/?)[\"'](.*)>(.*)<\/a>/", $part)) 
		{
			return true;
		}
	}
	fclose($handle);
}
return false;
}
?>

[martincorby]

Thanks for your contribution Rodney.

I have amended the school boy error "if($str == "h")" - thanks !

......and adjusted the function as per your post.....but still the problem persists.

When you try and load the script the page fails to work ?

[Rodney_H_]

EDIT: THis script DID run on my machine...

<?php
function check_back_link($remote_url, $your_link) 
{
	$match_pattern = preg_quote(rtrim($your_link, "/"), "/");

if($handle = @fopen($remote_url, "r")) 
{
	while (!feof($handle)) 
	{
		$part = fread($handle, 1024);

		if (preg_match("/<a(.*)href=[\"']".$match_pattern."(\/?)[\"'](.*)>(.*)<\/a>/", $part)) 
		{
			return true;
		}
	}
	fclose($handle);
}
return false;
}



$mysql = mysql_connect('localhost', 'USER', 'PASS') or die(mysql_error());

$db = mysql_select_db('test') or die(mysql_error());

$query = "SELECT `link_back_address`, `url`
		  FROM `table` 
		  WHERE `link_back_address` LIKE 'h%'
		  ORDER BY `url`";

$result = mysql_query($query) or die(mysql_error());

if(mysql_num_rows($result) == 0)
{
	echo 'There is nothing here!';
}

else
{
	while($row = mysql_fetch_array($result))
	{
		if (check_back_link($row['link_back_address'], "http://www.mydomain.co.uk")) 
		{
			echo $row['url'] . "&nbsp;LINK OK<BR>";
		}
		else
		{
			echo $row['url'] . "&nbsp;LINK BAD<BR>";
		}
	}
}

mysql_close();

?>