for loop?

[lukeurtnowski]

How do I correct this for loop to work?

for($x=1;$x<7;$x++){
	if (is_uploaded_file($_FILES['Image"$x"']['tmp_name']))
	{
	move_uploaded_file($Image$x,$uploaddir.'/'.$Name.'-'.$Image$x_name);
	$Photo$x = $Name.'-'.$Image$x_name;
	echo "<img src=".$uploadpath.$x" alt=".$Name." />";
	}
}

[Installer]

Something like this should work (except for $x_name and $Name, wherever they come from; as it is they will be overwritten on each iteration--you'll need to solve that):

for ($x = 1; $x < 7; $x++) { 
    if (is_uploaded_file($_FILES['Image' . $x]['tmp_name'])) { 
        move_uploaded_file($_FILES['Image' . $x]['tmp_name']), $uploaddir . '/' . $Name . '-' . ${'Image' . $x_name}); 
        ${'Photo' . $x} = $Name . '-' . ${'Image' . $x_name}; 
        echo '<img src="' . $uploadpath . $x . '" alt="' . $Name . '" />'; 
    } 
}

But you really should be using upload arrays for this. This page shows how.

[lukeurtnowski]

Well, ill try,
I have a Images[] (array).

<?php
$uploaddir = "images/ASP_Images";

foreach ($_FILES["Images"]["error"] as $key => $error) {
   if ($error == UPLOAD_ERR_OK) {
       echo"$error_codes[$error]";
       move_uploaded_file(
        $_FILES["Images"]["tmp_name"][$key],
        $uploaddir . '/' . $Name . '-' . $_FILES["Images"]["name"][$key]
       ) or die("Problems with upload");
   }
}
?>

Is that ok?
How then, would I create 6 seperate variabes (Photo1-6)
like this?

${'Photo' . $x} = $Name . '-' . ${'Image_name' . $x};

Thanks

[Installer]

That's good work!

You could change the foreach to a for loop and use the increment variable:

$uploaddir = "images/ASP_Images"; 
$Name = 'Something';

for ($f = 0; $f < count($_FILES["Images"]["error"]); $f++) { 
   if (($error = $_FILES["Images"]["error"][$f]) == UPLOAD_ERR_OK) {
       echo"$error_codes[$error]"; 
       ${'Photo' . $f} = $Name . '-' . ${'Image_name' . $x}; 
       move_uploaded_file($_FILES["Images"]["tmp_name"][$f], 
                          $uploaddir . '/' . $Name . '-' . ${'Photo' . $f})
           or die("Problems with upload");
   } 
}

But I would put the successful uploads into their own array, instead of numbered variables (Edit; Original code replaced):

$uploaddir = "images/ASP_Images"; 
$Name = 'Something';

foreach ($_FILES['Images']['error']) as $file_num => $error) { 
    if ($error == UPLOAD_ERR_OK) { 
        $photos[$file_num] = $_FILES['Images']['name'][$file_num]; 
        echo $photos[$file_num] . ' upload successful<br />'; 
        if (!move_uploaded_file($_FILES['Images']['tmp_name'][$file_num], 
                                $uploaddir . '/' . $Name . '-' . $uploaded_files[$file_num])) { 
            echo $photos[$file_num] . ' uploaded - move failed<br />';
        }
    } else { 
        echo 'Upload ' . $file_num . ' error: ' . $error_codes[$error] . '<br />';
    }
}

This is untested and maybe incomplete code, but I hope it helps.