Text to Link Regex, working with GET variables?

J_Fox

Hello,

I have the following code which I am using for text->link conversions:

function hyperlink($text)
{
  $text = preg_replace("#([\n ])([a-z]+?)://([^, \n\r]+)#i", "\\1<a href=\"\\2://\\3\" target=\"_blank\">\\2://\\3</a>", $text); // Link with http

$text = preg_replace("#([\n ])www\.([a-z0-9\-]+)\.([a-z0-9\-.\~]+)((?:/[^, \n\r]*)?)#i", "\\1<a href=\"http://www.\\2.\\3\\4\" target=\"_blank\">www.\\2.\\3\\4</a>", $text); // Link without http

$text = preg_replace("#([\n ])([a-z0-9\-_.]+?)@([^, \n\r]+)#i", "\\1<a href=\"mailto:\\2@\\3\">\\2@\\3</a>", $text); // E-mail
   return $text;
}

This works fine except for links with GET variables.

For example:
http://www.google.com [Works fine]
http://www.google.com?p=index [Only counts the link up to the ?]

What would be needed to remedy this to accept all links?

Thanks,
J.

buraks78

This should work as long as you do not have spaces inside the urls

function hyperlink($text){
	$text = preg_replace("#(http://[^\s]+)#i", "<a href='\\1' target='_blank' >\\1</a>",$text);
	$text = preg_replace("#(?<!(http://))(www.[^\s]+)#i", "<a href='http://\\2' target='_blank' >http://\\2</a>",$text); 
        $text = preg_replace("#([\n ])([a-z0-9\-_.]+?)@([^, \n\r]+)#i", "\\1<a href=\"mailto:\\2@\\3\">\\2@\\3</a>", $text); // E-mail 
	return $text;
}

HTH

J_Fox

Awesome -- Thanks!

One other question, is there a simple way to make it so links inside tags will not get switched?

For example:

<img src=www.google.com/image.jpg /> <--- Would not change
<img src=www.google.com/image.jpg> <--- Would not change
<img src="www.google.com/image.jpg" /> <--- Would not change
<img src="http://www.google.com/image.jpg"> <--- Would not change

Etc etc. Basically anything that should be left as a normal URL shouldn't be changed.

Thanks.

J_Fox

I've been playing around with two ideas, neither of which I can get to work.

1) Looking for a whitespace at the beginning of the string (to indicate it is a standalone link and not part of a tag or anything

2) Using the \b parameter to essentially replicate #1.

I cannot get either working correctly no matter where I put it. Any thoughts?