Values into array

zzz

This is elementary but I'm having a block!

I am trying to combine JavaScript snippet wtih my PHP code. As a final result i need to get the following array:

mytext[0]=""
mytext[1]="My text 1"
mytext[2]="Another text line"
mytext[3]="Yet one more"
mytext[4]="And another"

Now, I can run a loop and get the actual values in the string like:

foreach ($myString as $str) {		
$str = $pr->myvalues;
}

Having difficulties combining the two together...

zzz

deleted

zzz

Here's what I actually need to replace with dynamic code:

<script type="text/javascript">
var mytext=new Array()
mytext[0]="" 
mytext[1]="My text 1" 
mytext[2]="Another text line" 
mytext[3]="Yet one more" 
mytext[4]="And another" 
</script>

Here's what I do:

<script type="text/javascript">
var mytext=new Array()
foreach ($activeProjects as $prn) {
    echo 'mytext['.$i++.']="'.$str->myvalues.'"<br>';
}
</script>

I keep getting JS error that mytext is undefined...

Any suggestions?

bradgrafelman

Er... are you mixing PHP and JS wihtout any <?php ?> tags?

<script type="text/javascript">
var mytext = new Array();
<?php foreach($activeProjects aas $prn) {
    echo 'mytext[' . $i++ . ']="'.$str->myvalues."\"\n";
} ?>
</script>

Also changed your <br> to a literal line break.

zzz

Oh, no, no. I took the entire snippet from Echo block. My entire JS waws withing that echo string.

ghettopixel

Funny thing is, even the guy/gal who got mad because you made a mistake didnt even catch that $i is undefined and you are trying to add to it. And that you are using $i++ when you should better option to use $i+1 because its a foreach not a for. My next question is why does it look like that foreach is using something that isnt defined? Which yet again is something that you and your criticist should have noticed.

foreach ($myString as $str) {        

$str = $pr->myvalues;
}

You are just overwriting your definition, you defined each $mystring array value as $str array value and then turned $str into a caller for $pr which completly overwrote it pretty much. Why are you even using a foreach to do that?

My question is this and this will help us help you considering your code looks like its way out of wack.

Where is $str comming from and why do you need it? Where is $pr comming from and why do you need it? Is mytext for javascript or PHP? If its for PHP then where is the variable sign? If not then do something more logical.

Based on my assumptions you should try this:

<?PHP

// This script assumes $pr is the master array and $str is the dubbed array
// It also assumes the array keys are numerals

// Tell it that $str should be $pr for this script ;)
$str=$new=$pr;
// Make sure it worked sometimes kids don't listen you know how they are
if(($str!=$pr)) {
	$str=($pr);
}
print "<script type=\"text/javascript\">\n";
print "mytext = new Array();\n";
// You should take one off the total if its zero
// If you don't it will create an extra array in the JavaScript
$total=((TRUE==$str->myvalues[0])?(count($str->myvalues)-1):(count($str->myvalues)));
// If zero exists then set i to zero so it starts there
// If one is the first key then make sure it starts with 1
for(((TRUE==$str->myvalues[0])?($i=0):($i=1));($i<=$total);($i++)) {
	print "mytext[{$i}]=\"{$str->myvalues[$i]}\"\n";
} 
print "</script>\n";
?>

bradgrafelman

ghettopixel wrote:
And that you are using $i++ when you should better option to use $i+1 because its a foreach not a for

Why does it matter if you are using a for or a foreach loop?

Besides, $i+1 would skip the first value of $i, whereas $i++ would not.

ghettopixel

What happens if you forget to define $i because your in a hurry and you use $i++? You always get zeroed right? But if you forget to define $i and you use $i+1 then you always start with one and you don't get zeroed. Its a best practice to only use $i++ inside of a for loop (to me atleast because this is just a way of preventing bad coding) considering if you were using a foreach loop you wouldn't need i++ because it automatically loops through or you could be more logical and define key as thiskey especially if you are doing it from an automatic array created by PHP or you are simply rewriting the array with the same keys.

<?PHP
foreach($activeprojects as $key => $thiskey) {
	print "myvariable[{$thiskey}]=\"{$activeprojects[$thiskey]}\";";
}
?>

Now don't get me wrong, I am not saying you don't know how to code or you suck at it nore am I trying to be an ass, just trying to contribute 🙂

stevesweetland

i might be being completely dumb here.

this looks closest to being right.. apart from what seems to be confused ' and " marks.. but im baffed as to where your values are coming from....

<script type="text/javascript">
var mytext = new Array();
<?php foreach($activeProjects as $prn) {
    echo 'mytext[' . $i++ . ']="'.$str->myvalues."\"\n";
} ?>
</script>

what does $activeProjects actually contain?

i mean, if it contains the values to go in incremental parts of 'mytext' then why doesnt your code look something like this

<script type="text/javascript">
var mytext = new Array();
<?php 
  for ($i = 0; $i < count($activeProjects); $i++){
    echo 'mytext[' . $i . ']="' . $activeProjects[$i] . '"\n';
} ?>
</script>

or if youd rather

<script type="text/javascript">
var mytext = new Array();
<?php 
  $i = 0;
  foreach ($activeProjects as $mytextvalue){
    $i++;
    echo 'mytext[' . $i . ']=" ' . $mytextvalue . '"\n';
} ?>
</script>

or even

<script type="text/javascript">
var mytext = new Array();
<?php 
  foreach ($activeProjects as $mytextkey => $mytextvalue){
    echo 'mytext[' . $mytextkey . ']="' . $mytextvalue . '"\n';
} ?>
</script>

laserlight

What happens if you forget to define $i because your in a hurry and you use $i++? You always get zeroed right?

You should keep error_reporting at E_ALL during development and fix the undefined variable warning detected.

My next question is why does it look like that foreach is using something that isnt defined? Which yet again is something that you and your criticist should have noticed.

Sometimes, when helping others, we assume that some newly introduced variable has been correctly defined. If you suspect that that is the root of the problem, go ahead and point it out, but there's no need to make such remarks as "yet again is something that you and your criticist should have noticed".

Oh, no, no. I took the entire snippet from Echo block. My entire JS waws withing that echo string.

hmm... might want to show the entire code snippet then. If the entire block was being printed, then you have a problem since you would be trying to do an foreach loop (with an echo) within an echo.