errors when code processed

shevd

Hi
when i try load the following code
<?
/**
UserInfo.php

This page is for users to view their account information
with a link added for them to edit the information.

Written by: Jpmaster77 a.k.a. The Grandmaster of C++ (GMC)
Last Updated: August 26, 2004
/
include("include/session.php");
?>

<html>
<title>Jpmaster77's Login Script</title>
<body>

<?
/ Requested Username error checking /
$req_user = trim($_GET['user']);
if(!$req_user || strlen($req_user) == 0 ||
!eregi("^{([0-9a-z])+$",} $req_user) ||
!$database->usernameTaken($req_user)){
die("Username not registered");
}

/ Logged in user viewing own account /
if(strcmp($session->username,$req_user) == 0){
echo "<h1>My Account</h1>";
}
/ Visitor not viewing own account /
else{
echo "<h1>User Info</h1>";
}

$req_user_info = $database->getUserInfo($req_user);

/ Username /
echo "<b>Username: ".$req_user_info['username']."</b><br>";

/ Email /
echo "<b>Email:</b> ".$req_user_info['email']."<br>";

/**
Note: when you add your own fields to the users table
to hold more information, like homepage, location, etc.
they can be easily accessed by the user info array.

$session->user_info['location']; (for logged in users)

..and for this page,

$req_user_info['location']; (for any user)
/

/ If logged in user viewing own account, give link to edit /
if(strcmp($session->username,$req_user) == 0){
echo "<br><a href=\"useredit.php\">Edit Account Information</a><br>";
}

/ Link back to main /
echo "<br>Back To [<a href=\"main.php\">Main</a>]<br>";

</body>
</html>

I get the following displayed which is obviously wrong. I am running php5 can someone plz help
.
usernameTaken($req_user)){ die("Username not registered"); } / Logged in user viewing own account / if(strcmp($session->username,$req_user) == 0){ echo "
My Account
"; } / Visitor not viewing own account / else{ echo "
User Info
"; } $req_user_info = $database->getUserInfo($req_user); / Username / echo "Username: ".$req_user_info['username']."
"; / Email / echo "Email: ".$req_user_info['email']."
"; /** Note: when you add your own fields to the users table to hold more information, like homepage, location, etc. they can be easily accessed by the user info array. $session->user_info['location']; (for logged in users) ..and for this page, $req_user_info['location']; (for any user) / / If logged in user viewing own account, give link to edit / if(strcmp($session->username,$req_user) == 0){ echo "
Edit Account Information
"; } / Link back to main / echo "
Back To [Main]
"; ?>

Piranha

Obviously it seems like the -> in the row below is treated like the PHP-part is up.

 !$database->usernameTaken($req_user)){

It might work if you change it to:

 !($database->usernameTaken($req_user))){

And next time please wrap the code in the [ php ] and [ /php ] tags (without the spaces).

shevd

Hi that doesn't work is there a php or apache setting which may be causing this problem.

bradgrafelman

Could be that the short_open_tag directive has been turned off (as it should be - the short tag syntax is deprecated by not only good coding practices but also the PHP.net manual); try using the full <?php opening tag.

Weedpacket

As bradgrafelman said, it looks like <? is not being recognised as the start of a PHP block.

If you looked at the generated HTML source code instead of just the rendered HTML, you'd probably find that PHP did nothing at all with your script and just fed it through completely unchanged.