can upload gif but not jpg

[seanisean]

im using this script to upload pictures from my pc to a server gifs upload no problem but jpgs dont at all?

// fullsize image file upload script
	if (($_FILES["fullsize"]["type"] == "image/gif") || ($_FILES["fullsize"]["type"] == "image/jpeg") && ($_FILES["fullsize"]["size"] < 100000000000))
  	{
		echo("<div class=\"detail\">");
		if ($_FILES["fullsize"]["error"] > 0)
  		{
    			echo "<p>Return Code: " . $_FILES["fullsize"]["error"] . "</p></div>";
    		}
  		else
    		{
			echo("<p>");
    			echo "Upload: " . $_FILES["fullsize"]["name"] . "<br />";
    			echo "Type: " . $_FILES["fullsize"]["type"] . "<br />";
    			echo "Size: " . ($_FILES["fullsize"]["size"] / 1024) . " Kb<br />";
    			echo "Temp file: " . $_FILES["fullsize"]["tmp_name"];
			echo("</p>");  

			if (file_exists("../upload/fullsize/" . $_FILES["fullsize"]["name"]))
      			{
				echo("<div class=\"error\"><h3>ERROR: </h3><p>");
      				echo $_FILES["fullsize"]["name"] . " already exists. ";
				echo("<br />hit the back button on your browser and try another file");
				echo("</p><hr /></div></div>");
      			}
    			else
      			{
				echo("<p>");
      				move_uploaded_file($_FILES["fullsize"]["tmp_name"],"../upload/fullsize/" . $_FILES["fullsize"]["name"]);
      				echo "Stored in: " . "../upload/fullsize/" . $_FILES["fullsize"]["name"];
				echo("</p>");
				echo("</div>");
				echo("<div id=\"intro\">");
				include("../include/submitted.php");
				echo("<hr />");
				echo("</div>");
      			}
    		}
  	}
	else
  	{
		echo("<div class=\"detail\">");
  		echo "<p>Invalid file</p>";
		echo("<hr />");
		echo("</div>");
  	}

// thumbnail image file upload script for plants db
if (($_FILES["thumbnail"]["type"] == "image/gif") || ($_FILES["thumbnail"]["type"] == "image/jpeg") && ($_FILES["thumbnail"]["size"] < 10000000))
{
	echo("<div class=\"detail\">");
	if ($_FILES["thumbnail"]["error"] > 0)
	{
			echo "<p>Return Code: " . $_FILES["thumbnail"]["error"] . "</p><br />";
		}
	else
		{
		echo("<p>");
			echo "Upload: " . $_FILES["thumbnail"]["name"] . "<br />";
			echo "Type: " . $_FILES["thumbnail"]["type"] . "<br />";
			echo "Size: " . ($_FILES["thumbnail"]["size"] / 1024) . " Kb<br />";
			echo "Temp file: " . $_FILES["thumbnail"]["tmp_name"];
		echo("</p>");
		if (file_exists("../upload/thumbnails/" . $_FILES["thumbnail"]["name"]))
  			{
			echo("<div class=\"error\"><h3>ERROR: </h3><p>");
  				echo $_FILES["thumbnail"]["name"] . " already exists. ";
			echo("<br />hit the back button on your browser and try another file");
			echo("</p><hr /></div></div>");
  			}
			else
  			{

			echo("<p>");
  				move_uploaded_file($_FILES["thumbnail"]["tmp_name"],"../upload/thumbnails/" . $_FILES["thumbnail"]["name"]);
  				echo "Stored in: " . "../upload/thumbnails/" . $_FILES["thumbnail"]["name"];
			echo("</p>");
			echo("</div>");
			echo("<div id=\"intro\">");
			include("../include/submitted.php");
			echo("<hr />");
			echo("</div>");
  			}
		}
}
else
{
	echo("<div class=\"detail\">");
	echo "<p>Invalid file</p>";
	echo("<hr />");
	echo("</div>");
}
?>

any help much appreciated

sean

[Weedpacket]

As you've discovered, relying on the client to send you the correct MIME type for the file it's uploading is pretty unreliable (you've looked to see what it is using?). You can use [man]getimagesize/man to tell you what type of image file it really is.

Incidentally, && has a higher precedence than ||, so your first test is equivalent to

if(/*image is GIF*/ || (/* image is JPEG */ && /* image is not too big */ ))

So it allows really really big GIFs.

And doesn't allow PNGs for some reason....

[seanisean]

cheers for the reply

the code i posted is for my sites backend to help make it easier to add content,
in this case the only image formats being used are gifs or jpgs, and i'm using enctype=multipart/form-data in the form i use to submit the images along with some db entrys.

the images i tested were gifs which work and jpgs which dont work

so why dont the jpgs work??

sean

[Weedpacket]

And does the the content of my reply help in any way?