A little help please..

cretam

:bemused: :bemused: Hi,
I am dumbfounded why my code doesn't work properly, I am trying to get people to select a region off a map (this parts ok) and then I want them to select an organisation and display contacts from that type of organisation from the region selected.
For some reason, when I select a region it only displays one record (i echoed it for testing before doing the select box for the org)
Here is my code:

  <?php

include("Connections/conn.php");

// Get the region name from the database
$id = $_GET['id'];
$rid = @mysql_query(
    "SELECT id, name FROM region WHERE id='$id'");
if (!$rid) {
  exit('Unable to load the publication from the database.');
}

$rid = mysql_fetch_array($rid);
$region = $rid['name'];
$reg = $rid['id'];
echo "<b>Region selected:</b> $region</br>";

$contacts = @mysql_query(
	"SELECT id, contact_name, title, name, title_2, name_2, res_add, postal_add, phone, mobile, fax, email, orgid, regionid FROM contact WHERE regionid='$reg'");
	if (!$contacts) {
  exit('Unable to load the publication from the database.');
}
$contacts = mysql_fetch_array($contacts);
$name = $contacts['contact_name'];
echo "<b>$name</b></br>\n";

?>

Any help would be appreciated.

auddog

I think that you need to change the lines:

$rid = mysql_fetch_array($rid);
$region = $rid['name'];
$reg = $rid['id'];
echo "Region selected: $region";

to read:

$rid = mysql_fetch_array($rid);
$reg = $rid['id'];
$region = $rid['name'];
echo "Region selected: $region";

PHP takes the query in the order that you call it - yours are reversed. I'm still kind of new to PHP, but give that a try.

stolzyboy

auddog, that isn't going to matter, as far as order since he's calling it via name, PHP could care less what order you pull the variables in...

as far as the issue at hand, if you want all the records, instead of doing

$contacts = mysql_fetch_array($contacts); 
$name = $contacts['contact_name']; 
echo "<b>$name</b></br>\n";

-----------------------------

you need to loop through the results like

while ($contacts = mysql_fetch_array($contacts))
{
$name = $contacts['contact_name']; 
echo "<b>$name</b></br>\n";
}

----------------------------

stolzyboy

cretam

Thanks guys for the quick reply.
I tried what you suggested Stolzyboy and know you are close but it says
"Warning: Supplied argument is not a valid MySQL result resource in c:\documents and settings\tammy creaser\my documents\htdocs\nrm\contactlist.php on line 35"
New code

  <?php

include("Connections/conn.php");

// Get the region name from the database
$id = $_GET['id'];
$rid = @mysql_query(
    "SELECT id, name FROM region WHERE id='$id'");
if (!$rid) {
  exit('Unable to load the publication from the database.');
}

$rid = mysql_fetch_array($rid);
$region = $rid['name'];
$reg = $rid['id'];
echo "<b>Region selected:</b> $region</br>";

$contacts = @mysql_query(
	"SELECT id, contact_name, title, name, title_2, name_2, res_add, postal_add, phone, mobile, fax, email, orgid, regionid FROM contact WHERE regionid='$reg'");
	if (!$contacts) {
  exit('Unable to load the publication from the database.');
}

while ($contacts = mysql_fetch_array($contacts)) 
{ 
$name = $contacts['contact_name']; 
echo "<b>$name</b></br>\n"; 
}


?>

Any more suggestions?

cretam

Thanks Stolzyboy,
I fixed it with your help.
Here is the correct code.

while ($contact = mysql_fetch_array($contacts)) 
{ 
$name = $contact['id']; 
$contactname = htmlspecialchars($contact['contact_name']);
echo "$contactname</br>\n";
}
?>

Thanks again

stolzyboy

that is how you do it, as far as errors, i can't error check for you, but when you get that error, it just means there were issues with the results you got... change this line

$contacts = @mysql_query( 
    "SELECT id, contact_name, title, name, title_2, name_2, res_add, postal_add, phone, mobile, fax, email, orgid, regionid FROM contact WHERE regionid='$reg'");

to this

$contacts = mysql_query( 
    "SELECT id, contact_name, title, name, title_2, name_2, res_add, postal_add, phone, mobile, fax, email, orgid, regionid FROM contact WHERE regionid='$reg'") or die(mysql_error());

that will help you figure out where the problem is

stolzyboy

ah, good to see you got it figured out

just a hint, instead of doing the !$contacts stuff, add or die() and the mysql_error() stuff in there when you are in dev so you can see where errors are, or add custom error handlers with the mysql_error() bits in there so you can catch errors gracefully once in prod

stolzyboy

cretam

Ok thanks for the tip Stolzyboy.