Help with form mail php script

TimeTraveller

Thank you very much for your help. Moonbrat

:xbones: :xbones: you can probably tell how amateur I am at php programming, cos I couldn't get the below code to run at all after I have made reference to this php in the form.

In the html, user would input data, and include an attachment, the fields are exactly as the names listed below

for the attachment, I have named it name="file1"

sendmail.php

<?php

$from = $POST['EmailAddress'];
$title = $POST['gender'];
$First = $POST['First_Name'];
$Last = $POST['Last_Name'];
$Phone = $POST['Phone_Number'];
$Country= $POST['Country'];
$Comments = $_POST['Comments'];

$fileatt = $FILES['file1']['tmp_name'];
$fileatt_type = $FILES['file1']['type'];
$fileatt_name = $_FILES['file1']['name'];

if((!$from == "") && (!strstr($from,"@") || !strstr($from,".")))
{
echo "<h2>Use Back - Enter valid e-mail</h2>\n";
$tellem = "<h2>Feedback was NOT submitted</h2>\n";
}

if(empty($First) || empty($Last) || empty($from)) {
echo "<h2>Use Back - fill in all required fields</h2>\n";
}

$headers = "From: $from";

if (is_uploaded_file($fileatt)) {
// Read the file to be attached ('rb' = read binary)
$file = fopen($fileatt,'rb');
$data = fread($file,filesize($fileatt));
fclose($file);

// Generate a boundary string
$semi_rand = md5(time());
$mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";

// Add the headers for a file attachment
$headers .= "\nMIME-Version: 1.0\n" .
"Content-Type: multipart/mixed;\n" .
" boundary=\"{$mime_boundary}\"";

// Add a multipart boundary above the plain message
$message = "This is a multi-part message in MIME format.\n\n" .
"--{$mime_boundary}\n" .
"Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
"Content-Transfer-Encoding: 7bit\n\n" .
$message . "\n\n";

// Base64 encode the file data
$data = chunk_split(base64_encode($data));

// Send the message
$ok = @mail("mymail", $from, $title, $First, $Last, $Phone, $Country, $Comment, $headers);
if ($ok) {
echo "<p>Mail sent! Thank you for signing up !</p>";
} else {
echo "<p>Mail could not be sent. Sorry!</p>";
}
?>

</body>
</html>

I'd really appreciate some help. Thanks a million

rincewind456

You may want to indent your code blocks, it helps with readabilty and debugging. Then count the number of curly brackets, if it's odd you have a problem 😃

Also can you use [ php][/php ] tags (without the spaces)to enclose your code when posting.

Here is what it should look like

<?php 

$from = $_POST['EmailAddress'];
$title = $_POST['gender'];
$First = $_POST['First_Name'];
$Last = $_POST['Last_Name'];
$Phone = $_POST['Phone_Number'];
$Country= $_POST['Country'];
$Comments = $_POST['Comments'];

$fileatt = $_FILES['file1']['tmp_name'];
$fileatt_type = $_FILES['file1']['type'];
$fileatt_name = $_FILES['file1']['name'];

if((!$from == "") && (!strstr($from,"@") || !strstr($from,".")))
{
	echo "<h2>Use Back - Enter valid e-mail</h2>\n";
	$tellem = "<h2>Feedback was NOT submitted</h2>\n";
}

if(empty($First) || empty($Last) || empty($from)) {
	echo "<h2>Use Back - fill in all required fields</h2>\n";
}


$headers = "From: $from";

if (is_uploaded_file($fileatt)) {
	// Read the file to be attached ('rb' = read binary)
	$file = fopen($fileatt,'rb');
	$data = fread($file,filesize($fileatt));
	fclose($file);

// Generate a boundary string
$semi_rand = md5(time());
$mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";

// Add the headers for a file attachment
$headers .= "\nMIME-Version: 1.0\n" .
"Content-Type: multipart/mixed;\n" .
" boundary=\"{$mime_boundary}\"";

// Add a multipart boundary above the plain message
$message = "This is a multi-part message in MIME format.\n\n" .
"--{$mime_boundary}\n" .
"Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
"Content-Transfer-Encoding: 7bit\n\n" .
$message . "\n\n";

// Base64 encode the file data
$data = chunk_split(base64_encode($data));

// Send the message
$ok = @mail("mymail", $from, $title, $First, $Last, $Phone, $Country, $Comment, $headers);
if ($ok) {
	echo "<p>Mail sent! Thank you for signing up !</p>";
} else {
	echo "<p>Mail could not be sent. Sorry!</p>";
}
 }		//<----- This was missing
?>

</body>
</html>

TimeTraveller

Thank you very much rincewind456 for what must have been an excruciating process in reading my messy scripts.

I have tried to run the code again, but is still not working at all.

Is it the form ? or the php script ? 😕 😕

rincewind456

When you say it doesn't work do you mean you get an empty page or an error message?

The only thing I can see, after a quick look, is that this line

if (is_uploaded_file($fileatt)) {

has no error catching mechanism, so if $fileatt is not uploaded then it goes straight to the end of the script, it actually goes to the curly bracket that was missing before, so you error message

echo "<p>Mail could not be sent. Sorry!</p>";

is bypassed.

TimeTraveller

Thank you again. rincewind456.

Yes, I get a blank page and nothing happens when I try to run the code :xbones: :xbones: nothing works whatsoever :bemused: 😕

rincewind456

Ok some questions and observations.

There is a problem in this part of the code:

// Add a multipart boundary above the plain message 
    $message = "This is a multi-part message in MIME format.\n\n" . 
    "--{$mime_boundary}\n" . 
    "Content-Type: text/plain; charset=\"iso-8859-1\"\n" . 
    "Content-Transfer-Encoding: 7bit\n\n" . 
    $message . "\n\n";

This is the first instance of $message and you are trying to add the $message you have created here, to here. :bemused: So the code would end up looking like

This is a multi-part message in MIME format.

--{$mime_boundary}
Content-Type: text/plain; charset=\"iso-8859-1\
Content-Transfer-Encoding: 7bit

This is a multi-part message in MIME format.

--{$mime_boundary}
Content-Type: text/plain; charset=\"iso-8859-1\
Content-Transfer-Encoding: 7bit

at least it would if it were possible.

This section:

 // Base64 encode the file data 
    $data = chunk_split(base64_encode($data));

where does it go? you create $data with the file uploaded then encode it here but it then is not used.

Then this:
[code=php]  $ok = @mail("mymail", $from, $title, $First, $Last, $Phone, $Country, $Comment, $headers); [/code]
Has way to many parameters it should take the form [code=php]mail($to, $subject, $message, $headers);[/code]
Take a look at [man]mail[/man]() for examples.

You also don't show your form HTML but bear in mind that you will need to use an enctype to get the form to post to your php code your form tag should look something like this:[code=html]<form method="post" action="" enctype="multipart/form-data">[/code]