upgrade from 5.0.5 to 5.1.6 now unexpected code issues?

Toboe

I get this after upgrading php.

Notice: Object of class stdClass could not be converted to int, I don;t under stand this. I get it in many of my pages, it has basically destroyed my site.

I can't seem to figure out any of these, even after spending a few hours at php.net =/

33-38 - line 35 errors

$config = $ace->loadsettings();

if( $config == 0 || $config->installed == 0 ){
	header('Location: install/index.php');
	exit();
}

same file lin e93 errors.

93-99

if( $user != 0 ){
	$vars['username'] = $user->username;
	$vars['email'] = $user->email;
	foreach( $user as $n=>$v ){
		if( !is_array($v) && !isset($vars['user_'.$n])){
			$vars['user_'.$n] = $v;
		}

a seperate file,

57-62 line 57 errors

		if( $user != 0 ){
		switch( $user->status ){
			case 1: $loggedin = true; break;
			case 0: $unconfirmed = true; $user = $userid = 0; break;
			case 2: $suspended = true; $user = $userid = 0; break;
		}

line 18 and 19 of another file, both error.

$name = $ace->getstr('name', $_POST, $user != 0 ? $user->name : '');
$email = $ace->getstr('email', $_POST, $user != 0 ? $user->email : '');

68 errors here, 68-75 shown.

if( $user != 0 ){ 
	$ims = $user->images.' of '.($user->max_images == 0 ? 'unlimited' : $user->max_images);
	$bws = $user->bandwidth_used.'mb of '.($user->bandwidth == 0 ? 'unlimited' : $user->bandwidth.'mb');
	if( $user->bandwidth != 0 ) $bws = ceil($user->bandwidth_used/$user->bandwidth*100).'% ('.$bws.')';
	$sto = $user->storage_used.'mb of '.($user->storage == 0 ? 'unlimited' : $user->storage.'mb');
	if( $user->storage != 0 ) $sto = ceil($user->storage_used/$user->storage*100).'% ('.$sto.')';
	$ac = htmlspecialchars($user->type_name);
	if( $user->type_type == 'free' ) $ac = '<a href="upgrade.php">'.$ac.'</a>';

Any ideas abou thow to remedy these?

bogu

One idea would be to go back on 5.0.5 🙂

MarkR

You're comparing a value which contains an object with an integer (using ==). This obviously isn't valid any more (Why was it ever?).

Don't do that.

You may wish to use is_object instead, which I feel won't generate this warning.

In any case, any migration (even to a different build of the same version) should be tested in your development environment before going anywhere near the production server. If by

I get it in many of my pages, it has basically destroyed my site.

You mean it has destroyed your development site, then that's not a problem, is it? You can simply fix the errors, test it thoroughly then migrate the PHP changes at the same time as upgrading PHP on your production environment.

Mark