Quick question about error message?

[Jermizzle]

$update_table = "UPDATE menu SET rating = $_POST[$rating] WHERE doc_id = $row[doc_id]";

Why is this not possible?

I am getting a error saying the syntax is wrong but i cannot see whats wrong.

Thanks
Jermizzle

[rgermain]

$update_table = "UPDATE menu SET rating = '$_POST[$rating]' WHERE doc_id = '$row[doc_id]'";

Try that. You need single quotes around your variables.

[Jermizzle]

Its working now thanks rgermain

[MarkR]

The above code looks wrong:

1. You are incorporating data from $_POST into a SQL query with no type checking etc. This should definitely be done just for normal sanity checks, not to mention SQL injection prevention.
2. $POST[$rating] sounds wrong, did you mean $POST['rating'] ?? It is possible that you could be updating a row to set the rating to a value passed in the post field $rating, but seems unlikely and somewhat obfuscated (why not call $rating, $rating_field in this case?)

I think maybe you need to enable error_reporting(E_ALL) and fix all warnings and notices which are generated.

Mark

[rgermain]

Good catch Mark, but I am guessing since they said it is working now. And not "That worked", that they figured out all the mistakes by themselves. Without my intervention and errors! 🙂