[RESOLVED] Do you know why this does not work?

skip

Hello can anyone spot why this fails to pick up the first and last keyphrases

Thanks in advance

<?
function exact_match($find, $data){
$find = explode("|",$find);
	for($i=0;$i<sizeof($find); $i++){
 if(preg_match("/\b".strtolower($find[$i])."\b/i", strtolower($data))){
	return true;
		}else{
	return false;
	}
 }
}

$stringarray = array(
0 => "This string just contains ipod and no numbers",
1 => "This string contains the word ipod and the number 30 but not together",
2 => "This string contains the word ipod 30 but without GB",
3 => "This string contains the whole phrase ipod 30 GB",
4 => "This string contains another phrase we could use ipod 30GB",
5 => "This string also has another phrase we can use ipod white 30 gb",
6 => "This phrase has another too ipod (black) 30gb",
7 => "This phrase has another too ipod (white) 30gb"
);

$keyphrasearray = array(
0 => "ipod (black) 30gb",
1 => "ipod white 30 gb",
2 => "ipod 30gb",
3 => "ipod 30 gb",
4 => "ipod (white) 30gb"
);

for($i=0;$i<sizeof($stringarray);$i++){
	for($ix=0;$ix<sizeof($keyphrasearray);$ix++){
		if(exact_match($keyphrasearray[$ix], $stringarray[$i])){
			echo $stringarray[$i]." Passed through!<br />";
		}
	}
}
?>

stolzyboy

don't have time to do any "fixing" or "testing" for you, but i can tell you it has to do with the ()'s around the black and white phrases

hth,
stolzyboy

laserlight

A simple fix might involved [man]preg_quote/man

liquorvicar

Unless you especially want to match punctation and special characters, why don't you strip any non-word characters from your search string?

function exact_match($find, $data){
   $find = preg_replace("[^\w\s]",'',$find); // remove any chars that are not word chars or whitespace
   $find = explode("|",$find);
    for($i=0;$i<sizeof($find); $i++){
        if(preg_match("/\b".strtolower($find[$i])."\b/i", strtolower($data))){
             return true;
        }else{
             return false;
       }
    }
}

Untested.

liquorvicar

Looking more closely at your script, I'm not sure what you're trying to achieve.
This line

$find = explode("|",$find);

does nothing.

Plus you have a slightly odd way of looping throughs arrays (although you may have a reason for that.
This

 for($ix=0;$ix<sizeof($keyphrasearray);$ix++){
        if(exact_match($keyphrasearray[$ix], $stringarray[$i])){
            echo $keyphrasearray[$ix].$stringarray[$i]." Passed through!<br />";
        }
    }

can be written

 foreach ($keyphrasearray as $keyphrase){
        if(exact_match($keyphrase $string){
            echo $string." Passed through!<br />";
        }
    }

Makes it much easy to read and understand IMHO.

liquorvicar

PS preg_quote does work:

function exact_match($find, $data){
$find = preg_quote($find);
if(preg_match("/\b".strtolower($find)."\b/i", strtolower($data))){
    return true;
        }else{
    return false;
    }
}

produces

ipod 30 gbThis string contains the whole phrase ipod 30 GB Passed through!
ipod 30gbThis string contains another phrase we could use ipod 30GB Passed through!
ipod white 30 gbThis string also has another phrase we can use ipod white 30 gb Passed through!
ipod (black) 30gbThis phrase has another too ipod (black) 30gb Passed through!
ipod (white) 30gbThis phrase has another too ipod (white) 30gb Passed through!

skip

Nice one thanks 🙂

the explode("|",$find) part is there because I normaly pass a pipe delimited string of strings to it 🙂.

Thanks for all your help