I keep getting an SQL error, not sure what to do

[Mythic_Fr0st]

I keep getting this SQL error...

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''[e-mail])' at line 3

I dont know what to do?

can anyone help me?

[Piranha]

Without seeing the query it is virtually impossible to know exactly what is the problem.

[Mythic_Fr0st]

Where would I find the query? is it the code I actually have?

here it is if so

$con = mysql_connect("localhost","root","");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("userdetails", $con);

$sql="INSERT INTO users (username, userpass, email)
VALUES
('$_POST[username]','$_POST[password1]','$_POST[email1])";

if (!mysql_query($sql,$con)) 
{ 
     die(' Error: ' . mysql_error()); 
}  

echo '<font color=\'blue\ size=\'4\'>Welcome to Mythic Aeons';  

mysql_close($con);

I belive the line is ('$POST[username]','$POST[password1]','$_POST[email1])";

I tried doing it this way

I belive the line is ('$POST[username]','$POST[password1]','$_POST[email1]');

but only got syntax errors:/

[liquorvicar]

You're missing a quote after your email variable (before the closing bracket), and if you're using array members embedded in a double-quoted string you need to enclose them in curly braces otherwise PHP will not be able to parse the string:

$sql="INSERT INTO users (username, userpass, email)
VALUES
('{$_POST['username']}','{$_POST['password1']}','{$_POST['email1']}')";

By the way, it's very dangerous to insert $_POST data directly into an SQL query. You should always validate any data coming from outside PHP. At the very least you should use mysql_real_escape_string to escape your data. You might want to go a it further, like, for example, checking the email address is a valid email address etc.

[Mythic_Fr0st]

Thanks, I do use the escape_string & I will add valid e-mail thing later