Alternating Table Row Colors???

lovinlazio9

hi everyone, just wondering if anyone can see right off the bat whats wrong with what i'm doing? I'm pretty much selecting info from the db and printing it...but i want to alternate the color of row for every entry...i created ".even" as a class in my css and linked to it...but whenever i use this code... i get this error:

Parse error: syntax error, unexpected T_PRINT in "url" on line 119

and line 119 is the first print statement...

when i remove:

$count =0;

$isEven = $count % 2

$count = $count +1;

if($isEven==0)
print("<tr class=\"even\">");
else
print("<tr>");

from the code, it works but only uses the initial color for the background...

<center>
<table border="0" cellpadding="4" cellspacing="4" bgcolor="#BABAA0" ><center>
<tr>
<td width="100">Reviewer</td>
<td width="10">Date</td>
<td width="450">Comment</td>
</tr>

<?
$dbh=mysql_connect ("localhost", "**", "") or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ("**");
?>

<?
//error message (not found message)begins
$XX = "No Record Found, to search again please close this window";
//query details table begins
$query = mysql_query("SELECT user, date, comment
FROM comments
ORDER BY date DESC");

$count =0;
while ($row = @mysql_fetch_array($query))
{
$variable1=$row["id"];
$variable2=$row["date"];
$variable3=$row["user"];
$variable4=$row["comment"];

//table layout for results
$isEven = $count % 2
print ("<tr>");
print ("<td>$variable3</td>");
print ("<td>$variable2</td>");
print ("<td>$variable4</td>");
print ("</tr>");
$count = $count +1;

if($isEven==0)
print("<tr class=\"even\">");
else
print("<tr>");

lobobr

You've missed a semicolon on this line:

$isEven = $count % 2

lovinlazio9

geez, i looked at that code forever last night and couldn't find that! thanks a lot..it loads the page error free now but i guess i haven't set up the class b/c it doesn't alternate the colors...

my style sheet has this
.even {

background-color: #022B54;
}

do i have to actually put <tr> in the { }?

by the way , i really appreciate the help.

lobobr

lovinlazio9 wrote:
geez, i looked at that code forever last night and couldn't find that!

Heh it happens, don't worry.

lovinlazio9 wrote:
do i have to actually put <tr> in the { }?

No, your CSS syntax is correct. Your code is too incomplete to look at it. Please post the full code surrounded by PHP BBCode tags.

lovinlazio9

thanks for the quick responses...well, thats pretty much all the code i have right now...all i'm doing is displaying the table...with the info...but here is the entire script:

<html>
<head>
<title>untitled</title>
<link rel="stylesheet" type="text/css"
href="presentation.css" />
</head>

<body> 
<table border="0" cellpadding="4" cellspacing="4" bgcolor="#FFFFCC" ><center>
<tr>
<td width="100"><b><font color="#022B54" face="Verdana" size="2">Reviewer</b></td>
<td width="10"><b><font color="#022B54" face="Verdana" size="2">Date</b></td>
<td width="450"><b><font color="#022B54" face="Verdana" size="2">Comment</b></td>
</tr>


<?
         $dbh=mysql_connect ("localhost", "*****", "***") or die ('I cannot connect to the database because: ' . mysql_error());
        mysql_select_db ("******");
?>

<?
//error message (not found message)begins
$XX = "No Record Found, to search again please close this window";
//query details table begins
$query = mysql_query("SELECT user, date, comment
FROM comments
ORDER BY date DESC");



//loop statement



$count =0;
while ($row = @mysql_fetch_array($query))
{
$variable1=$row["id"];
$variable2=$row["date"];
$variable3=$row["user"];
$variable4=$row["comment"];


//table layout for results
$isEven = $count % 2;

print ("<tr>");
print ("<td>$variable3</td>");
print ("<td>$variable2</td>");
print ("<td>$variable4</td>");
print ("</tr>");
$count = $count +1;


if($isEven==0)
print("<tr class=\"even\">");
else
print("<tr>");






}
//below this is the function for no record!!
if (!$variable1)
{
print ("$XX");
}
//end
?>
</table>
</center>

</body>
</html>

i hope thats okay?

lobobr

After a quick glance I've noticed this:

if($isEven==0)
print("<tr class=\"even\">");
else
print("<tr>");

Shouldn't you have a "odd" CSS class and use it? Try and let me know.

lobobr

Oh, just another thing that came up:

If the results are displayed in this code section:

print ("<tr>");
print ("<td>$variable3</td>");
print ("<td>$variable2</td>");
print ("<td>$variable4</td>");
print ("</tr>");
$count = $count +1;

Then you should apply your CSS class in that section instead of doing it below...

Am I right?

lovinlazio9

i did this:

if($isEven==0)
print("<tr class=\"even\">");
else
print("<tr class=\"odd\">");

and made

.odd {

background-color: #--------;
}

in the style sheet but still no joy...

once again, i appreciate the help

dragnlo

I didnt run this but it should work

$count =0; 
while ($row = @mysql_fetch_array($query)) { 
    $variable1=$row["id"]; 
    $variable2=$row["date"]; 
    $variable3=$row["user"]; 
    $variable4=$row["comment"]; 
    if(++$count % 2) 
        print("<tr class=\"even\">"); 
    else 
        print("<tr>"); 


print ("<td>$variable3</td>"); 
print ("<td>$variable2</td>"); 
print ("<td>$variable4</td>"); 
print ("</tr>"); 
}

alternately:

$count =0; 
while ($row = @mysql_fetch_array($query)) { 
    (++$count % 2) ? print("<tr class=\"even\">") : print("<tr>"); 
    print ("<td>".$row["user"]."</td>"); 
    print ("<td>".$row["date"]."</td>"); 
    print ("<td>".$row["comment"]."</td>"); 
    print ("</tr>"); 
} 
//below this is the function for no record!! 
if ($count == 0) 
    print ("$XX"); 
//end

lovinlazio9

great guys thanks a lot.. the "alternatively" code worked....the other ones didn't work even when i changed the table color (b/c it was set already and the css wouldn't change it) but when i took away the bg color from the table...it worked...thanks a lot..i really appreciate it and sorry to take up your time!