problem with a short if(isset) command

[w4designs]

Can someone look at the following code and see if you can spot a problem with it?

Purpose:
I'm using this to try to look at a property class for a realty website. if the page has a property class assigned to it, it will use the corresponding number jpg file for the header. In other words, i have header image files named 1.jpg, 2.jpg, 3.jpg, etc to correspond with property classes 1,2,3, etc. If a page doesn't have a property class, it will use the default header image which is assigned in the else portion of the syntax. Please give me your thoughts. I'm inserting this code in an html page where the header should be displayed.

Problem:
All it's doing is displaying the default header image on all pages, even though a property class is assigned.

Thanks!

<?php 

   //start by checking if we're viewing a property class 
   if(isset($_GET['pclass%5B%5D']))  

   	{ 
   	//we are! lets get the matching image 
   	$classimg = $_GET['pclass%5B%5D']; //assign the property class number 
   	$headerimg = '{template_url}/images/'.$classimg.'.jpg'; //make the image url 
   	//echo $classimg; 
   	} 
   else  

   	//No property class, lets just view the main logo for the site 
   	{ 
   	 $headerimg = '{template_url}/images/logo.jpg'; //set this to your default site logo 
   	//echo 'Normal header'; 
   	} 
   		//show the image 
   		echo '<img src="'.$headerimg.'" height="164" width="950">'; 
?>

[Piranha]

Have you tried to change $GET['pclass%5B%5D'] to something without special chars? Like $GET['pclass']? It could be problems with the rest of the name, I'm not sure.

When you have solved this problem I have to give you another one. What if someone changes it manually, so the value is not 1, 2, 3 etc? What if the value is 0? Or -4? Or 73 (and you don't have 73 pics)? Or if it is 'Kalle'? To solve these problems I would do something simular to this:

$custompic = false;
if (isset($_GET['pclass']))
{
    if (...) // Code to see if the value is ok for a custom pic.
    {
        // The code you have to set the headerimg
        $custompic = true;
    }
}

if (!$custompic)
{
    // code you have to get the default logo
}

echo "<img... >" // Code to place the pic on the website

[w4designs]

Interesting scenario you propose and I'll address that when I get this going. Upon your suggestion, I removed those extra characters and it helped to an extent. Now on the pages with no pclass, I get the default header image. Perfect! However on the pages with a pclass, it attemptes to load and image but gives a red x in the box. If I right click that red x image and choose properties, it seems as if it's trying to load an image called array.jpg. Why would it being doing this?

Thanks!

[w4designs]

Now I've done this commenting out the actual image placement and telling it to echo text so i can see if that works. On pages with no pclass, i get "Normal header" displayed. BUT, on those with a pclass, it's showing "Array" where it should be showing the pclass if the code was correct. Sooooo, something still wrong with the code but I don't see what. here it is:

<?php 

   //start by checking if we're viewing a property class 
   if(isset($_GET['pclass']))  

   		{ 
   		//we are! lets get the matching image 
   		$classimg = $_GET['pclass']; //assign the property class number 
   		$headerimg = '{template_url}/images/'.$classimg.'.jpg'; //make the image url 
   		echo $classimg; 
   		} 
   else  

   		//No property class, lets just view the main logo for the site 
   		{ 
//   	$headerimg = '{template_url}/images/logo.jpg'; //set this to your default site logo 
   		echo 'Normal header'; 
   		} 
   	//show the image 
//   	echo '<img src="'.$headerimg.'" height="164" width="950">'; 
?>

[w4designs]

Then to further test, if I change the first echo from displaying what's set as classimg, to what's set as headerimg, like the code below, I get the entire url to the image but with Array.jpg as if $_GET['pclass[]'] is storing the word Array to classimg.

<?php 

   //start by checking if we're viewing a property class 
   if(isset($_GET['pclass']))   

           { 
           //we are! lets get the matching image 
           $classimg = $_GET['pclass']; //assign the property class number 
           $headerimg = '{template_url}/images/'.$classimg.'.jpg'; //make the image url 
           echo $classimg; 
           } 
   else   

           //No property class, lets just view the main logo for the site 
           { 
//       $headerimg = '{template_url}/images/logo.jpg'; //set this to your default site logo 
           echo 'Normal header'; 
           } 
       //show the image 
//       echo '<img src="'.$headerimg.'" height="164" width="950">'; 
?>

[Piranha]

It seems like pclass is an array from where you send it, please look at that code since this code is doing exactly what it should. Takes the value and use it as the image name.

[w4designs]

I'm way too much of a php newb to be able to know how to change the code. That's why i asked. I'm just at a loss. I know when the pages for a particular property class like land for example is loaded, the full url shows:

http://mydomain.com/realty/index.php?action=search_step_2&pclass[]=2

In that instance, if I look in my MySQL database, that particular property type shows a "class_id" of 2.

I just don't know where to go from here. I've tried changing pclass to class_id in my code and that does nothing but I figured it was worth a shot to give it the actual field name from the database.

[Piranha]

pclass[]=2 makes it an array. Don't use it unless you need to pass on more than one value with the same name.
pclass=2 makes it a value. Normally this is what should be used.

[w4designs]

OK, i'm following along. so, how does that mean I have to change my code to make it work?

Thanks for your help by the way!

[bradgrafelman]

Is there any reason you need to store multiple values to the plclass variable in the URL? If not, change the URL to read "&pclass=" instead of "&pclas[]=".

Otherwise, if you want to keep 'pclass' an array, you'd use something like this:

// example url: http://mysite.com/myscript.php?pclass[]=foo&pclass[]=bar
echo $_GET['pclass'][0]; // returns the 1st value for pclass in URL (foo)
echo $_GET['pclass'][1]; // returns the 2nd value for pclass in URL (bar)

[w4designs]

well I'm using an open source php realty app called openrealty. I'm trying to make this modification to it and that's the url format that is set by the app.