[RESOLVED] Converting errors to exceptions

[reeksy]

Hi

I am in the process of building a new framework and I want to get the core functionality sorted as best as possible can before I go too far. I’ve now got to my errors and exceptions module; I want all default errors and uncaught exceptions be handled in one place. Getting this far isn’t too tricky, however displaying useful error information is!

Here’s what I’ve got so far:

<?
	// Custom error handler
	function errorHandler($errno, $errstr, $errfile, $errline) {
		throw new Exception($errstr, $errno);
	}
	set_error_handler('errorHandler');


// Custom exception handler
function exception_handler($exception) {
	ob_end_clean();// Clean the buffer
	print "<br />";
	print "Uncaught exception: " . $exception->getMessage();
	print "<br />";
	print "Line: " . $exception->getLine();
}
set_exception_handler('exception_handler');


// Start ob
ob_start();

// Create an error
file_put_contents('cosmos:\\1.txt', 'asdf');
?>

This will output the following:

Uncaught exception: file_put_contents(cosmos:\1.txt) [function.file-put-contents]: failed to open stream: Invalid argument
Line: 4

The problem with this code is when I the error is returned it is pointing back to line 4. Line 4 is where the exception is thrown and not where the error occurred (line 24). Does anyone know how this could be extended to display the correct error information?

Jon

[MarkR]

PHP quietly introduced a class called ErrorException at some point recently (5.1.0 ?)

I use the following

// error handler function
function ErrorToException($errno, $errstr, $errfile, $errline)
{
        // Ensure that errors are suppressed properly.
        $reporting_level = error_reporting();
        if (($errno & $reporting_level) == 0) {
                return;
        }
        throw new ErrorException($errstr, $errno, $errno, $errfile, $errline);
}

Which sets the line number correctly, I think.

Mark

[reeksy]

Ok thanks Mark R.

Here is a revised copy:

<?php

// Custom error handler
function customErrorHandler($errno, $errstr, $errfile, $errline)
{
	// Ensure that errors are suppressed properly.
	$reporting_level = error_reporting(E_ALL);
	if (($errno & $reporting_level) == 0) {
		return;
	}
	throw new ErrorException($errstr, $errno, $errno, $errfile, $errline);
}
// Set error handler
set_error_handler('customErrorHandler');

// Custom exception handler
function customExceptionHandler($exception)
{
	// Clean the buffer. Note that the @ is required incase you called 
	// the function without an active buffer or that for some reason a 
	// buffer could not be deleted.
	while (@ob_end_clean());
	print "<h1>Uncaught exception</h1>";
	print "<h2>Message:</h2>";
	print $exception->getMessage();
	print "<h2>Line:</h2>";
	print $exception->getLine();
	print "<h2>File:</h2>";
	print $exception->getFile();
}
// Set exception handler
set_exception_handler('customExceptionHandler');

// Start ob
ob_start();

print 'This will not be displayed if an error occurred';

// Create an error
file_put_contents('cosmos:\\1.txt', 'asdf');

?>

A very simple copy at that, but the basic functionality is in place.

Jon