[RESOLVED] simple form example

tjbarr

How do I get this to insert into a database. I have a good connection

<form>

<table width="100%" border="0">
<tr>
<td width="17%">Inventory Number </td>
<td width="27%"><input name="Inv_num" type="text" id="Inv_num" maxlength="50"></td>
<td width="20%">Mark</td>
<td width="36%"><input name="sv_mark" type="text" id="sv_mark" maxlength="50"></td>
</tr>
<tr>
<?php

$conn = pg_connect("host=server.edu user=admindb password=test dbname=db_test");
if (!$conn)
{
echo "An error occured\n";
exit;
}

$query("INSERT INTO tbl_vessel (inv_no) VALUES($Inv_num)")
or die(mysql_error());

<input name="submit" type="submit" value="$values">

echo "Data Inserted!";

  </form>

cahva

You are connection to postgresql database yet you are using mysql functions like mysql_error();
Usage of $query(...) is not correct. For postgresql use pg_query(), for mysql mysql_query()
Never process form variables in the middle of page. Always put processing stuff at the start and put proper checks that there is indeed anything send via form. If your code would work now, it would always insert a row to database.

I encourage you to read the php manual how to use postgresql functions(if that indeed is the database you use).
http://www.php.net/

tjbarr

Yes sorry. I have a postgres database. I am interested in what to put in the form tag. Do I have to submit the answers to another page or can I put the query on the same page to insert to the database?

tjbarr

I have 2 pages, but nothing is getting inserted into the database. What am I doing wrong?

Page 1

      <form action=sv_t3.php method="post">

		   <table width="100%"  border="0">

<tr>
<td width="17%">Inventory Number </td>
<td width="27%"><input name="inv_no" type="text" id="inv_no" maxlength="50"></td>
<td width="20%">SV Type</td>
<td width="36%"><input name="sv_type" type="text" id="sv_type" maxlength="50"></td>
</tr>
<tr>
<td>SV Name </td>
<td><input name="sv_name" type="text" id="sv_name"></td>
maxlength="50"></td>
</tr>
<tr>
<input name="submit" type="submit" value="submit">
</td>
<td> </td>
</tr>

</table>

      </form>

Page 2
<?php include("../ccdsv/dbconn3.php");

/ This script inserts sacred vessel information into the sacred vessels database /
//a simple wrapper to reduce the code needed
//for each postgres query
function query($sql) {
global $db;
return pg_exec($db,$sql);
}

$inv_no = $GET['inv_no'];

$sv_type = $GET['sv_type'];

$sv_name = $_GET['sv_name'];

$sql="INSERT INTO tbl_vessel ( inv_no, sv_type, sv_name )
   values ('$inv_no', '$sv_type', '$sv_name')";
  pg_exec ($db, $sql);

/** END of section to insert into the table **/

cahva

You are sending it via post method so you should use $POST then:

$inv_no = $_POST['inv_no'];
$sv_type = $_POST['sv_type'];
$sv_name = $_POST['sv_name'];

You can use the same page(most coders prefer to use the same page). Just put checks to your first page.

I think its easier to put the whole code so you get the idea. This is basically the page you need:

<?php
$msg = '';
if (!empty($_POST['inv_no']) && !empty($_POST['sv_type']) && !empty($_POST['sv_name'])) {

require('../ccdsv/dbconn3.php');

$inv_no = $_POST['inv_no'];
$sv_type = $_POST['sv_type'];
$sv_name = $_POST['sv_name'];


$sql =	"INSERT INTO tbl_vessel ( inv_no, sv_type, sv_name ) ".
		"values ('$inv_no', '$sv_type', '$sv_name')";
$result = pg_query($db, $sql);
if (!$result) {
	$msg = 'An error occured.';
} else {
	$msg = 'Data succesfully added.';
}
}
?>
<html>
<head>
<title>Test</title>
</head>
<body>
<?php
if (!empty($msg)) {
	echo $msg;
}
?>
<form action="<?php echo $_SERVER['SCRIPT_NAME'];?>" method="post">

<table width="100%" border="0">
<tr>
<td width="17%">Inventory Number </td>
<td width="27%"><input name="inv_no" type="text" id="inv_no" maxlength="50"></td>
<td width="20%">SV Type</td>
<td width="36%"><input name="sv_type" type="text" id="sv_type" maxlength="50"></td>
</tr>
<tr>
<td>SV Name </td>
<td><input name="sv_name" type="text" id="sv_name"></td>
maxlength="50"></td>
</tr>
<tr>
<input name="submit" type="submit" value="submit">
</td>
<td> </td>
</tr>

</table>

</form>
</body>
</html>

liquorvicar

Your form is defined as using the POST method but you are retieving the variables using the $_GET superglobal.

Plus, you must check any values coming from outside PHP. At the very least use pg_escape_string()

tjbarr

Thanks

tjbarr

I used this code for my first page and I get an error ocurred.

<?php

$msg = '';
if (!empty($POST['inv_no']) && !empty($POST['sv_type']) && !empty($_POST['sv_name'])) {

require('../ccdsv/dbconn3.php'); 

$inv_no = $_POST['inv_no']; 
$sv_type = $_POST['sv_type']; 
$sv_name = $_POST['sv_name']; 


$sql =    "INSERT INTO tbl_vessel ( inv_no, sv_type, sv_name ) ".
           "values ('$inv_no', '$sv_type', '$sv_name')"; 
$result = pg_query($db, $sql); 
if (!$result) { 
    $msg = 'An error occured.'; 
} else { 
    $msg = 'Data succesfully added.'; 
}

}
?>
<html>
<head>
<title>Test</title>
</head>
<body>
<?php
if (!empty($msg)) {
echo $msg;
}
?>
<form action="<?php echo $_SERVER['SCRIPT_NAME'];?>" method="post">

<table width="100%" border="0">
<tr>
<td width="17%">Inventory Number </td>
<td width="27%"><input name="inv_no" type="text" id="inv_no" maxlength="50"></td>
<td width="20%">SV Type</td>
<td width="36%"><input name="sv_type" type="text" id="sv_type" maxlength="50"></td>
</tr>
<tr>
<td>SV Name </td>
<td><input name="sv_name" type="text" id="sv_name" maxlength="50"></td>
</tr>
<tr>
<input name="submit" type="submit" value="submit">
</td>
<td> </td>
</tr>
</table>

</form>
</body>
</html>

Here is what my dbconn3 looks like

<?php
$conn = pg_connect("host=host.com user=admindb
password=22root dbname=ccd_sv");
if (!$conn)
{
echo "An error occured\n";
exit;
}

cahva

Do you get that "An error occured" from the query or connection? If you didnt receive it before, it must be from that query.

Try:
if (!$result) {
$msg = pg_last_error($conn);
}

That should tell you exactly what is wrong with the query.

tjbarr

The result is empty.

tjbarr

I am not getting the error anymore but if I echo out the $result - it is blank.

cahva

Well it should give an resource id.
What does var_dump($result); give you?
If its false, then the query did not work.

Also try:
echo pg_last_error($conn); right after the query.

I'm really not an expert on psql so try to read the manual.

tjbarr

Thanks everyone. The problem was I didn't give my connection logon the permission to insert into the table.