help with = header("Location:$correct")

[jayinhalifax]

i have a form within html that takes first name and a customers email address,
the form them proceeds onto check_email.php (php code detailed below) i was under the impression that the below code would check the email address then redirect to the corect or incorrect php file. when i test this nothing happens......can anyone help

<?php

// ----------------- PHP VARIABLS----------------------



$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';

function is_valid_email($email) {
$result = TRUE;

if(!eregi("^{[a-z0-9-]+(.[a-z0-9-]+)@[a-z0-9-]+(.[a-z0-9-]+)(.[a-z]{2,4})$",}
$email)) {
header("Location:$correct");
}
header("Location:$incorrect");}
?>

[NogDog]

Where do you call the is_valid_email() function you define in your code snippet, above?

[NogDog]

PS: HTTP 1.1 specifies that the Location value should always be a full URI, i.e.:

header("Location: http://www.yoursite.com/$correct");

[jayinhalifax]

no idea, i just copied this code from some example, sorry but im not a php developer so i dont understand. All i want to do is check and email address that was entered in a form from previouos page and if correct go to jcorrect.php or if incorrect goto jincorrect.php

[NogDog]

This block of code...

function is_valid_email($email) {
$result = TRUE;

if(!eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$",
$email)) {
header("Location:$correct");
}
header("Location:$incorrect");}

...is defining a function called "is_valid_email". It does not do anything in and of itself: you need to "call" it from within your script, passing as its one parameter the email address you want to validate. If, for an example (since I don't know how you are accessing the page or other details), you were calling this page from a form using the "post" method with an input field called "email" for the email address, then you might use it like this:

<?php
$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';

function is_valid_email($email) {
   $result = TRUE;
   if(!eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$",
   $email)) {
      header("Location:$correct");
   }
   header("Location:$incorrect");
}
is_valid_email($_POST['email']);
?>

[jayinhalifax]

thanks for the code,

i added this code into the php file and ran a test on internet, and resulted in error msg:

Warning: Cannot modify header information - headers already sent by (output started at /home/pokitsho/public_html/Check_email.php:2) in /home/pokitsho/public_html/Check_email.php on line 10

[jayinhalifax]

if i add this code to my check_email.php file, the php file stays static, nothing.....

<?php
$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';
function is_valid_email($email){
$result = TRUE;
if(!eregi("^{[a-z0-9-]+(.[a-z0-9-]+)@[a-z0-9-]+(.[a-z0-9-]+)(.[a-z]{2,4})$",}
$email)) {
header("Location:$correct");
}
header("Location:$incorrect");
}
is_valid_email($_POST['email']);
?>

but if i add this code th ethe check_email.php file it bounces back to my index.html page

<?php
$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';
function is_valid_email($email){
$result = TRUE;
if(!eregi("^{[a-z0-9-]+(.[a-z0-9-]+)@[a-z0-9-]+(.[a-z0-9-]+)(.[a-z]{2,4})$",}
$email)) {
header("Location: http://www.MYSITE.com/$correct");
}
header("Location: http://www.MYSITE.com/$incorrect");
}
is_valid_email($_POST['email']);
?>

STILL NOT WORKING

[Weedpacket]

This part

   if(....) {
      header("Location:$correct");
   }
   header("Location:$incorrect");

is faulty. Immediately after sending the $correct location header, it will send the $incorrect location header. Best way of fixing this is probably:

   if(....) {
      header("Location:$correct");
   }
   else {
      header("Location:$incorrect");
   }
   exit;

But however it's done, the header should be followed by exit, since there is no more processing to be done on this page.

Another thing.

if(!eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$",
$email))

Unless I'm reading this wrong, this test succeeds if the mail is not valid.

One more thing:

$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';
function is_valid_email($email){
...
header("Location: http://www.MYSITE.com/$incorrect");}

Because $correct and $incorrect were given their values outside the function, they don't have any value inside the function. "http://www.MYSITE.com/$incorrect" will just become "http://www.MYSITE.com/" - which no doubt is a URL to your index page.

It looks from this like you don't need the function itself at all, only the code it contains.

if(!eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$",
$_POST['email'])) {
    header("Location: http://www.MYSITE.com/Jcorrect.php");
}
else {
    header("Location: http://www.MYSITE.com/Jincorrect.php");
}

[ClarkF1]

You also need to make sure there is no whitespace in the file which may get sent to the browser.......make sure the < of <? is the very first character of the file

[jayinhalifax]

THANKS FOR AL LYOUR HELP GUYS

I've added the below code into the emial_check.php file and if you enter a valid email address you are directed to the jcorrect.php file.... this is correct.

within this jcorrect.php file i have this (below) code to add the first name and email adddress to my database, but this does not happen. do i need to pass the date from the two text boxes on the first page, the the email_check.php file, then check the email and if ok go to jcorrect.php where it should then load the first name and email address into the database.

<?php

//----------------- Ipdate Database --------------

//mysql_connect("localhost","USERNAME","PASSWORD") or die(mysql_error());
	$connect = mysql_connect("localhost","USERNAME","PASSWORD") or die(mysql_error());

//mysql_select_db("TABLENAME", $connect);
	mysql_select_db("DATABASE", $connect) or die(mysql_error());

//$sql = 'INSERT INTO `B_requests` (`Fname`, `Email`) VALUES (\'$Fname\', \'$Email\');';
	$sql = mysql_query("INSERT INTO `B_requests` (`Fname`, `Email`) VALUES ('$Fname', '$Email')");
	if (!$sql) { echo mysql_error(); }

// ---------------- SEND MAIL FORM ----------------

// send e-mail to
	$to = $Email;

// Your subject
	$subject="From www.MYSITE.com";

// Message
	$message="Thank you for registering your details, we will send you a free online brochure shortly. ";

// From	- $header="From: Your-Name <[e-mail]>";
	$header="From: <[e-mail]>";

// send email
	$sentmail = mail($to,$subject,$message,$header);


// error handeling
	if($sentmail){
		echo "Acknowledgement email sent";
	}else{
	echo "Cannot send Confirmation e-mail";
	}

?>

[jayinhalifax]

many thans to all, now sorted

<?php
$Fname = $GET['Fname'];
$Email = $GET['Email'];
$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';
$result = TRUE;
if (!eregi("^{[a-z0-9-]+(.[a-z0-9-]+)@[a-z0-9-]+(.[a-z0-9-]+)(.[a-z]{2,4})$",} $_GET['Email']))
{
header("Location: http://www.MYSITE.com/$incorrect");
}
else {
header("Location: http://www.MYSITE.com/$correct");
}
exit;
?>