[RESOLVED] can't sort -HELP-

Pehape

I can't get my record sorted..., i give link for user to pick, order from title,author,etc...

i take this $sb from $_GET pass var method , i check it with isset and fine. i'm sure it have its value...
i use variabel to set in my query later...

switch (true)
{
 case $sb=="title" : $sb="title"; break;
 case $sb=="title2" : $sb="title"; $dirct="DESC"; break;
 case $sb=="newest" : $sb="dates"; break;
 case $sb=="oldest" : $sb="dates"; $dirct="DESC"; break;
 case $sb=="author" : $sb="user_id"; break;
 default : $sb="dates";
}

then i make query select :
...order by '$sb' '$dirct'

i try to echo the query, it's fine..., i also run it on sql command, it's run well too...
but in my browser it won't sorted...
i don't know why...?? anyone has the clue..or have expericenced this?

zingbats

Can you copy an example query please?

void_function

What kind of switch is this? Why don't you switch ($sb) and check cases directly?

switch ($sb) {
  case 'title': ...; break;
  case 'title2': ...; break;
  ...
}

As for query, putting the '$sb' and '$dirct' in single quotes will yield an error: ORDER BY 'title' 'DESC'. You need backticks for $sb (if at all), and no quotes for DESC.

Pehape

thank you all, i think my prob is on single quote, i remove the quote and it's worked.
i think $sb and $dirct is a string, so i must wrap it with quote,
i guess i did it on my other queries, i wrap a string field variable with quote.. it's worked too, weird... any way thanks ...

void_function

Pehape wrote:
i think $sb and $dirct is a string, so i must wrap it with quote,
i guess i did it on my other queries, i wrap a string field variable with quote.. it's worked too, weird... any way thanks ...

You only wrap in quotes when you insert the string into a table field, which makes sense, since MySQL expects everything else (outside of the quotes) to be valid SQL keywords, tablenames or fieldnames.

bradgrafelman

void_function wrote:
since MySQL expects everything else (outside of the quotes) to be valid SQL keywords, tablenames or fieldnames.

Or numbers (which should not be wrapped in quotes).

Don't forget to mark this thread resolved.