Do I need a WHERE statement?

[Jon12345]

This code is supposed to insert the value 1 in a VARCHAR field if the ipaddress is already in the database.

Will it work as it currently is or do I need to modify it to include a WHERE statement?

$ipaddress=$_SERVER['REMOTE_ADDR']; 
$ip_query = @mysql_query("SELECT * FROM visitor_log WHERE ipaddress = '$ipaddress'");

if (mysql_num_rows($ip_query) < 1) {
    $query1="INSERT INTO visitor_log (action) VALUES ('1')";
    mysql_query($query1) or die('Database Query Error: '.mysql_error());
}

mysql_close($db1)  

Thanks,

Jon

[theelectricwiz]

Jon12345 wrote:

This code is supposed to insert the value 1 in a VARCHAR field if the ipaddress is already in the database.

Will it work as it currently is or do I need to modify it to include a WHERE statement?

$ipaddress=$_SERVER['REMOTE_ADDR']; 
$ip_query = @mysql_query("SELECT * FROM visitor_log WHERE ipaddress = '$ipaddress'");

if (mysql_num_rows($ip_query) < 1) {
    $query1="INSERT INTO visitor_log (action) VALUES ('1')";
    mysql_query($query1) or die('Database Query Error: '.mysql_error());
}

mysql_close($db1)  

Thanks,

Jon

Hello,

It depends where you want the '1' inserted into. The script you have will currently add a '1' to the action field of all the rows in your table if the ipaddress is not detected. If you are wanting it to be inserted into the same row as the ip address you will need a where statement to tell it to insert into that specific row.
If all you are doing is that you could try instead using a statement like

"UPDATE visitor_log SET action = '1' WHERE ipaddress='$ipaddress'"

+/- a few things if you are wanting to do things such as concatenate the action field etc. Then if you need to you can check if any rows were effected using mysql_affected_rows

Hope that helps. 🙂

[Jon12345]

Ok, getting there. But it still doesn't work. Do you think my modified version will do it?

 $ipaddress=$_SERVER['REMOTE_ADDR'];
$ip_query = @mysql_query("SELECT * FROM visitor_log WHERE ipaddress = '$ipaddress'");

if (mysql_num_rows($ip_query) >0 {
    $query1="UPDATE visitor_log SET action = '1' WHERE ipaddress='$ipaddress'";
    mysql_query($query1) or die('Database Query Error: '.mysql_error());
}

mysql_close($db1) 

Or, do I even need to have the if statement and just have the entire code as this:

 $ipaddress=$_SERVER['REMOTE_ADDR'];

$query1="UPDATE visitor_log SET action = '1' WHERE ipaddress='$ipaddress'";
mysql_query($query1) or die('Database Query Error: '.mysql_error());

mysql_close($db1) 

Would that work? If the ipaddress is not in the database, nothing happens. Otherwise, it puts '1' in the action field? Would I need to suppress errors if no ipaddress is found in the database?

Also notice I changed the if statement to >0 so that it works correctly!

[theelectricwiz]

Yeah, the second thing should work. You are right - it will not change anything or produce any errors if the ip address is not in the table.

[Jon12345]

There is some code from a program I use that is triggered as an include on the first row of my webpage.

Does the $ipaddress=$_SERVER['REMOTE_ADDR']; code need to be run before any output to the webpage?

[theelectricwiz]

no it shouldn't need to be