passing data from php to php files

[jayinhalifax]

[FONT=Comic Sans MS]I collect firstname and an email address via a form on page1.html

the data is then passed to check_email.php to varify the email address is a valid email address (this works) BUT

i then need to first name and email adddress passsed through to correct.php where the data is wrote to a data base. BUT

the data is not passing through from check_email.php to correct.php

can anyone please help!![/FONT]

[void_function]

If you include() correct.php inside check_email.php all globals and functions from check_email.php will be available to code in correct.php

But I smell bad code design here. Why multiple scripts? Can't you have one form
processing script that does everything?

[jayinhalifax]

so who would you code that.....sorry im no php programmer........

[void_function]

<form action="example.php" method="post">
  Name: <input type="text" name="name" /><br />
  Email: <input type="text" name="email" /><br />
  <input type="submit" value="submit" />
</form>

Example.php:

// Fetch data and escape strings for database insertion
$name= (isset($_POST['name'])) ? (mysql_real_escape_string(trim($POST['name']))) : '';
$email= (isset($_POST['email'])) ? (mysql_real_escape_string(trim($POST['email']))) : '';

// If any of the two not set, call error, or not...
if (!$name || !$email) {
  // report error
  ...
}

// Validate email here - string escaping has no impact to email validation, since escaped characters have no business in email address anyways.
...


// Open connection to database
...

// And insert data
$res= mysql_query("INSERT INTO tablename (field_name, field_email) VALUES ('{$name}', '{$email}')");

// Report success or mysql error here
...

[jayinhalifax]

my form html code =

<form method="GET" action=Check_email.php? action=mailMe>
<tr>
<td align="left" width="167" height="38">Please enter your first name here:
</td>
<td align=left width="322" height="38"><font face="Arial" color="#C0C0C0">
<input type="text" color="white" name="Fname" size=63 maxlength=40></font>
</td>
</tr>
<tr>
<td width="167" height="1">
</td>
</tr>
<tr>
<td align="left" width="167" height="41">Please enter your email address here:
</td>
<td align=left width="322" height="41"><font face="Arial" color="#C0C0C0">
<input type="text" color="white" name="Email" size=63 maxlength=40></font>
</td>
</tr>
<tr>
<td width="167" height="1"></td>
</tr>
<tr>
<td align=left width="322" height="26"><font face="Arial" color="#C0C0C0">
<input type=submit value="Submit Your Details" style="color: #000000"></font></td>
</tr>
</form>

my check_email php (this checks for valid email from html page- if correct then go to jcorrect.php and update database)=

<?php
$Fname = $GET['Fname'];
$Email = $GET['Email'];
$correct = 'Jcorrect.php';
$incorrect = 'Jincorrect.php';
$result = TRUE;
if (!eregi("^{[a-z0-9-]+(.[a-z0-9-]+)@[a-z0-9-]+(.[a-z0-9-]+)(.[a-z]{2,4})$",} $_GET['Email']))
{
header("Location: http://www.pokit-shop.com/$incorrect");
}
else {
header("Location: http://www.pokit-shop.com/$correct");
}
exit;
?>

code in my jcorrect.php(as above)= (this should update database but no data passsed form through from check_email.php so data base always enters a black record).

<?php
include('check_email.php');
$emailus = '[e-mail]';
$Fname = $GET['Fname'];
$Email = $GET['Email'];
?>

html code inbetween

<?php

//----------------- Ipdate Database --------------

//mysql_connect to database
	$connect = mysql_connect("localhost","USERNAME","PASSWORD") or die(mysql_error());

//mysql_select database
	mysql_select_db("DATABASE", $connect) or die(mysql_error());

//mysql_incert data into database
	$sql = mysql_query("INSERT INTO `TABLE` (`Fname`, `Email`) VALUES ('$_GET['Fname']', '$_GET['Email']')");
	if (!$sql) { echo mysql_error(); }

// ---------------- SEND MAIL FORM ----------------

// send e-mail to
	$to = $_GET['Email'];

// Your subject
	$subject="From www.MYSITE.com";

// Message
	$message="Thank you for registering your details, we will send you a free online brochure shortly. ";

// From	- $header="From: Your-Name <[e-mail]>";
	$header="From: <[e-mail]>";

// send email
	$sentmail = mail($to,$subject,$message,$header);


// error handeling
	if($sentmail){
		echo "Acknowledgement email sent";
	}else{
	echo "Cannot send Confirmation e-mail";
	}

?>

[void_function]

Technically speaking, you should repeat the data fetched in $_GET in the url when calling Jcorrect.php, so in check_email.php:

$correct = "Jcorrect.php?Fname=$GET['Fname']&amp;Email=$GET['Email']";

Assuming that either your original form has enctype="application/x-www-form-urlencoded" attribute (next to action attribute, for example), OR in check_email.php:

$email= urlencode($GET['Email']);
$name= urlencode($GET['Fname']);
$correct = "Jcorrect.php?Fname=$name&amp;Email=$email";

HOWEVER, passing values from $_GET directly into SQL , as in your Jcorrect.php, is HIGH security risk, as various malicious code can be injected into your database.

Edit:

urlencode() is required to encode URL incompatible characters that may be present in email or name.

[jayinhalifax]

NOW SORTED

thank you very much for your help.