Whats wrong with this string?

Talon

I am still working on my flat-File CMS, so far it looks pretty good, but I have recently made a news section with a Pagination, and I can not figure out why this string right here will not work.

$nstring = "\n\n<?php\n\$i++;\n\$link[\$i] = \"<h1>".$title."</h1><div class='htimeauth'>
|".$date."| <a    href='#'>".$author."</a></div> <p>".$story."</p>\";
\nif (!preg_match(\$d, \$link[\$i]))\n
	\$link[\$i] = preg_replace   ('/one/', 'two', \$link[\$i]);\n?>";

Note: the error I get is.

Parse error: syntax error, unexpected '"' in /publish.php on line 28

NogDog

I copied-and-pasted the above code, and it processed without any parse errors. So you might want to look at the preceding lines for the source of your error.

Talon

I am still getting the same error. So I decided just to post the source I am using with the exception of the security mesures I am taking to secure the script.

$title = $_REQUEST['title'];  

  $author = $_REQUEST['author'];
    $story = $_REQUEST['story'];
    $date = date("d/m/Y");
    /////////////////////////////

   $news = "news.php"; 
   $fh = fopen($news,"a") or die("Could not open $news");  

  $nstring = "\n\n<?php\n\$i++;\n\$link[\$i] = \"<h1>".$title."</h1><div class='htimeauth'>|".$date."| <a    href='#'>".$author."</a></div> <p>".$story."</p>\";\nif (!preg_match(\$d, \$link[\$i]))\n	\$link[\$i] = preg_replace   ('/one/', 'two', \$link[\$i]);\n?>";    

fwrite($fh, "$nstring");  fclose($fh);

ClarkF1

Just tried that and it all works and writes fine to news.php

What data are you passing to the page with respect to title, author and story.

I'm just wondering whether it's something to do with magic quotes

Talon

well the data I am passing is just what you see there, the security measures are not getting passed to any of it. To be honest I knew the string was right, but I keep getting those error messages, It was begining to bug me to the point where I lost confidence in myself and as such posted here.

Just for question does news.php look alright without any error messages?

Weedpacket

magic quotes wouldn't have anything to do with a parse error; a parse error means that the script won't even run.

But since the pasted code apparently has no parse errors, what happens if you paste it back?

ClarkF1

Is there any way you could post the whole script including the method used to secure it censoring any information........it could be something that you haven't included so far that's causing the problem

scrupul0us

Talon wrote:
I am still working on my flat-File CMS, so far it looks pretty good, but I have recently made a news section with a Pagination, and I can not figure out why this string right here will not work.
$nstring = "\n\n<?php\n\$i++;\n\$link[\$i] = \"<h1>".$title."</h1><div class='htimeauth'>
|".$date."| <a    href='#'>".$author."</a></div> <p>".$story."</p>\";
\nif (!preg_match(\$d, \$link[\$i]))\n
	\$link[\$i] = preg_replace   ('/one/', 'two', \$link[\$i]);\n?>";  
Note: the error I get is.
Parse error: syntax error, unexpected '"' in /publish.php on line 28

works fine for me

scrupul0us

$nstring = '
\n\n
<?php\n
$i++;\n

$link[$i] = \"<h1>".$title."</h1>\n
<div class=\"htimeauth\">|'.$date.'| <a href=\"#\">'.$author.'</a></div>\n <p>'.$story.'</p>\";\n

if (!preg_match($d, $link[$i]))\n
{\n
$link[$i] = preg_replace (\"/one/\", \"two\", $link[$i])\n
}\n
;\n
?>
';

try that.... u have everything grouped so tight its hard to debug

and if u encapsulate the string in single quotes u dont have to escape all the variables

rkolbe

Is this file we are debugging called publish.php??