Help with arrays

[turtleton09]

I have a table structure :

photos : Photo_ID (PK), Title, Orientation etc
keywords : Keyword_ID, Keyword, Category
photokeywords : Photo_ID, Keyword_ID

I originally used hard coded checkboxes that people could use to enter keywords for each photo, but with some help managed to get started with arrays. I actually have it working where the keywords can be updated using an array of checkboxes, using the following code :

<form name="form1" method="POST" action="photoKeywordsEdited.php">
<input type='hidden' name='Photo_ID' value='<?php echo $Photo_ID; ?>'>
<?php require_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1; 
if (isset($_GET['Photo_ID'])) { 
  $Photo_ID = intval($_GET['Photo_ID']); 
} 
mysql_select_db($database_Photolibrary, $Photolibrary); 
$query_Keyword_Match = sprintf("SELECT * FROM photokeywords WHERE Photo_ID = %s", $Photo_ID); 
$Keyword_Match = mysql_query($query_Keyword_Match, $Photolibrary) or die(mysql_error()); 
$photokeywords = array(); 
while ($row_Keyword_Match = mysql_fetch_assoc($Keyword_Match)) { 
    $photokeywords[] = $row_Keyword_Match['Keyword_ID']; 
} 
$totalRows_Keyword_Match = mysql_num_rows($Keyword_Match); 
$sql = "SELECT * FROM Keywords ORDER BY Keyword_ID";
$keywordArray = array(); 
$query = mysql_query($sql); 



while ($result=mysql_fetch_assoc($query)) { 
    $keywordArray[$result['Category']][] = $result; 
} 
$current_category = ''; 

foreach ($keywordArray as $categoryData) 
{ 

if($current_category <> $categoryData[2]['Category']) 
            { 
                //open a new <tr> 
                echo "<tr class=\"categorycell\">\n"; 
                //print the category as a header 
                echo "<td colspan=\"10\">". $categoryData[2]['Category']."</td>\n"; 
                //close the <tr> 
                echo "</tr>\n"; 
                $current_category = $categoryData[2]['Category'];

        }       

$row_count = 0;
//even row 
if($row_count%2==0) 
{ 
    $row_type = 'even'; 
} 
//odd row 
else 
{ 
    $row_type = 'odd';             

}

echo("<tr class=\"".$row_type."\">"); 
foreach ($categoryData as $keywordData) { 



    echo("<td><input "); 
	if (in_array($keywordData['Keyword_ID'],$photokeywords)) { 
        echo "checked "; 
    } 
    echo('name="ckbox['.$keywordData['Keyword_ID'].']" type="checkbox" class="tickbox2" id="ckbox['.$keywordData['Keyword_ID'].']"></td>');



    echo("<td>".$keywordData['Keyword'].'</td>'); 



    if ($counter==4) { 
        echo('</tr><tr>'); 
        $counter = 0; 
    } else { 
        $counter++; 
    } 
} 

echo('</tr>'); 
$row_count++;
} 



?>

I'm having trouble modifying it for my original Add Keywords page - basically there's a previous page that collects the photo info for the photos table, then the user is directed to the add keywords page (so previously the Photo_ID) was passed through as a hidden field :

<input type='hidden' name='Photo_ID' value='<!--FIELDVALUE:Photo_ID-->'>

As I'm still a bit unfamiliar with the syntax for arrays, can anyone help out with modifying the code above for editing the keywords, to just adding them?

Hope that makes sense.

Cheers,
Iain

[liquorvicar]

As far as I can work out from your code, this will work for both adding keywords for a new image, and updating keywords for an existing image.

btw, the first few line of your code are a bit odd:

<form name="form1" method="POST" action="photoKeywordsEdited.php">
<input type='hidden' name='Photo_ID' value='<?php echo $Photo_ID; ?>'>
<?php require_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1;
if (isset($_GET['Photo_ID'])) {
  $Photo_ID = intval($_GET['Photo_ID']);
}

For this to work, I'm guessing you must have register_globals turned on in your server config. This is certainly NOT recommended. If you can't avoid it (i.e. it's a shared server), I'd recommend you employ some defensive programming tactics. Namely, make sure you initialise all variables you are using your script. As a general rule, you should validate all $GET or $POST data before using it. You seem to use $Photo_ID before you get it from the $_GET superglobal array.

[turtleton09]

liquorvicar wrote:

As far as I can work out from your code, this will work for both adding keywords for a new image, and updating keywords for an existing image.

btw, the first few line of your code are a bit odd:

<form name="form1" method="POST" action="photoKeywordsEdited.php">
<input type='hidden' name='Photo_ID' value='<?php echo $Photo_ID; ?>'>
<?php require_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1;
if (isset($_GET['Photo_ID'])) {
  $Photo_ID = intval($_GET['Photo_ID']);
}

For this to work, I'm guessing you must have register_globals turned on in your server config. This is certainly NOT recommended. If you can't avoid it (i.e. it's a shared server), I'd recommend you employ some defensive programming tactics. Namely, make sure you initialise all variables you are using your script. As a general rule, you should validate all $GET or $POST data before using it. You seem to use $Photo_ID before you get it from the $_GET superglobal array.

OK - cheers. When I tried it earlier it was just bringing up part of the code on the page instead of any expected checkboxes - so hopefully it's something simple.... I'll post exactly what tomorrow.

As for the other part - not too familiar with whatever's going on there - although it is all just an intranet project running on the server box at the office and over the office network locally. Does that reduce or any threat?

[liquorvicar]

duklaprague wrote:

OK - cheers. When I tried it earlier it was just bringing up part of the code on the page instead of any expected checkboxes - so hopefully it's something simple.... I'll post exactly what tomorrow.

What sort of code?

duklaprague wrote:

As for the other part - not too familiar with whatever's going on there - although it is all just an intranet project running on the server box at the office and over the office network locally. Does that reduce or any threat?

It might seem at first hand that the threat is reduced, and it may be (reduced that is but still present). However, there are numerous reasons to tighten up; it gets you into good habits, there's still the danger of hacked-off employees or someone hacking into the intranet, there's also the possibility of user error. It's good to be clear, organised and rigorous about your PHP scripts right from the start. You will appreciate the extra work further down the line, believe me!
If it's just your internal server and no-one else uses PHP on it, I'd strongly recommend turning register_globals off - this is now the default setting in PHP and one you'll often come up against. Code designed with register_globals off will work if they're on but not always the other way round.

[turtleton09]

At the moment the code looks like :

<form name="form1" id="form1" method="POST" action="photoProfilesAdded.php">
<input type='hidden' name='Photo_ID' value='<!--FIELDVALUE:Photo_ID-->'>
<table width="942px" border="0" cellpadding="0" cellspacing="0" align="center">


<?php require_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1; 
if (isset($_GET['Photo_ID'])) { 
  $Photo_ID = intval($_GET['Photo_ID']); 
} 



mysql_select_db($database_Photolibrary, $Photolibrary);
$query_Recordset1 = "SELECT * FROM photokeywords";
$Recordset1 = mysql_query($query_Recordset1, $Photolibrary) or die(mysql_error());
$row_Recordset1 = mysql_fetch_assoc($Recordset1);
$totalRows_Recordset1 = mysql_num_rows($Recordset1);


$keywordArray = array(); 
$query = mysql_query($sql); 



while ($result=mysql_fetch_assoc($query)) { 
    $keywordArray[$result['Category']][] = $result; 
} 
$current_category = ''; 

foreach ($keywordArray as $categoryData) 
{ 

if($current_category <> $categoryData[2]['Category']) 
            { 
                //open a new <tr> 
                echo "<tr class=\"categorycell\">\n"; 
                //print the category as a header 
                echo "<td colspan=\"10\">". $categoryData[2]['Category']."</td>\n"; 
                //close the <tr> 
                echo "</tr>\n"; 
                $current_category = $categoryData[2]['Category'];

        }       

$row_count = 0;
//even row 
if($row_count%2==0) 
{ 
    $row_type = 'even'; 
} 
//odd row 
else 
{ 
    $row_type = 'odd';             

}

echo("<tr class=\"".$row_type."\">"); 
foreach ($categoryData as $keywordData) { 



    echo("<td><input "); 
	if (in_array($keywordData['Keyword_ID'],$photokeywords)) { 
        echo "checked "; 
    } 
    echo('name="ckbox['.$keywordData['Keyword_ID'].']" type="checkbox" class="tickbox2" id="ckbox['.$keywordData['Keyword_ID'].']"></td>');



    echo("<td>".$keywordData['Keyword'].'</td>'); 



    if ($counter==4) { 
        echo('</tr><tr>'); 
        $counter = 0; 
    } else { 
        $counter++; 
    } 
} 

echo('</tr>'); 
$row_count++;
} 

?>

And is displaying this part of the PHP code on the add keywords page :

$categoryData[2]['Category']) { //open a new  

echo " 
\n"; //print the category as a header echo " 
\n"; //close the  

echo " 
\n"; $current_category = $categoryData[2]['Category']; } $row_count = 0; //even row if($row_count%2==0) { $row_type = 'even'; } //odd row else { $row_type 
= 'odd'; } echo("
 "); foreach ($categoryData as $keywordData) { echo("  

'); echo(" 
');  if ($counter==4) { echo('
'); $counter = 0; } else { $counter++; } } echo(' 
'); $row_count++; } ?>  

".$categoryData[2]['Category']."

SINGLE CHECKBOX HERE                                            ".$keywordData['Keyword'].'

Regarding the register globals - I checked the php.ini file, and they look as tho' they are switched off :

; You should do your best to write your scripts so that they do not require
; register_globals to be on; Using form variables as globals can easily lead
; to possible security problems, if the code is not very well thought of.
register_globals = Off

[liquorvicar]

Is it actually displaying that PHP code when you access the script via your browser?? That's odd. I've not see that before. WHat set up do you have? What http server etc?

As for register_globals, putting this:

echo 'register_globals = ' . ini_get('register_globals') . "\n";

in your script will give you a definitive answer (in case you have multiple php.ini files etc).

<form name="form1" id="form1" method="POST" action="photoProfilesAdded.php">
<input type='hidden' name='Photo_ID' value='<!--FIELDVALUE:Photo_ID-->'>
<table width="942px" border="0" cellpadding="0" cellspacing="0" align="center"> 

Are these the actual first 3 lines of your script? If so, how are you intending to get the Photo_ID value into the code?

[turtleton09]

It is, yes - and it's not even exactly as the script appears.

I couldn't get the register_globals to echo on the add keywords page at all, but dropped it into the add photo page, and it just displayed :

register_globals =

The Photo_ID is being passed to the page from the previous page - this I presume is working, as I display it just above the form with the line :

Photo ID : FIELDVALUE😛hoto_IDAdd keywords to this photo by checking the relevant boxes below.

And it appears with a new Photo_ID as I'd expect - with all that PHP code appearing below that.

[liquorvicar]

duklaprague wrote:

It is, yes - and it's not even exactly as the script appears.

Most odd. Can you post the entire script and the entire output here so I can have a look.

duklaprague wrote:

I couldn't get the register_globals to echo on the add keywords page at all, but dropped it into the add photo page, and it just displayed :

register_globals =

That's good, it just means you do have register_globals off.
From the manual:

When querying boolean values: A boolean ini value of off will be returned as an empty string or "0" while a boolean ini value of on will be returned as "1".

[turtleton09]

OK - this is the code that works for my edit keywords page. Ie If you go to a photo's details page, you can click on a link that takes you through to it, passing through the Photo_ID :

At the top of the page is the line :

<?php $Photo_ID = intval($_GET['Photo_ID']); ?>

And the main script doing the outputting of the checkboxes and labels is :

Photo ID :&nbsp;</span><span class="style27"><?php echo $Photo_ID; ?></span>


<table width="942px" border="0" cellpadding="0" cellspacing="0" align="center">
	<form name="form1" method="POST" action="photoKeywordsEdited.php">
<input type='hidden' name='Photo_ID' value='<?php echo $Photo_ID; ?>'>
<?php require_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1; 
if (isset($_GET['Photo_ID'])) { 
  $Photo_ID = intval($_GET['Photo_ID']); 
} 
mysql_select_db($database_Photolibrary, $Photolibrary); 
$query_Keyword_Match = sprintf("SELECT * FROM photokeywords WHERE Photo_ID = %s", $Photo_ID); 
$Keyword_Match = mysql_query($query_Keyword_Match, $Photolibrary) or die(mysql_error()); 
$photokeywords = array(); 
while ($row_Keyword_Match = mysql_fetch_assoc($Keyword_Match)) { 
    $photokeywords[] = $row_Keyword_Match['Keyword_ID']; 
} 
$totalRows_Keyword_Match = mysql_num_rows($Keyword_Match); 
$sql = "SELECT * FROM Keywords ORDER BY Keyword_ID";
$keywordArray = array(); 
$query = mysql_query($sql); 



while ($result=mysql_fetch_assoc($query)) { 
    $keywordArray[$result['Category']][] = $result; 
} 
$current_category = ''; 

foreach ($keywordArray as $categoryData) 
{ 

if($current_category <> $categoryData[2]['Category']) 
            { 
                //open a new <tr> 
                echo "<tr class=\"categorycell\">\n"; 
                //print the category as a header 
                echo "<td colspan=\"10\">". $categoryData[2]['Category']."</td>\n"; 
                //close the <tr> 
                echo "</tr>\n"; 
                $current_category = $categoryData[2]['Category'];

        }       

$row_count = 0;
//even row 
if($row_count%2==0) 
{ 
    $row_type = 'even'; 
} 
//odd row 
else 
{ 
    $row_type = 'odd';             

}

echo("<tr class=\"".$row_type."\">"); 
foreach ($categoryData as $keywordData) { 



    echo("<td><input "); 
	if (in_array($keywordData['Keyword_ID'],$photokeywords)) { 
        echo "checked "; 
    } 
    echo('name="ckbox['.$keywordData['Keyword_ID'].']" type="checkbox" class="tickbox2" id="ckbox['.$keywordData['Keyword_ID'].']"></td>');



    echo("<td>".$keywordData['Keyword'].'</td>'); 



    if ($counter==4) { 
        echo('</tr><tr>'); 
        $counter = 0; 
    } else { 
        $counter++; 
    } 
} 

echo('</tr>'); 
$row_count++;
} 



?>

</table>
<table>
<tr>&nbsp;</tr>
  <tr>
  <td>
  <input type="submit" name="Submit" value="Update Photo Keywords">
  <input type=button value="Cancel" onClick="history.go(-1)">
  </form></td>

</tr>

</table>

So really just trying to use this to add keywords when a photo is added.

I just tried pointing tha add photos page to my edit keywords page but it was the same, ie with all the PHP stuff appearing.

[liquorvicar]

You got me beat for now. If I get a moment later, I'll try and reproduce what's happening on my local system and have another look.

[turtleton09]

OK, cheers.

I'm wondering if it's worth starting over - with the form code :

<form name="form1" id="form1" method="POST" action="photoProfilesAdded.php">
<input type='hidden' name='Photo_ID' value='<!--FIELDVALUE:Photo_ID-->'>
<input type="submit" name="Submit" value="Add Photo Keywords">
<input type=button value="Cancel" onClick="history.go(-1)">
</form>

It seems fine insomuch as it's bringing through the Photo_ID of the newly created record.

So from there it's a case of displaying the checkboxes and their labels using an array, with this as a basis :

<?php require_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1; 
if (isset($_GET['Photo_ID'])) { 
  $Photo_ID = intval($_GET['Photo_ID']); 
} 
mysql_select_db($database_Photolibrary, $Photolibrary); 
$query_Keyword_Match = sprintf("SELECT * FROM photokeywords WHERE Photo_ID = %s", $Photo_ID); 
$Keyword_Match = mysql_query($query_Keyword_Match, $Photolibrary) or die(mysql_error()); 
$photokeywords = array(); 
while ($row_Keyword_Match = mysql_fetch_assoc($Keyword_Match)) { 
    $photokeywords[] = $row_Keyword_Match['Keyword_ID']; 
} 
$totalRows_Keyword_Match = mysql_num_rows($Keyword_Match); 
$sql = "SELECT * FROM Keywords ORDER BY Keyword_ID";
$keywordArray = array(); 
$query = mysql_query($sql); 
echo('<table>');

while ($result=mysql_fetch_assoc($query)) { 
    $keywordArray[$result['Category']][] = $result; 
} 

foreach ($keywordArray as $categoryData) 
{ 
if($current_category <> $categoryData['Category']) 
            { 
                //open a new <tr> 
                echo "<tr>\n"; 
                //print the category as a header 
                echo "<td>". $categoryData['Category']."</td>\n"; 
                //close the <tr> 
                echo "</tr>\n"; 
                $current_category = $categoryData['Category']; 
            }      

echo('<tr>'); 
foreach ($categoryData as $keywordData) { 

    echo('<td><input ');

    if (in_array($keywordData['Keyword_ID'],$photokeywords)) { 
        echo "checked "; 
    } 
    echo('name="ckbox['.$keywordData['Keyword_ID'].']" type="checkbox" class="tickbox2" id="ckbox['.$keywordData['Keyword_ID'].']"></td>'); 
    echo('<td>'.$keywordData['Keyword'].'</td>'); 

    if ($counter==3) { 
        echo('</tr><tr>'); 
        $counter = 0; 
    } else { 
        $counter++; 
    } 
} 
echo('</tr>'); 
} 
?>

I'll keep head scratching here, but if you do spot anything let me know!

[liquorvicar]

uire_once('Connections/Photolibrary.php');
error_reporting(E_ALL & E_STRICT);
$Photo_ID = 1;
if (isset($_GET['Photo_ID'])) {
  $Photo_ID = intval($_GET['Photo_ID']);
}
mysql_select_db($database_Photolibrary, $Photolibrary);
$query_Keyword_Match = sprintf("SELECT * FROM photokeywords WHERE Photo_ID = %s", $Photo_ID);
$Keyword_Match = mysql_query($query_Keyword_Match, $Photolibrary) or die(mysql_error());
$photokeywords = array();
while ($row_Keyword_Match = mysql_fetch_assoc($Keyword_Match)) {
    $photokeywords[] = $row_Keyword_Match['Keyword_ID'];
}
$totalRows_Keyword_Match = mysql_num_rows($Keyword_Match);
$sql = "SELECT * FROM Keywords ORDER BY Keyword_ID";
$keywordArray = array();
$query = mysql_query($sql);
echo('<table>');

while ($result=mysql_fetch_assoc($query)) {
    $keywordArray[$result['Category']][] = $result;
}

All looks OK so far.

foreach ($keywordArray as $categoryData)
{
if($current_category <> $categoryData['Category'])
            {
                //open a new <tr>
                echo "<tr>\n";
                //print the category as a header
                echo "<td>". $categoryData['Category']."</td>\n";
                //close the <tr>
                echo "</tr>\n";
                $current_category = $categoryData['Category'];
            }      

You can actually tidy this bit up a bit. You don't need the if statement as foreach will loop through each category only once. You can replace this with

foreach ($keywordArray as $catgeoryName=>$categoryData)
{
         //open a new <tr>
         echo "<tr>\n";
         //print the category as a header
          echo "<td>". $catgeoryName."</td>\n";
          //close the <tr>
          echo "</tr>\n";

    echo('<tr>');
    foreach ($categoryData as $keywordData) {

    echo('<td><input ');

    if (in_array($keywordData['Keyword_ID'],$photokeywords)) {
        echo "checked ";
    }
    echo('name="ckbox['.$keywordData['Keyword_ID'].']" type="checkbox" class="tickbox2" id="ckbox['.$keywordData['Keyword_ID'].']"></td>');
    echo('<td>'.$keywordData['Keyword'].'</td>');

    if ($counter==3) {
        echo('</tr><tr>');
        $counter = 0;
    } else {
        $counter++;
    }
}
echo('</tr>');
}
?>

This looks OK except I think you need to reset your $counter variable. At the moment it will only put an extra <TR> in once. Did you want to reset it on each iteration of the outer loop?

[turtleton09]

I've stripped down the page to just :

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Add keywords to photo</title>
</head>

<body>
Photo ID :<!--FIELDVALUE:Photo_ID-->Add keywords to this photo by checking the relevant boxes below.
<form name="form1" id="form1" method="POST" action="photoProfilesAdded.php">
<input type='hidden' name='Photo_ID' value='<!--FIELDVALUE:Photo_ID-->'>
<table width="942px" border="0" cellpadding="0" cellspacing="0" align="center">


<?php require_once('Connections/Photolibrary.php'); 
error_reporting(E_ALL & E_STRICT); 
$Photo_ID = 1; 
if (isset($_GET['Photo_ID'])) { 
  $Photo_ID = intval($_GET['Photo_ID']); 
} 
mysql_select_db($database_Photolibrary, $Photolibrary); 
$query_Keyword_Match = sprintf("SELECT * FROM photokeywords WHERE Photo_ID = %s", $Photo_ID); 
$Keyword_Match = mysql_query($query_Keyword_Match, $Photolibrary) or die(mysql_error()); 
$photokeywords = array(); 
while ($row_Keyword_Match = mysql_fetch_assoc($Keyword_Match)) { 
    $photokeywords[] = $row_Keyword_Match['Keyword_ID']; 
} 
$totalRows_Keyword_Match = mysql_num_rows($Keyword_Match); 
$sql = "SELECT * FROM Keywords ORDER BY Keyword_ID"; 
$keywordArray = array(); 
$query = mysql_query($sql); 
echo('<table>'); 

while ($result=mysql_fetch_assoc($query)) { 
    $keywordArray[$result['Category']][] = $result; 
} 
foreach ($keywordArray as $catgeoryName=>$categoryData) 
{ 
         //open a new <tr> 
         echo "<tr>\n"; 
         //print the category as a header 
          echo "<td>". $catgeoryName."</td>\n"; 
          //close the <tr> 
          echo "</tr>\n"; 
echo('<tr>'); 
    foreach ($categoryData as $keywordData) { 

    echo('<td><input '); 

    if (in_array($keywordData['Keyword_ID'],$photokeywords)) { 
        echo "checked "; 
    } 
    echo('name="ckbox['.$keywordData['Keyword_ID'].']" type="checkbox" class="tickbox2" id="ckbox['.$keywordData['Keyword_ID'].']"></td>'); 
    echo('<td>'.$keywordData['Keyword'].'</td>'); 

    if ($counter==3) { 
        echo('</tr><tr>'); 
        $counter = 0; 
    } else { 
        $counter++; 
    } 
} 
echo('</tr>'); 
} 
?> 

</table>

<table>
<tr>
  <td>
  <input type="submit" name="Submit" value="Update Photo Keywords">
  <input type=button value="Cancel" onClick="history.go(-1)">
  </form></td>

</tr>

</table>


</div>
</body>
</html>

but it's still insisting on displaying all that PHP on the page.

'); while ($result=mysql_fetch_assoc($query)) { $keywordArray[$result['Category']][] = $result; } foreach ($keywordArray as 
$catgeoryName=>$categoryData) { //open a new  echo " 
\n"; //print the category as a header echo " ". $catgeoryName." \n"; //close the  

echo " 
\n"; echo('
');foreach ($categoryData as $keywordData) { echo('
'); echo('
')if ($counter==3) { echo('
'); ($counter = 0; } else { $counter++; } } echo('
'); } ?>
".$categoryName."

CHECKBOX HERE                                    '.$keywordData['Keyword'].'