Error with uploading digicam pics

[adastra]

I wrote a small gallery script, but I need some help with it - it always worked fine so far, but right now I tested uploading some pictures I took with my digicam without editing the image or name, and I got a loong error page. Then I tried uploading a unedited pictures from a friend's digicam - which also didn't work.

Then I tested uploading a wallpaper I made, and some other stuff, and that worked totally fine! I also tested uploading a resized & edited pic which I took with my digicam, which also worked totally fine!

Help! What is this? Why doesn't my script upload unedited digicam pictures???

This is the part of the script which does the uploading:

$uploadedfile = $_FILES['photo']['tmp_name'];
        $src = imagecreatefromjpeg($uploadedfile);
        list($width,$height) = getimagesize($uploadedfile);
        if ($width > $maxwidth) {
            $newwidth = $maxwidth;
            $newheight = ($height/$width)*$newwidth;
        } else {
            $newwidth = $width;
            $newheight = ($height/$width)*$newwidth;
        }
        $tmp = imagecreatetruecolor($newwidth,$newheight);
        imagecopyresampled($tmp,$src,0,0,0,0,$newwidth,$newheight,$width,$height);
        $filename = $dirpath.$gal_id."/".$_FILES['photo']['name'];
        imagejpeg($tmp,$filename,100);

    #__ thumb _________________________________________________________
    $uploadedthumb = $_FILES['photo']['tmp_name'];
    $srcthumb = imagecreatefromjpeg($uploadedthumb);
    list($widththumb,$heightthumb) = getimagesize($uploadedthumb);
    $newwidththumb = 100;
    $newheightthumb = 75;

    $src_top = ($src_height / 2) - ($dst_height / 2);
    $src_left = ($src_width / 2) - ($dst_width / 2);

    $tmpthumb = imagecreatetruecolor($newwidththumb,$newheightthumb);
    imagecopyresampled($tmpthumb,$srcthumb,0,0,$src_top,$src_left,$newwidththumb,$newheightthumb,$widththumb,$heightthumb);
    $thumbname = $dirpath.$gal_id."/zth_".$_FILES['photo']['name'];
    imagejpeg($tmpthumb,$thumbname,100);
    #___________________________________________________________________

    imagedestroy($srcthumb);
    imagedestroy($tmpthumb);
    imagedestroy($src);
    imagedestroy($tmp);

And this is the error page I get with unedited pics:

Warning: Division by zero in /www/htdocs/gallery/gal_postphotos.php on line 16

Warning: imagecreatetruecolor() [function.imagecreatetruecolor]: Invalid image dimensions in /www/htdocs/gallery/gal_postphotos.php on line 18

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /www/htdocs/gallery/gal_postphotos.php on line 19

Warning: imagejpeg(): supplied argument is not a valid Image resource in /www/htdocs/gallery/gal_postphotos.php on line 21

Warning: imagecopyresampled(): supplied argument is not a valid Image resource in /www/htdocs/gallery/gal_postphotos.php on line 34

Warning: imagedestroy(): supplied argument is not a valid Image resource in /www/htdocs/gallery/gal_postphotos.php on line 40

Warning: imagedestroy(): supplied argument is not a valid Image resource in /www/htdocs/gallery/gal_postphotos.php on line 42

Warning: imagedestroy(): supplied argument is not a valid Image resource in /www/htdocs/gallery/gal_postphotos.php on line 43

[stolzyboy]

tho the error don't state it, you could be having script timeout issues, filesize issues, etc...

what MP is your camera, typically decent MP cams create very LARGE files (dimensions and filesize) which is likely creating your problem

take a raw image from your cam and simply resize it and try the upload, if that works, that is likely your problem, play around with sizes and find the line where it goes too big

PHP could care less if it's an unedited digicam pic or just a huge pic from somewhere else... but size does matter 🙂

hth,
stolzyboy

[adastra]

My cam is a cheap Canon PowerShot A70 - usually my dimensions are like 1600xsomething, so not that big.

The upload works with edited/resized pictures, that's the strange thing here! But it would be important that the script would also work with unedited pictures... :/

[bradgrafelman]

What is the upload_max_filesize directive set to? How about the memory_limit?

[stolzyboy]

that's what i'm trying to get out of him... 1600x can create decent file "sizes" as in MB... maybe not, but... your script could be timing out, running out of memory, max filesize limits could be getting hit, etc...

i'm assuming your cam is giving you .jpg images?

[adastra]

well I have this in the form
<input type="hidden" name="upload_max_filesize" value="2076637" />

i don't know about memory_limit though. Keep in mind that I'm a noob :rolleyes:
Yeah, my cam gives me JPGs...

But now that you're all saying it and I tested it again, I think it might actually be something about the size... The script does 1024, but it doesn't do 1600....

how can i fix that?

[bradgrafelman]

1. Your hidden INPUT element doesn't tell me what the upload_max_filesize directive is. Use [man]phpinfo/man (or even [man]ini_get/man...) to find the true value.

2. See latter half of #1 above in regards to memory_limit.

3. To fix it? Well, if we can pinpoint the bottleneck, we can see if it's simply a configuration change that needs to be made.