Strange update problem

webmasternovis

Hi all,

Everytime a script on my site runs, I want to add '1' to a certain field in my database. At the moment the following code is supposed to cover that:

$newviews = $rowresult[views] + 1;

// update views
mysql_query("UPDATE games SET views='$newviews' WHERE id='$rowresult[id]'");

Strangely though, instead of adding 1, 2 is added to the original figure. Could anyone explain why this could be happening?

Thanks,
Mike

Piranha

The problem is probably because you try to use an array in the query, that is not possible as you do it. But I can tell you a better way to accomplish the same task you do with two queries now:

$sql = "UPDATE games SET views = views + 1 WHERE id = '" . $rowresult['id'] . '";
mysql_query($sql);

The problem with doing it the way you did it before is that if many people are loading the page at the same time it won't be correct. By letting the DBMS do the counting it will be correct anyway.

webmasternovis

Hmmm... it still seems to do the same. It increases by two, instead of one.

Could there be another reason?

bradgrafelman

webmasternovis wrote:
Could there be another reason?

Well, MySQL knows how to count, so obviously the query is being executed twice.

webmasternovis

It can't be though, the query is right at the top of the page and isn't in a loop...

Piranha

As Bradgrafelman says either this code is being executed twice or a simular code is executed once and this code once. But the problem is not not in the code you or I posted.

If you post the whole code we might be able to help you out to find the problem.